Add const & to foreach 'iterators'

Change-Id: I8c0600dfd919f45d14a0011f2da9b9fe0b9a0df3
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Marc Mutz <marc.mutz@kdab.com>
Reviewed-by: Robin Burchell <robin+qt@viroteck.net>

3 files changed, 12 insertions, 12 deletions

diff --git a/src/plugins/bearer/connman/qconnmanengine.cpp b/src/plugins/bearer/connman/qconnmanengine.cpp
index 0e54668394..453ebc7c45 100644
--- a/src/plugins/bearer/connman/qconnmanengine.cpp
+++ b/src/plugins/bearer/connman/qconnmanengine.cpp
@@ -82,7 +82,7 @@ void QConnmanEngine::initialize()
     connect(connmanManager,SIGNAL(propertyChangedContext(QString,QString,QDBusVariant)),
             this,SLOT(propertyChangedContext(QString,QString,QDBusVariant)));
 
-    foreach(const QString techPath, connmanManager->getTechnologies()) {
+    foreach (const QString &techPath, connmanManager->getTechnologies()) {
         QConnmanTechnologyInterface *tech;
         tech = new QConnmanTechnologyInterface(techPath, this);
 
@@ -90,7 +90,7 @@ void QConnmanEngine::initialize()
                 this,SLOT(technologyPropertyChangedContext(QString,QString,QDBusVariant)));
     }
 
-    foreach(const QString servPath, connmanManager->getServices()) {
+    foreach (const QString &servPath, connmanManager->getServices()) {
         addServiceConfiguration(servPath);
     }
 
@@ -157,7 +157,7 @@ void QConnmanEngine::connectToId(const QString &id)
             QOfonoManagerInterface ofonoManager(0);
             QString modemPath = ofonoManager.currentModem().path();
             QOfonoDataConnectionManagerInterface dc(modemPath,0);
-            foreach(const QDBusObjectPath dcPath,dc.getPrimaryContexts()) {
+            foreach (const QDBusObjectPath &dcPath,dc.getPrimaryContexts()) {
                 if(dcPath.path().contains(servicePath.section("_",-1))) {
                     QOfonoPrimaryDataContextInterface primaryContext(dcPath.path(),0);
                     primaryContext.setActive(true);
@@ -181,7 +181,7 @@ void QConnmanEngine::disconnectFromId(const QString &id)
             QOfonoManagerInterface ofonoManager(0);
             QString modemPath = ofonoManager.currentModem().path();
             QOfonoDataConnectionManagerInterface dc(modemPath,0);
-            foreach(const QDBusObjectPath dcPath,dc.getPrimaryContexts()) {
+            foreach (const QDBusObjectPath &dcPath,dc.getPrimaryContexts()) {
                 if(dcPath.path().contains(servicePath.section("_",-1))) {
                     QOfonoPrimaryDataContextInterface primaryContext(dcPath.path(),0);
                     primaryContext.setActive(false);
@@ -200,7 +200,7 @@ void QConnmanEngine::requestUpdate()
 QString QConnmanEngine::serviceFromId(const QString &id)
 {
     QMutexLocker locker(&mutex);
-    foreach(const QString service, serviceNetworks) {
+    foreach (const QString &service, serviceNetworks) {
         if (id == QString::number(qHash(service)))
             return service;
     }
@@ -315,7 +315,7 @@ void QConnmanEngine::propertyChangedContext(const QString &path,const QString &i
         QStringList list = qdbus_cast<QStringList>(arg);
 
         if(list.count() > accessPointConfigurations.count()) {
-            foreach(const QString service, list) {
+            foreach (const QString &service, list) {
                 addServiceConfiguration(service);
             }
         }
@@ -327,7 +327,7 @@ void QConnmanEngine::propertyChangedContext(const QString &path,const QString &i
         if(newlist.count() > 0) {
             QMap<QString,QConnmanTechnologyInterface *> oldtech = technologies;
 
-            foreach(const QString listPath, newlist) {
+            foreach (const QString &listPath, newlist) {
                 if(!oldtech.contains(listPath)) {
                     QConnmanTechnologyInterface *tech;
                     tech = new QConnmanTechnologyInterface(listPath,this);
@@ -461,10 +461,10 @@ QNetworkConfiguration::BearerType QConnmanEngine::ofonoTechToBearerType(const QS
     QOfonoNetworkRegistrationInterface ofonoNetwork(ofonoManager.currentModem().path(),this);
 
     if(ofonoNetwork.isValid()) {
-        foreach(const QDBusObjectPath op,ofonoNetwork.getOperators() ) {
+        foreach (const QDBusObjectPath &op,ofonoNetwork.getOperators() ) {
             QOfonoNetworkOperatorInterface opIface(op.path(),this);
 
-            foreach(const QString opTech, opIface.getTechnologies()) {
+            foreach (const QString &opTech, opIface.getTechnologies()) {
 
                 if(opTech == "gsm") {
                     return QNetworkConfiguration::Bearer2G;
@@ -492,7 +492,7 @@ bool QConnmanEngine::isRoamingAllowed(const QString &context)
     QOfonoManagerInterface ofonoManager(this);
     QString modemPath = ofonoManager.currentModem().path();
     QOfonoDataConnectionManagerInterface dc(modemPath,this);
-    foreach(const QDBusObjectPath dcPath,dc.getPrimaryContexts()) {
+    foreach (const QDBusObjectPath &dcPath,dc.getPrimaryContexts()) {
         if(dcPath.path().contains(context.section("_",-1))) {
             return dc.isRoamingAllowed();
         }
diff --git a/src/plugins/bearer/connman/qconnmanservice_linux.cpp b/src/plugins/bearer/connman/qconnmanservice_linux.cpp
index 83f9ff1903..cd10f181f9 100644
--- a/src/plugins/bearer/connman/qconnmanservice_linux.cpp
+++ b/src/plugins/bearer/connman/qconnmanservice_linux.cpp
@@ -313,7 +313,7 @@ QStringList QConnmanManagerInterface::getServices()
 
 QString QConnmanManagerInterface::getPathForTechnology(const QString &name)
 {
-    foreach(const QString path, getTechnologies()) {
+    foreach (const QString &path, getTechnologies()) {
         if(path.contains(name)) {
             return path;
         }
diff --git a/src/plugins/bearer/connman/qofonoservice_linux.cpp b/src/plugins/bearer/connman/qofonoservice_linux.cpp
index 6e01029d13..54074a8393 100644
--- a/src/plugins/bearer/connman/qofonoservice_linux.cpp
+++ b/src/plugins/bearer/connman/qofonoservice_linux.cpp
@@ -79,7 +79,7 @@ QList <QDBusObjectPath> QOfonoManagerInterface::getModems()
 QDBusObjectPath QOfonoManagerInterface::currentModem()
 {
     QList<QDBusObjectPath> modems = getModems();
-    foreach(const QDBusObjectPath modem, modems) {
+    foreach (const QDBusObjectPath &modem, modems) {
         QOfonoModemInterface device(modem.path());
         if(device.isPowered() && device.isOnline())
         return modem;;