path: root/src/plugins/platforminputcontexts/maliit
diff options
authorShane Kearns <>2012-02-16 17:02:11 +0000
committerQt by Nokia <>2012-02-17 15:04:22 +0100
commitaee4cbf22a5942c7bd4b9545a8fcb7cf2930e0ee (patch)
treef7324110ec769d5dfe31b718c61b69472ff5146b /src/plugins/platforminputcontexts/maliit
parentd5a65cb526366754f52d21e1b4c4f55c54012945 (diff)
Remove unnecessary locking from QNetworkProxy constructor
QGlobalNetworkProxy (a singleton) had two phase construction, with the second phase being called from QNetworkProxy's constructor. This isn't necessary, and has been reported as causing deadlocks. Although constructing socket engine handlers has side effects (they add themselves to a list on construction and remove themselves on destruction), this appears to be safe. The socket engine handlers are only used while holding the list mutex, and any socket engines created don't have any reference to the factory that created them. With the new version, it is possible that two instances of QHttpSocketEngineHandler and QSocks5SocketEngineHandler exist temporarily if a Q_GLOBAL_STATIC initialisation race occurs. This appears safe, because the loser of the race deletes its handlers, which remove themselves from the global list as above. Task-number: QTBUG-13088 Change-Id: I8cf520da717d8ab7d862ab89c6de13aea6d60ac3 Reviewed-by: Richard J. Moore <> Reviewed-by: Thiago Macieira <>
Diffstat (limited to 'src/plugins/platforminputcontexts/maliit')
0 files changed, 0 insertions, 0 deletions