Don't check if a file exists before opening it

If the file doesn't exist, open() will fail. But open() might fail
even if the file exists(), which would lead to bad follow-up code. In
any case, this saves one unnecessary stat(2).

Change-Id: Ic99507c9dc07a4387ee6a4fe9c24830fca54e095
Reviewed-by: Robin Burchell <robin+qt@viroteck.net>

1 files changed, 2 insertions, 4 deletions

diff --git a/src/plugins/platforminputcontexts/compose/generator/qtablegenerator.cpp b/src/plugins/platforminputcontexts/compose/generator/qtablegenerator.cpp
index dad34e121b..11545b16c3 100644
--- a/src/plugins/platforminputcontexts/compose/generator/qtablegenerator.cpp
+++ b/src/plugins/platforminputcontexts/compose/generator/qtablegenerator.cpp
@@ -227,8 +227,7 @@ QByteArray TableGenerator::readLocaleAliases(const QByteArray &locale)
 {
     QFile aliases(systemComposeDir() + QLatin1String("/locale.alias"));
     QByteArray fullLocaleName;
-    if (aliases.exists()) {
-        aliases.open(QIODevice::ReadOnly);
+    if (aliases.open(QIODevice::ReadOnly)) {
         while (!aliases.atEnd()) {
             char l[1024];
             int read = aliases.readLine(l, sizeof(l));
@@ -267,8 +266,7 @@ QByteArray TableGenerator::readLocaleAliases(const QByteArray &locale)
 bool TableGenerator::processFile(QString composeFileName)
 {
     QFile composeFile(composeFileName);
-    if (composeFile.exists()) {
-        composeFile.open(QIODevice::ReadOnly);
+    if (composeFile.open(QIODevice::ReadOnly)) {
         parseComposeFile(&composeFile);
         return true;
     }