diff options
author | Albert Astals Cid <albert.astals@canonical.com> | 2017-03-02 10:37:19 +0100 |
---|---|---|
committer | Albert Astals Cid <aacid@kde.org> | 2017-04-18 14:31:52 +0000 |
commit | 6462f299ed188b3c3494d99d21e6563e37bd78e5 (patch) | |
tree | 373b4bfcb57698474217404a2395d183e8eb031b /src/plugins/platforms/android/qandroidplatformmenuitem.h | |
parent | df252fc2051a6d2939c77244e74aca4a115d7cce (diff) |
Make platform menu tag/setTag not be pure virtual
Reasons:
* Tag means nothing to the platform, tag is something
the Qt side code will store and then restore, but it's meaningless
for the platform, since it can be either the pointer to an
action (qmenu.cpp) or an item count (qcombobox.cpp)
* Since it's meaningless to the platform you don't know what
to do when trying to implement a platform, this shows in how
the field was being initialized, some initialized to this,
some initialized to 0
On a followup commit we will remove the virtual tag but first
need to fix up other QPAs that don't live in the main repo
Change-Id: I15ac83f3bf7e4c741153d31ac761dbbe6f4b1b52
Reviewed-by: Gabriel de Dietrich <gabriel.dedietrich@qt.io>
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
Diffstat (limited to 'src/plugins/platforms/android/qandroidplatformmenuitem.h')
-rw-r--r-- | src/plugins/platforms/android/qandroidplatformmenuitem.h | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/src/plugins/platforms/android/qandroidplatformmenuitem.h b/src/plugins/platforms/android/qandroidplatformmenuitem.h index be5240cfa6..b8782f995d 100644 --- a/src/plugins/platforms/android/qandroidplatformmenuitem.h +++ b/src/plugins/platforms/android/qandroidplatformmenuitem.h @@ -49,8 +49,6 @@ class QAndroidPlatformMenuItem: public QPlatformMenuItem { public: QAndroidPlatformMenuItem(); - void setTag(quintptr tag) override; - quintptr tag() const override; void setText(const QString &text) override; QString text() const; @@ -86,7 +84,6 @@ public: void setIconSize(int size) override; private: - quintptr m_tag; QString m_text; QIcon m_icon; QAndroidPlatformMenu *m_menu; |