diff options
| author | Gabriel de Dietrich <gabriel.dedietrich@qt.io> | 2016-08-16 14:03:53 -0700 |
|---|---|---|
| committer | Jake Petroules <jake.petroules@qt.io> | 2016-08-18 02:23:05 +0000 |
| commit | b13ff07f1dd25414e507aebd2a7d6d55bc93e6cd (patch) | |
| tree | 024d7f2c4f7fcb141ee6b2289749742d141da648 /src/plugins/platforms/cocoa | |
| parent | ecb73a7bb3c048fd50ebdf4b552e5b65b9ef2c50 (diff) | |
QCocoaInputContext: Fix wrong memory release
As per Core Foundation ownership conventions, we
should release 'source', which is a copy, and not
'langRef', which is a reference. This has shown
to lead to crashes in some occasions.
Change-Id: I2e59b8d62aac13bc60dc013c1ea621850132c719
Task-number: QTBUG-48772
Reviewed-by: Jake Petroules <jake.petroules@qt.io>
Diffstat (limited to 'src/plugins/platforms/cocoa')
| -rw-r--r-- | src/plugins/platforms/cocoa/qcocoainputcontext.mm | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/plugins/platforms/cocoa/qcocoainputcontext.mm b/src/plugins/platforms/cocoa/qcocoainputcontext.mm index 7d01826ffe..93b1153cf9 100644 --- a/src/plugins/platforms/cocoa/qcocoainputcontext.mm +++ b/src/plugins/platforms/cocoa/qcocoainputcontext.mm @@ -131,8 +131,8 @@ void QCocoaInputContext::updateLocale() m_locale = locale; emitLocaleChanged(); } - CFRelease(langRef); } + CFRelease(source); } QT_END_NAMESPACE |