path: root/src/plugins/platforms/offscreen
diff options
authorTor Arne Vestbø <>2013-09-16 12:52:46 +0200
committerThe Qt Project <>2013-09-16 15:22:40 +0200
commit4bae7158d379acb15a4eae02a4fc3d3e6103a7f9 (patch)
tree5329c28c59f104015d1b4b465a1634c59267cd3f /src/plugins/platforms/offscreen
parent4c19055cb1b077cf161d9cd5c031d711f42a3f25 (diff)
Don't send posted events from QWindowSystemInterface::sendWindowSystemEvents
The responsibility of sendWindowSystemEvents() is to process events from the window system. Historially that logic was part of the QPA/QWS event dispatcher, which naturally also sent posted events. Through refactoring, the code at some point ended up in in the QWindowSystemInterface class, still with the posting of events in place. This resulted in QPA event dispatchers adopting a pattern of just calling sendWindowSystemEvents(), as that would cover both posted and window system events. Other event dispatchers would call sendWindowSystemEvents(), and then use a base-class implementation from QtCore for processing events, resulting in two calls to QCoreApplication::sendPostedEvents() per iteration of processEvents(). This breaks the contract that processEvents will only process posted events that has been queued up until then. We fix this entanglement by removing the sendPostedEvents() call from QWindowSystemInterface::sendWindowSystemEvents() and move it to the respective event dispatchers. For some EDs it means an explicit call to sendPostedEvents, while others were already doing sendPostedEvents though a separate source (GLib), or using a base-class (UNIX/BB), and did not need an extra call. We still keep the ordering of the original sendWindowSystemEvents() function of first sending posted events, and then processing any window system events. Task-number: QTBUG-33485 Change-Id: I8b069e76cea1f37875e72a034c11d09bf3fe166a Reviewed-by: Paul Olav Tvete <>
Diffstat (limited to 'src/plugins/platforms/offscreen')
1 files changed, 2 insertions, 2 deletions
diff --git a/src/plugins/platforms/offscreen/qoffscreenintegration.cpp b/src/plugins/platforms/offscreen/qoffscreenintegration.cpp
index 5b74ad3b8d..bce52963df 100644
--- a/src/plugins/platforms/offscreen/qoffscreenintegration.cpp
+++ b/src/plugins/platforms/offscreen/qoffscreenintegration.cpp
@@ -73,9 +73,9 @@ public:
bool processEvents(QEventLoop::ProcessEventsFlags flags)
- bool didSendEvents = QWindowSystemInterface::sendWindowSystemEvents(flags);
+ bool didSendEvents = BaseEventDispatcher::processEvents(flags);
- return BaseEventDispatcher::processEvents(flags) || didSendEvents;
+ return QWindowSystemInterface::sendWindowSystemEvents(flags) || didSendEvents;
bool hasPendingEvents()