summaryrefslogtreecommitdiffstats
path: root/src/plugins/platforms/windows/qwindowsmousehandler.cpp
diff options
context:
space:
mode:
authorFriedemann Kleint <Friedemann.Kleint@qt.io>2020-07-01 14:37:29 +0200
committerFriedemann Kleint <Friedemann.Kleint@qt.io>2020-07-03 07:39:14 +0200
commit3fb31819fd4a209873ef671494cba8bd95dae73a (patch)
treea61b064804d5b2d7010b83cb17f31983885e8a38 /src/plugins/platforms/windows/qwindowsmousehandler.cpp
parent39d99c714bb87bd39e92d85fb1f46c52eb9f8d33 (diff)
Windows QPA: Refactor touch device creation
There was duplicated code in QWindowsMouseHandler::ensureTouchDevice() and QWindowsPointerHandler::ensureTouchDevice() which caused deprecation warnings since the setters of QInputDevice were deprecated. Join the 2 functions into a single creation function and add simple getters and setters. Fix deprecation warnings: qwindowscontext.cpp:357:108: warning: 'void QPointingDevice::setCapabilities(QInputDevice::Capabilities)' is deprecated: Use the constructor qwindowsmousehandler.cpp:132:97: warning: 'void QPointingDevice::setType(QInputDevice::DeviceType)' is deprecated: Use the constructor qwindowsmousehandler.cpp:136:41: warning: 'void QPointingDevice::setCapabilities(QInputDevice::Capabilities)' is deprecated: Use the constructor qwindowsmousehandler.cpp:137:49: warning: 'void QPointingDevice::setMaximumTouchPoints(int)' is deprecated: Use the constructor Change-Id: Iab5385e84d600e45b60f38225175f25ef043c3eb Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: André de la Rocha <andre.rocha@qt.io> Reviewed-by: Oliver Wolff <oliver.wolff@qt.io>
Diffstat (limited to 'src/plugins/platforms/windows/qwindowsmousehandler.cpp')
-rw-r--r--src/plugins/platforms/windows/qwindowsmousehandler.cpp28
1 files changed, 0 insertions, 28 deletions
diff --git a/src/plugins/platforms/windows/qwindowsmousehandler.cpp b/src/plugins/platforms/windows/qwindowsmousehandler.cpp
index 4fd6e4131e..4efeaa9d34 100644
--- a/src/plugins/platforms/windows/qwindowsmousehandler.cpp
+++ b/src/plugins/platforms/windows/qwindowsmousehandler.cpp
@@ -117,27 +117,6 @@ static inline void compressMouseMove(MSG *msg)
}
}
-static inline QPointingDevice *createTouchDevice()
-{
- const int digitizers = GetSystemMetrics(SM_DIGITIZER);
- if (!(digitizers & (NID_INTEGRATED_TOUCH | NID_EXTERNAL_TOUCH)))
- return nullptr;
- const int tabletPc = GetSystemMetrics(SM_TABLETPC);
- const int maxTouchPoints = GetSystemMetrics(SM_MAXIMUMTOUCHES);
- qCDebug(lcQpaEvents) << "Digitizers:" << Qt::hex << Qt::showbase << (digitizers & ~NID_READY)
- << "Ready:" << (digitizers & NID_READY) << Qt::dec << Qt::noshowbase
- << "Tablet PC:" << tabletPc << "Max touch points:" << maxTouchPoints;
- auto *result = new QPointingDevice;
- result->setType(digitizers & NID_INTEGRATED_TOUCH
- ? QInputDevice::DeviceType::TouchScreen : QInputDevice::DeviceType::TouchPad);
- QPointingDevice::Capabilities capabilities = QPointingDevice::Capability::Position | QPointingDevice::Capability::Area | QPointingDevice::Capability::NormalizedPosition;
- if (result->type() == QInputDevice::DeviceType::TouchPad)
- capabilities.setFlag(QInputDevice::Capability::MouseEmulation);
- result->setCapabilities(capabilities);
- result->setMaximumTouchPoints(maxTouchPoints);
- return result;
-}
-
/*!
\class QWindowsMouseHandler
\brief Windows mouse handler
@@ -149,13 +128,6 @@ static inline QPointingDevice *createTouchDevice()
QWindowsMouseHandler::QWindowsMouseHandler() = default;
-QPointingDevice *QWindowsMouseHandler::ensureTouchDevice()
-{
- if (!m_touchDevice)
- m_touchDevice = createTouchDevice();
- return m_touchDevice;
-}
-
void QWindowsMouseHandler::clearEvents()
{
m_lastEventType = QEvent::None;