path: root/src/plugins/platforms/xcb/qxcbconnection.cpp
diff options
authorGatis Paeglis <>2018-05-05 20:50:16 +0200
committerGatis Paeglis <>2018-06-22 06:09:27 +0000
commit6a28a2cc34d938417affc96d2495a7e3d2e2b869 (patch)
tree62d9cd5f914e17b8252875d69658a8780f95f10c /src/plugins/platforms/xcb/qxcbconnection.cpp
parent7bc667e5e0d3375fa6b6685121799c8e6d4a37ba (diff)
xcb: qxcbdrag.cpp cleanups
- moved finding of XdndAware target logic in its own function to reduce size of QXcbDrag::move(). - switched to use categorized logging with more consistent logging messages - added more comments to avoid constatly looking at the specification for the meanings of Xdnd* actions and who sends/receives the action. - removed dead code (findXdndAwareParent), which should have been removed in 269fdbdd2bedda5f5eacb751224d3a3fc3eed5bc when reimplementing this logic in XCB. - removed needless reseting of state variables in various places as this is handled in QXcbDrag::init() on DnD start. - renamed variable in QXcbDrag::dndEnable(): xdnd_widget -> window - and other minor cleanups Change-Id: Ib667f80ceb4c07b7409a90c041044c98665877f3 Reviewed-by: Shawn Rutledge <>
Diffstat (limited to 'src/plugins/platforms/xcb/qxcbconnection.cpp')
1 files changed, 1 insertions, 0 deletions
diff --git a/src/plugins/platforms/xcb/qxcbconnection.cpp b/src/plugins/platforms/xcb/qxcbconnection.cpp
index 1342a82e6e..32e4b9dbba 100644
--- a/src/plugins/platforms/xcb/qxcbconnection.cpp
+++ b/src/plugins/platforms/xcb/qxcbconnection.cpp
@@ -116,6 +116,7 @@ Q_LOGGING_CATEGORY(lcQpaEvents, "")
Q_LOGGING_CATEGORY(lcQpaXcb, "qt.qpa.xcb") // for general (uncategorized) XCB logging
Q_LOGGING_CATEGORY(lcQpaPeeker, "qt.qpa.peeker")
Q_LOGGING_CATEGORY(lcQpaKeyboard, "qt.qpa.xkeyboard")
+Q_LOGGING_CATEGORY(lcQpaXDnd, "qt.qpa.xdnd")
// this event type was added in libxcb 1.10,
// but we support also older version