Plugins: optimize string usage

Prefer QStringRef methods to avoid allocations.

Use startsWith/endsWith rather than comparing substrings;
and avoid substrings where references suffice.

Use new QStringList::join(QL1S).

Change-Id: I46c44aca96578633370006d613eb0ac13f7cfc03
Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>

1 files changed, 3 insertions, 3 deletions

diff --git a/src/plugins/platforms/xcb/qxcbmime.cpp b/src/plugins/platforms/xcb/qxcbmime.cpp
index f71c5464d0..3e9b0e1e4a 100644
--- a/src/plugins/platforms/xcb/qxcbmime.cpp
+++ b/src/plugins/platforms/xcb/qxcbmime.cpp
@@ -208,10 +208,10 @@ QVariant QXcbMime::mimeConvertToFormat(QXcbConnection *connection, xcb_atom_t a,
                   reinterpret_cast<const ushort *>(data.constData()), data.size() / 2);
             if (!str.isNull()) {
                 if (format == QLatin1String("text/uri-list")) {
-                    const QStringList urls = str.split(QLatin1Char('\n'));
+                    const auto urls = str.splitRef(QLatin1Char('\n'));
                     QList<QVariant> list;
-                    for (const QString &s : urls) {
-                        const QUrl url(s.trimmed());
+                    for (const QStringRef &s : urls) {
+                        const QUrl url(s.trimmed().toString());
                         if (url.isValid())
                             list.append(url);
                     }