Port from container.count()/length() to size()

This is semantic patch using ClangTidyTransformator:

  auto QtContainerClass = expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)
  makeRule(cxxMemberCallExpr(on(QtContainerClass),
                             callee(cxxMethodDecl(hasAnyName({"count", "length"),
                                                  parameterCountIs(0))))),
           changeTo(cat(access(o, cat("size"), "()"))),
           cat("use 'size()' instead of 'count()/length()'"))

a.k.a qt-port-to-std-compatible-api with config Scope: 'Container'.

<classes> are:

    // sequential:
    "QByteArray",
    "QList",
    "QQueue",
    "QStack",
    "QString",
    "QVarLengthArray",
    "QVector",
    // associative:
    "QHash",
    "QMultiHash",
    "QMap",
    "QMultiMap",
    "QSet",
    // Qt has no QMultiSet

Change-Id: Ibe8837be96e8d30d1846881ecd65180c1bc459af
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>

1 files changed, 3 insertions, 3 deletions

diff --git a/src/plugins/platformthemes/gtk3/qgtk3menu.cpp b/src/plugins/platformthemes/gtk3/qgtk3menu.cpp
index 5589ff8836..c4ea0e5e33 100644
--- a/src/plugins/platformthemes/gtk3/qgtk3menu.cpp
+++ b/src/plugins/platformthemes/gtk3/qgtk3menu.cpp
@@ -123,13 +123,13 @@ static QString convertMnemonics(QString text, bool *found)
 {
     *found = false;
 
-    qsizetype i = text.length() - 1;
+    qsizetype i = text.size() - 1;
     while (i >= 0) {
         const QChar c = text.at(i);
         if (c == u'&') {
             if (i == 0 || text.at(i - 1) != u'&') {
                 // convert Qt to GTK mnemonic
-                if (i < text.length() - 1 && !text.at(i + 1).isSpace()) {
+                if (i < text.size() - 1 && !text.at(i + 1).isSpace()) {
                     text.replace(i, 1, u'_');
                     *found = true;
                 }
@@ -329,7 +329,7 @@ void QGtk3Menu::insertMenuItem(QPlatformMenuItem *item, QPlatformMenuItem *befor
     GtkWidget *handle = gitem->create();
     int index = m_items.indexOf(static_cast<QGtk3MenuItem *>(before));
     if (index < 0)
-        index = m_items.count();
+        index = m_items.size();
     m_items.insert(index, gitem);
     gtk_menu_shell_insert(GTK_MENU_SHELL(m_menu), handle, index);
 }