diff options
author | Gabriel de Dietrich <gabriel.dedietrich@qt.io> | 2018-07-24 13:23:35 -0700 |
---|---|---|
committer | Gabriel de Dietrich <gabriel.dedietrich@qt.io> | 2018-08-01 17:00:35 +0000 |
commit | 4126de887799c61793bf1f9efc8b7ac7b66c8b32 (patch) | |
tree | b7c9dde564aa95475bb95170be09bc309b8d0cc9 /src/plugins/sqldrivers/README | |
parent | 843629dd1f4e0521ab9bcc6b3c806a5d90b13613 (diff) |
QCocoaMenuLoader - ensure that ensureAppMenuInMenu indeed, ensures
The logic seems to be incorrect (or the naming is misleading): it
only adds 'appMenu' if it was found in the previous 'mainMenu',
failing otherwise. Consider the following example:
while (true){
QApplication app(a,b);
MainWindow w;
w.show();
app.exec();
}
It's quite a contrived but apparently allowed API use (OP claims
they have to switch languages in their app). The main window and the
app are destroyed, so is the menu bar. Then a new main window is
created, with a new menu bar. Now the current [NSApp mainMenu]
(the one set after we deleted the previous) does not have 'appMenu'
anymore (we removed it when initializing the first menu bar).
So as a result we have app menu missing and add new menus/items
to a wrong menus/at wrong index.
Change-Id: I64fce766d6c12ebf7ae12bb94af41c8c1de3d78b
Task-number: QTBUG-69496
Reviewed-by: Timur Pocheptsov <timur.pocheptsov@qt.io>
Diffstat (limited to 'src/plugins/sqldrivers/README')
0 files changed, 0 insertions, 0 deletions