summaryrefslogtreecommitdiffstats
path: root/src/plugins
diff options
context:
space:
mode:
authorJ-P Nurmi <jpnurmi@qt.io>2016-06-20 10:35:56 +0200
committerJ-P Nurmi <jpnurmi@qt.io>2016-06-20 13:57:36 +0000
commit3aaa5d6b32130d3eeac872a59a5a44bfb20dfd4a (patch)
treeb128207d307043a6b0cf99416686ae0e24c694fe /src/plugins
parentcf53aa21bf0f8fbd13c0ce2d33ddf7bc63d0d76a (diff)
Improve QGtk3FontDialogHelper::onAccepted()
Call currentFont() only once. It does a conversion from a Pango font description string to a Qt font, so not entirely trivial operation. Change-Id: Ic67b7c5b0874621c51a5cce4766acd4243d3dfde Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
Diffstat (limited to 'src/plugins')
-rw-r--r--src/plugins/platformthemes/gtk3/qgtk3dialoghelpers.cpp5
1 files changed, 3 insertions, 2 deletions
diff --git a/src/plugins/platformthemes/gtk3/qgtk3dialoghelpers.cpp b/src/plugins/platformthemes/gtk3/qgtk3dialoghelpers.cpp
index 488ae16123..fa92e49673 100644
--- a/src/plugins/platformthemes/gtk3/qgtk3dialoghelpers.cpp
+++ b/src/plugins/platformthemes/gtk3/qgtk3dialoghelpers.cpp
@@ -588,9 +588,10 @@ QFont QGtk3FontDialogHelper::currentFont() const
void QGtk3FontDialogHelper::onAccepted()
{
- emit currentFontChanged(currentFont());
+ const QFont font = currentFont();
+ emit currentFontChanged(font);
emit accept();
- emit fontSelected(currentFont());
+ emit fontSelected(font);
}
void QGtk3FontDialogHelper::applyOptions()