diff options
| author | Anton Kudryavtsev <a.kudryavtsev@netris.ru> | 2016-08-18 11:57:26 +0300 |
|---|---|---|
| committer | Anton Kudryavtsev <a.kudryavtsev@netris.ru> | 2016-09-15 15:55:57 +0000 |
| commit | 6aa935cd92deb035739e8fea329ca2c4a435de54 (patch) | |
| tree | a9a3ea43af619a7a89ce39f15ea603747767a9f2 /src/printsupport/dialogs/qprintpreviewdialog.cpp | |
| parent | 251d6094abf423f96aa0f10921defb4c6a805d14 (diff) | |
Use QString::fromLatin1() less to avoid string allocations
QString::fromLatin1 always allocates memory, but there are
cases where we can avoid/reduce allocations or/and reduce
text size, e.g.:
QStringBuilder expressions
Fix: replace QString::fromLatin1 with QL1S
QString::fromLatin1().arg(String) pattern
Fix: replace with QStringBuilder
Overloaded functions with QL1S arg
Fix: replace QString::fromLatin1 with QL1S
In rare cases if there is no overloaded function
with QL1S and we have deal with string literal,
replace QString::fromLatin1 with QStringLiteral.
Change-Id: Iabe1a3cc0830f40ef78a0548afa4368583c31def
Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
Diffstat (limited to 'src/printsupport/dialogs/qprintpreviewdialog.cpp')
| -rw-r--r-- | src/printsupport/dialogs/qprintpreviewdialog.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/printsupport/dialogs/qprintpreviewdialog.cpp b/src/printsupport/dialogs/qprintpreviewdialog.cpp index 435f8869c4..c996e0d556 100644 --- a/src/printsupport/dialogs/qprintpreviewdialog.cpp +++ b/src/printsupport/dialogs/qprintpreviewdialog.cpp @@ -334,7 +334,7 @@ void QPrintPreviewDialogPrivate::init(QPrinter *_printer) QString caption = QCoreApplication::translate("QPrintPreviewDialog", "Print Preview"); if (!printer->docName().isEmpty()) - caption += QString::fromLatin1(": ") + printer->docName(); + caption += QLatin1String(": ") + printer->docName(); q->setWindowTitle(caption); if (!printer->isValid() |