QSqlDriver: use Q_DECLARE_PUBLIC/Q_DECLARE_PRIVATE

406c8ef6e67da introduced deriving the private SQL driver classes from
QSqlDriverPrivate. However, the drivers continued to keep their own
pointer to the private class, even though QObject provides the same
pointer. Worse yet, the private class is allocated too late and not
even passed to QSqlDriver. The result is that QSqlDriver allocates
a separate instance of QSqlDriverPrivate. This is likely to cause
all kinds of chaos.

The private class needs to be allocated in time pass it to QSqlDriver
which passes it on to QObject.

This commit covers the the base class and drivers:
    ibase
    mysql
    odbc
    psql
    sqlite
    tds

Fixes for the remaining drivers will follow.

Change-Id: Id8e7ec4205b0ca6cd00bd022c9cd24f137089245
Reviewed-by: Andy Shaw <andy.shaw@digia.com>

1 files changed, 2 insertions, 5 deletions

diff --git a/src/sql/drivers/ibase/qsql_ibase_p.h b/src/sql/drivers/ibase/qsql_ibase_p.h
index b2560ca17c..ab9edfd1a5 100644
--- a/src/sql/drivers/ibase/qsql_ibase_p.h
+++ b/src/sql/drivers/ibase/qsql_ibase_p.h
@@ -64,9 +64,9 @@ class QIBaseDriver;
 
 class QIBaseDriver : public QSqlDriver
 {
-    Q_OBJECT
-    friend class QIBaseDriverPrivate;
     friend class QIBaseResultPrivate;
+    Q_DECLARE_PRIVATE(QIBaseDriver)
+    Q_OBJECT
 public:
     explicit QIBaseDriver(QObject *parent = 0);
     explicit QIBaseDriver(isc_db_handle connection, QObject *parent = 0);
@@ -104,9 +104,6 @@ public:
 
 private Q_SLOTS:
     void qHandleEventNotification(void* updatedResultBuffer);
-
-private:
-    QIBaseDriverPrivate* d;
 };
 
 QT_END_NAMESPACE