diff options
| author | Kent Hansen <kent.hansen@nokia.com> | 2012-02-17 22:26:27 +0100 |
|---|---|---|
| committer | Qt by Nokia <qt-info@nokia.com> | 2012-02-20 11:29:03 +0100 |
| commit | 989670737fbb84b6e5c483fd3faccd8d2ab917fe (patch) | |
| tree | c7d9a2262e98104c4c1bf57ff7574a88ee91679a /src/testlib/qsignaldumper.cpp | |
| parent | 5640b0b4439941c621b4f0efec541e387abb7daf (diff) | |
Use QMetaMethod::isValid() to check method validity
The signature() method will soon be replaced by a function that
returns a QByteArray rather than a pointer, and calling it will be
more expensive than calling isValid(). Plus, isValid() looks nicer.
Change-Id: I6844988c84dcadf876fc86bc71c8b310a21f88de
Reviewed-by: Olivier Goffart <ogoffart@woboq.com>
Reviewed-by: Sergio Ahumada <sergio.ahumada@nokia.com>
Diffstat (limited to 'src/testlib/qsignaldumper.cpp')
| -rw-r--r-- | src/testlib/qsignaldumper.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/testlib/qsignaldumper.cpp b/src/testlib/qsignaldumper.cpp index d0a3af6764..4fd870b644 100644 --- a/src/testlib/qsignaldumper.cpp +++ b/src/testlib/qsignaldumper.cpp @@ -76,7 +76,7 @@ static void qSignalDumperCallback(QObject *caller, int method_index, void **argv const QMetaObject *mo = caller->metaObject(); Q_ASSERT(mo); QMetaMethod member = mo->method(method_index); - Q_ASSERT(member.signature()); + Q_ASSERT(member.isValid()); if (QTest::ignoreClasses() && QTest::ignoreClasses()->contains(mo->className())) { ++QTest::ignoreLevel; @@ -132,7 +132,7 @@ static void qSignalDumperCallbackSlot(QObject *caller, int method_index, void ** const QMetaObject *mo = caller->metaObject(); Q_ASSERT(mo); QMetaMethod member = mo->method(method_index); - if (!member.signature()) + if (!member.isValid()) return; if (QTest::ignoreLevel || |