summaryrefslogtreecommitdiffstats
path: root/src/testlib/qtestlog.cpp
diff options
context:
space:
mode:
authorEdward Welbourne <edward.welbourne@qt.io>2021-09-23 15:59:32 +0200
committerEdward Welbourne <edward.welbourne@qt.io>2021-12-09 20:54:26 +0100
commit77a93e6df331e5ed22aef4335d8de38abe2ca586 (patch)
treeace152ec3685282a07f890e4c95aac057693b5e5 /src/testlib/qtestlog.cpp
parent1c24b4b8d9fe16eaa4bc1598df117593d814bf50 (diff)
Make Skip an incident in test logging
Skip ends the test (albeit inconclusively). Rearrange the enums in the abstract logger, move code to handle skip between relevant function and tidy up various things that became simpler as a result. Also reorder the message enum, and its switches, to separate testlib's internals from the usual Qt messages, and put each group in ascending order of severity. Task-number: QTBUG-96844 Change-Id: I2c7a634b9f849830d64eafa750155e66e244b729 Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io> Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Diffstat (limited to 'src/testlib/qtestlog.cpp')
-rw-r--r--src/testlib/qtestlog.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/testlib/qtestlog.cpp b/src/testlib/qtestlog.cpp
index 7b13f01e24..c90850e786 100644
--- a/src/testlib/qtestlog.cpp
+++ b/src/testlib/qtestlog.cpp
@@ -440,7 +440,7 @@ void QTestLog::addSkip(const char *msg, const char *file, int line)
++QTest::skips;
FOREACH_TEST_LOGGER
- logger->addMessage(QAbstractTestLogger::Skip, QString::fromUtf8(msg), file, line);
+ logger->addIncident(QAbstractTestLogger::Skip, msg, file, line);
}
void QTestLog::addBenchmarkResult(const QBenchmarkResult &result)