summaryrefslogtreecommitdiffstats
path: root/src/testlib
diff options
context:
space:
mode:
authorKai Koehne <kai.koehne@qt.io>2020-05-06 15:09:37 +0200
committerKai Koehne <kai.koehne@qt.io>2020-05-20 20:29:02 +0200
commita7fa089f1a7bba90f8f772cc7b703d67d933d5c5 (patch)
tree6b118e7a89bd2a6a5fd6407f71c511fb900f6fb7 /src/testlib
parentfc891d94ee8a6fcba74b13a13ccef35d5638c00f (diff)
Snippets: Fix dependency issues
The widget snippet was sometimes ignored, because the printsupport dependency was not explicit in the top-level src.pro file. This lead to a situation that, if printsupport by chance was already built, it was tested, otherwise silently ignored. This shows that having requires(qtHaveModule()) inside src/ is actually harmful, and they are therefore removed from snippets.pro. Also, the dependencies for the snippets projects are now moved to a central place so that the correctness is easier to check. Change-Id: Ice051fa04848040e206c78361fbbcf680383c6b2 Reviewed-by: Paul Wicking <paul.wicking@qt.io> (cherry picked from commit 56c203fc09e6e7aeb6ce474e30fe4a93c8d412b4) Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
Diffstat (limited to 'src/testlib')
-rw-r--r--src/testlib/doc/snippets/snippets.pro3
1 files changed, 0 insertions, 3 deletions
diff --git a/src/testlib/doc/snippets/snippets.pro b/src/testlib/doc/snippets/snippets.pro
index d1ca7ca3ec..28b6682b72 100644
--- a/src/testlib/doc/snippets/snippets.pro
+++ b/src/testlib/doc/snippets/snippets.pro
@@ -1,6 +1,3 @@
-requires(qtHaveModule(sql))
-requires(qtHaveModule(widgets))
-
TEMPLATE = app
TARGET = testlib_cppsnippet
QT = core testlib sql widgets