diff options
author | Tor Arne Vestbø <tor.arne.vestbo@qt.io> | 2021-08-06 13:22:06 +0200 |
---|---|---|
committer | Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> | 2021-08-11 08:17:51 +0000 |
commit | 2f00505e8ebe29cf25a0934195968bac795796bb (patch) | |
tree | 1ce0d78b1efb6d38df6870faef1a3ed3a28b98e4 /src/testlib | |
parent | 15ffbeb5873a4fe033320fd0ae62a3b2304cc94f (diff) |
testlib: Don't report blacklisted tests as failures in JUnit reporter
We don't produce <failure> elements for them, so we shouldn't include
them in the total count of failures.
In the future we might produce <skipped> elements instead, but for now
remove the incorrect increment.
Change-Id: Ia89a5cdaf79f6aa2f92be53180112c40ad6da2c6
Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
(cherry picked from commit eb4fb9fa32797d48d4779464483230ad92f349a6)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
Diffstat (limited to 'src/testlib')
-rw-r--r-- | src/testlib/qjunittestlogger.cpp | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/src/testlib/qjunittestlogger.cpp b/src/testlib/qjunittestlogger.cpp index 4d8ed2ae59..1e375bb33f 100644 --- a/src/testlib/qjunittestlogger.cpp +++ b/src/testlib/qjunittestlogger.cpp @@ -240,14 +240,12 @@ void QJUnitTestLogger::addIncident(IncidentTypes type, const char *description, typeBuf = "bpass"; break; case QAbstractTestLogger::BlacklistedFail: - ++failureCounter; typeBuf = "bfail"; break; case QAbstractTestLogger::BlacklistedXPass: typeBuf = "bxpass"; break; case QAbstractTestLogger::BlacklistedXFail: - ++failureCounter; typeBuf = "bxfail"; break; default: |