diff options
author | Ahmad Samir <a.samirh78@gmail.com> | 2022-12-17 11:39:16 +0200 |
---|---|---|
committer | Ahmad Samir <a.samirh78@gmail.com> | 2023-01-07 17:23:18 +0200 |
commit | 1356ca05c299ce9cc57b98ccecac7161efe302c3 (patch) | |
tree | 0f79968053136804a119e17cee85bbdefcaffa24 /src/tools/rcc/rcc.h | |
parent | fe4cc2793f80e285be66c36bc1ec6903ddcd312e (diff) |
RCCFileInfo: refactor
- Initialize members in-class, and in ctor init-list as needed. This
simplifies the constructor and is generally safer as one can't forget
to initialize a member, especially built-in types
- Add copy control members, this is actually a move only class because
of the QMultiHash<QString, RCCFileInfo*> member and the destructor
calling qDeleteAll
- Minor, save a couple of bytes by reordering the members so that they
are in 8 byte chunks as much as possible, sizeof(*this) is now 104,
was 120
Change-Id: Idcf7c5a99fdf02854e09e3c1cade6c8d238ed492
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Diffstat (limited to 'src/tools/rcc/rcc.h')
-rw-r--r-- | src/tools/rcc/rcc.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/tools/rcc/rcc.h b/src/tools/rcc/rcc.h index 78d7600492..60af1c67cf 100644 --- a/src/tools/rcc/rcc.h +++ b/src/tools/rcc/rcc.h @@ -103,7 +103,7 @@ private: }; friend class RCCFileInfo; void reset(); - bool addFile(const QString &alias, const RCCFileInfo &file); + bool addFile(const QString &alias, RCCFileInfo file); bool interpretResourceFile(QIODevice *inputDevice, const QString &file, QString currentPath = QString(), bool listMode = false); bool writeHeader(); |