summaryrefslogtreecommitdiffstats
path: root/src/tools/uic
diff options
context:
space:
mode:
authorCristián Maureira-Fredes <cristian.maureira-fredes@qt.io>2020-02-28 10:42:47 +0100
committerCristián Maureira-Fredes <cristian.maureira-fredes@qt.io>2020-03-03 14:50:35 +0100
commit3f7d087d3394a0cd80042f50edd9abcc53febe18 (patch)
tree509962c50300e4686ebf75c24ab7ddb336096d5a /src/tools/uic
parent4a1de178c9cc891560f38d64d89074799b0fa0e1 (diff)
uic: Add pass to empty functions
When there are no translations on the UI file, the function was left empty but without a 'pass' statement, generating a SyntaxError, this change includes it to avoid problems while using the generated Python file. Fixes: PYSIDE-1234 Change-Id: I30482a95c95fb4b4f4456531946a79c960d76318 Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
Diffstat (limited to 'src/tools/uic')
-rw-r--r--src/tools/uic/cpp/cppwriteinitialization.cpp19
1 files changed, 13 insertions, 6 deletions
diff --git a/src/tools/uic/cpp/cppwriteinitialization.cpp b/src/tools/uic/cpp/cppwriteinitialization.cpp
index 1212c410ff..92fd6471a8 100644
--- a/src/tools/uic/cpp/cppwriteinitialization.cpp
+++ b/src/tools/uic/cpp/cppwriteinitialization.cpp
@@ -546,12 +546,19 @@ void WriteInitialization::acceptUI(DomUI *node)
m_output << m_option.indent << language::endFunctionDefinition("setupUi");
- if (!m_mainFormUsedInRetranslateUi && language::language() == Language::Cpp) {
- // Mark varName as unused to avoid compiler warnings.
- m_refreshInitialization += m_indent;
- m_refreshInitialization += QLatin1String("(void)");
- m_refreshInitialization += varName ;
- m_refreshInitialization += language::eol;
+ if (!m_mainFormUsedInRetranslateUi) {
+ if (language::language() == Language::Cpp) {
+ // Mark varName as unused to avoid compiler warnings.
+ m_refreshInitialization += m_indent;
+ m_refreshInitialization += QLatin1String("(void)");
+ m_refreshInitialization += varName ;
+ m_refreshInitialization += language::eol;
+ } else if (language::language() == Language::Python) {
+ // output a 'pass' to have an empty function
+ m_refreshInitialization += m_indent;
+ m_refreshInitialization += QLatin1String("pass");
+ m_refreshInitialization += language::eol;
+ }
}
m_output << m_option.indent