path: root/src/tools
diff options
authorKent Hansen <>2012-02-19 18:52:19 +0100
committerQt by Nokia <>2012-02-20 11:28:10 +0100
commit44ab16f93d4007f0bbd1591e2830bae0332aeef2 (patch)
tree4cee0a2d836761a16464fc07d324fac2724edcd1 /src/tools
parentfec37f0e9a9e4c18fd20f7b39919f08c7cb2139e (diff)
Small moc cleanup: Pass lists by const reference
generateFunctions() shouldn't (and doesn't) modify the list of functions, so the list should be passed by const reference. Change-Id: If5ff810e5623e734816c3089eb8b3fd4f54f2345 Reviewed-by: Bradley T. Hughes <> Reviewed-by: Olivier Goffart <>
Diffstat (limited to 'src/tools')
2 files changed, 4 insertions, 4 deletions
diff --git a/src/tools/moc/generator.cpp b/src/tools/moc/generator.cpp
index 937a62e87c..3362a1abc1 100644
--- a/src/tools/moc/generator.cpp
+++ b/src/tools/moc/generator.cpp
@@ -443,7 +443,7 @@ void Generator::generateClassInfos()
-void Generator::generateFunctions(QList<FunctionDef>& list, const char *functype, int type)
+void Generator::generateFunctions(const QList<FunctionDef>& list, const char *functype, int type)
if (list.isEmpty())
@@ -492,7 +492,7 @@ void Generator::generateFunctions(QList<FunctionDef>& list, const char *functype
-void Generator::generateFunctionRevisions(QList<FunctionDef>& list, const char *functype)
+void Generator::generateFunctionRevisions(const QList<FunctionDef>& list, const char *functype)
if (list.count())
fprintf(out, "\n // %ss: revision\n", functype);
diff --git a/src/tools/moc/generator.h b/src/tools/moc/generator.h
index 4e96511695..46eee4ca06 100644
--- a/src/tools/moc/generator.h
+++ b/src/tools/moc/generator.h
@@ -56,8 +56,8 @@ public:
void generateCode();
void generateClassInfos();
- void generateFunctions(QList<FunctionDef> &list, const char *functype, int type);
- void generateFunctionRevisions(QList<FunctionDef>& list, const char *functype);
+ void generateFunctions(const QList<FunctionDef> &list, const char *functype, int type);
+ void generateFunctionRevisions(const QList<FunctionDef>& list, const char *functype);
void generateEnums(int index);
void generateProperties();
void generateMetacall();