diff options
| author | Christian Ehrlicher <ch.ehrlicher@gmx.de> | 2018-12-23 14:24:20 +0100 |
|---|---|---|
| committer | Christian Ehrlicher <ch.ehrlicher@gmx.de> | 2019-01-06 13:40:06 +0000 |
| commit | 3456d516504c70226934826393284b1eb6d9c35d (patch) | |
| tree | bea02cc0536f754484ee85bc778a70e0b9d3f7a4 /src/widgets/dialogs/qprogressdialog.cpp | |
| parent | 0b736d91b779c9f475ccb6a21339d0aa1cada2e4 (diff) | |
QProgressDialog: remove unused QCursor member
The private member parentCursor was not populated since Qt4 times. This
lead to an unexpected behavior: When QProgressDialog::reset() was called
and value() was greater than 0, the cursor of the parent was set to a
default-constructed QCursor.
Therefore remove QProgressDialogPrivate::parentCursor.
Fixes: QTBUG-72660
Change-Id: I195688300e07ddbbb7c17a9f471513c542269c2a
Reviewed-by: Giuseppe D'Angelo <giuseppe.dangelo@kdab.com>
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
Diffstat (limited to 'src/widgets/dialogs/qprogressdialog.cpp')
| -rw-r--r-- | src/widgets/dialogs/qprogressdialog.cpp | 10 |
1 files changed, 0 insertions, 10 deletions
diff --git a/src/widgets/dialogs/qprogressdialog.cpp b/src/widgets/dialogs/qprogressdialog.cpp index 4bf78e2115..854043e48f 100644 --- a/src/widgets/dialogs/qprogressdialog.cpp +++ b/src/widgets/dialogs/qprogressdialog.cpp @@ -47,7 +47,6 @@ #include "qapplication.h" #include "qstyle.h" #include "qpushbutton.h" -#include "qcursor.h" #include "qtimer.h" #include "qelapsedtimer.h" #include <private/qdialog_p.h> @@ -94,9 +93,6 @@ public: bool cancellation_flag; bool setValue_called; QElapsedTimer starttime; -#ifndef QT_NO_CURSOR - QCursor parentCursor; -#endif int showTime; bool autoClose; bool autoReset; @@ -597,12 +593,6 @@ void QProgressDialog::setRange(int minimum, int maximum) void QProgressDialog::reset() { Q_D(QProgressDialog); -#ifndef QT_NO_CURSOR - if (value() >= 0) { - if (parentWidget()) - parentWidget()->setCursor(d->parentCursor); - } -#endif if (d->autoClose || d->forceHide) hide(); d->bar->reset(); |