diff options
author | Robin Burchell <robin+qt@viroteck.net> | 2012-09-02 12:18:14 +0200 |
---|---|---|
committer | Qt by Nokia <qt-info@nokia.com> | 2012-09-04 02:03:23 +0200 |
commit | 8486a510d5fb6c9ecd03dba0a49fd4f6d55c3bca (patch) | |
tree | 0ed79a01e9fd1f1af1a7d7a11758e1ee98f208d4 /src/widgets/graphicsview/qgraphicsitem.cpp | |
parent | ce2a8bdc13891cf1f53863bd5cd22d1a8fd6aae1 (diff) |
graphicsview: use std::sort instead of qSort
In almost all cases, std::sort is wildly faster than qSort - but especially in
the case where the input data is already sorted. in some stress tests which ran
through the index with a lot of items, this commit provides huge speedup (684ms
down to 10ms for painting 15001 empty items on the provided benchmark), for me.
Task-number: QTBUG-11022
Change-Id: I5551f8e320c33ba13d464bf22047a665c81f3b74
Reviewed-by: Peter Kümmel <syntheticpp@gmx.net>
Reviewed-by: João Abecasis <joao.abecasis@nokia.com>
Diffstat (limited to 'src/widgets/graphicsview/qgraphicsitem.cpp')
-rw-r--r-- | src/widgets/graphicsview/qgraphicsitem.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/widgets/graphicsview/qgraphicsitem.cpp b/src/widgets/graphicsview/qgraphicsitem.cpp index 27cd4e62ca..c4c9fff245 100644 --- a/src/widgets/graphicsview/qgraphicsitem.cpp +++ b/src/widgets/graphicsview/qgraphicsitem.cpp @@ -4578,7 +4578,7 @@ void QGraphicsItem::setZValue(qreal z) void QGraphicsItemPrivate::ensureSequentialSiblingIndex() { if (!sequentialOrdering) { - qSort(children.begin(), children.end(), insertionOrder); + std::sort(children.begin(), children.end(), insertionOrder); sequentialOrdering = 1; needSortChildren = 1; } |