diff options
author | Volker Hilsheimer <volker.hilsheimer@qt.io> | 2020-05-07 09:30:16 +0200 |
---|---|---|
committer | Volker Hilsheimer <volker.hilsheimer@qt.io> | 2020-05-11 11:05:15 +0200 |
commit | 90210c8d28a90295ebbf37ef45b69924ed7f42d0 (patch) | |
tree | a67feb9140d069197bbcaf53fe28d71e4be255cd /src/widgets/itemviews | |
parent | 219e7bafa278792f7bde110d24333fb60b555c12 (diff) |
Remove dead code from src/widgets
Code that's removed via QT_VERSION(6, 0, 0) check is already no
longer compiled.
Change-Id: I70865f330a6260ac2e9cf2770d599a5b6f7bb7d4
Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
Diffstat (limited to 'src/widgets/itemviews')
-rw-r--r-- | src/widgets/itemviews/qlistwidget_p.h | 2 | ||||
-rw-r--r-- | src/widgets/itemviews/qtablewidget.cpp | 18 | ||||
-rw-r--r-- | src/widgets/itemviews/qtablewidget.h | 20 | ||||
-rw-r--r-- | src/widgets/itemviews/qtablewidget_p.h | 2 | ||||
-rw-r--r-- | src/widgets/itemviews/qtreewidget.cpp | 17 | ||||
-rw-r--r-- | src/widgets/itemviews/qtreewidget.h | 22 | ||||
-rw-r--r-- | src/widgets/itemviews/qtreewidget_p.h | 2 |
7 files changed, 7 insertions, 76 deletions
diff --git a/src/widgets/itemviews/qlistwidget_p.h b/src/widgets/itemviews/qlistwidget_p.h index 65a7124322..c37bb48416 100644 --- a/src/widgets/itemviews/qlistwidget_p.h +++ b/src/widgets/itemviews/qlistwidget_p.h @@ -100,9 +100,7 @@ public: QVariant data(const QModelIndex &index, int role = Qt::DisplayRole) const override; bool setData(const QModelIndex &index, const QVariant &value, int role) override; -#if QT_VERSION >= QT_VERSION_CHECK(6, 0, 0) bool clearItemData(const QModelIndex &index) override; -#endif QMap<int, QVariant> itemData(const QModelIndex &index) const override; diff --git a/src/widgets/itemviews/qtablewidget.cpp b/src/widgets/itemviews/qtablewidget.cpp index 6b8505493f..4b2554d5c0 100644 --- a/src/widgets/itemviews/qtablewidget.cpp +++ b/src/widgets/itemviews/qtablewidget.cpp @@ -480,7 +480,6 @@ bool QTableModel::setItemData(const QModelIndex &index, const QMap<int, QVariant return true; } -#if QT_VERSION >= QT_VERSION_CHECK(6, 0, 0) bool QTableModel::clearItemData(const QModelIndex &index) { if (!checkIndex(index, CheckIndexOption::IndexIsValid)) @@ -496,7 +495,6 @@ bool QTableModel::clearItemData(const QModelIndex &index) emit dataChanged(index, index, QVector<int>{}); return true; } -#endif Qt::ItemFlags QTableModel::flags(const QModelIndex &index) const { @@ -2582,11 +2580,7 @@ QStringList QTableWidget::mimeTypes() const If the list of items is empty, \nullptr is returned rather than a serialized empty list. */ -#if QT_VERSION >= QT_VERSION_CHECK(6,0,0) QMimeData *QTableWidget::mimeData(const QList<QTableWidgetItem *> &items) const -#else -QMimeData *QTableWidget::mimeData(const QList<QTableWidgetItem*> items) const -#endif { Q_D(const QTableWidget); @@ -2665,18 +2659,6 @@ QModelIndex QTableWidget::indexFromItem(const QTableWidgetItem *item) const return d->tableModel()->index(item); } -#if QT_VERSION < QT_VERSION_CHECK(6, 0, 0) -/*! - \internal - \obsolete - \overload -*/ -QModelIndex QTableWidget::indexFromItem(QTableWidgetItem *item) const -{ - return indexFromItem(const_cast<const QTableWidgetItem *>(item)); -} -#endif - /*! Returns a pointer to the QTableWidgetItem associated with the given \a index. */ diff --git a/src/widgets/itemviews/qtablewidget.h b/src/widgets/itemviews/qtablewidget.h index 825311ea74..f53a55a8e2 100644 --- a/src/widgets/itemviews/qtablewidget.h +++ b/src/widgets/itemviews/qtablewidget.h @@ -231,6 +231,9 @@ public: QTableWidgetItem *item(int row, int column) const; void setItem(int row, int column, QTableWidgetItem *item); QTableWidgetItem *takeItem(int row, int column); + QList<QTableWidgetItem*> items(const QMimeData *data) const; + QModelIndex indexFromItem(const QTableWidgetItem *item) const; + QTableWidgetItem *itemFromIndex(const QModelIndex &index) const; QTableWidgetItem *verticalHeaderItem(int row) const; void setVerticalHeaderItem(int row, QTableWidgetItem *item); @@ -315,27 +318,10 @@ Q_SIGNALS: protected: bool event(QEvent *e) override; virtual QStringList mimeTypes() const; -#if QT_VERSION >= QT_VERSION_CHECK(6,0,0) virtual QMimeData *mimeData(const QList<QTableWidgetItem *> &items) const; -#else - virtual QMimeData *mimeData(const QList<QTableWidgetItem*> items) const; -#endif virtual bool dropMimeData(int row, int column, const QMimeData *data, Qt::DropAction action); virtual Qt::DropActions supportedDropActions() const; -#if QT_VERSION >= QT_VERSION_CHECK(6, 0, 0) -public: -#else -protected: -#endif - QList<QTableWidgetItem*> items(const QMimeData *data) const; - - QModelIndex indexFromItem(const QTableWidgetItem *item) const; -#if QT_VERSION < QT_VERSION_CHECK(6, 0, 0) - QModelIndex indexFromItem(QTableWidgetItem *item) const; // ### Qt 6: remove -#endif - QTableWidgetItem *itemFromIndex(const QModelIndex &index) const; - protected: #if QT_CONFIG(draganddrop) void dropEvent(QDropEvent *event) override; diff --git a/src/widgets/itemviews/qtablewidget_p.h b/src/widgets/itemviews/qtablewidget_p.h index d88326f129..670b58ef6a 100644 --- a/src/widgets/itemviews/qtablewidget_p.h +++ b/src/widgets/itemviews/qtablewidget_p.h @@ -129,9 +129,7 @@ public: QVariant data(const QModelIndex &index, int role = Qt::DisplayRole) const override; bool setData(const QModelIndex &index, const QVariant &value, int role) override; bool setItemData(const QModelIndex &index, const QMap<int, QVariant> &roles) override; -#if QT_VERSION >= QT_VERSION_CHECK(6, 0, 0) bool clearItemData(const QModelIndex &index) override; -#endif QMap<int, QVariant> itemData(const QModelIndex &index) const override; diff --git a/src/widgets/itemviews/qtreewidget.cpp b/src/widgets/itemviews/qtreewidget.cpp index 25b3f3a778..244f1872c2 100644 --- a/src/widgets/itemviews/qtreewidget.cpp +++ b/src/widgets/itemviews/qtreewidget.cpp @@ -392,7 +392,6 @@ bool QTreeModel::setData(const QModelIndex &index, const QVariant &value, int ro return false; } -#if QT_VERSION >= QT_VERSION_CHECK(6, 0, 0) bool QTreeModel::clearItemData(const QModelIndex &index) { if (!checkIndex(index, CheckIndexOption::IndexIsValid)) @@ -411,7 +410,6 @@ bool QTreeModel::clearItemData(const QModelIndex &index) emit dataChanged(index, index, QVector<int>{}); return true; } -#endif QMap<int, QVariant> QTreeModel::itemData(const QModelIndex &index) const { @@ -3257,11 +3255,7 @@ QStringList QTreeWidget::mimeTypes() const If the list of items is empty, \nullptr is returned rather than a serialized empty list. */ -#if QT_VERSION >= QT_VERSION_CHECK(6,0,0) QMimeData *QTreeWidget::mimeData(const QList<QTreeWidgetItem *> &items) const -#else -QMimeData *QTreeWidget::mimeData(const QList<QTreeWidgetItem*> items) const -#endif { Q_D(const QTreeWidget); if (d->treeModel()->cachedIndexes.isEmpty()) { @@ -3339,17 +3333,6 @@ QModelIndex QTreeWidget::indexFromItem(const QTreeWidgetItem *item, int column) return d->index(item, column); } -#if QT_VERSION < QT_VERSION_CHECK(6, 0, 0) -/*! - \overload - \internal -*/ -QModelIndex QTreeWidget::indexFromItem(QTreeWidgetItem *item, int column) const -{ - return indexFromItem(const_cast<const QTreeWidgetItem *>(item), column); -} -#endif - /*! Returns a pointer to the QTreeWidgetItem associated with the given \a index. diff --git a/src/widgets/itemviews/qtreewidget.h b/src/widgets/itemviews/qtreewidget.h index 03291ae2db..c53de27b56 100644 --- a/src/widgets/itemviews/qtreewidget.h +++ b/src/widgets/itemviews/qtreewidget.h @@ -303,6 +303,10 @@ public: QTreeWidgetItem *itemAbove(const QTreeWidgetItem *item) const; QTreeWidgetItem *itemBelow(const QTreeWidgetItem *item) const; + QList<QTreeWidgetItem*> items(const QMimeData *data) const; + + QModelIndex indexFromItem(const QTreeWidgetItem *item, int column = 0) const; + QTreeWidgetItem *itemFromIndex(const QModelIndex &index) const; void setSelectionModel(QItemSelectionModel *selectionModel) override; @@ -329,29 +333,11 @@ Q_SIGNALS: protected: bool event(QEvent *e) override; virtual QStringList mimeTypes() const; -#if QT_VERSION >= QT_VERSION_CHECK(6,0,0) virtual QMimeData *mimeData(const QList<QTreeWidgetItem *> &items) const; -#else - virtual QMimeData *mimeData(const QList<QTreeWidgetItem*> items) const; -#endif virtual bool dropMimeData(QTreeWidgetItem *parent, int index, const QMimeData *data, Qt::DropAction action); virtual Qt::DropActions supportedDropActions() const; -#if QT_VERSION >= QT_VERSION_CHECK(6, 0, 0) -public: -#else -protected: -#endif - QList<QTreeWidgetItem*> items(const QMimeData *data) const; - - QModelIndex indexFromItem(const QTreeWidgetItem *item, int column = 0) const; -#if QT_VERSION < QT_VERSION_CHECK(6, 0, 0) - QModelIndex indexFromItem(QTreeWidgetItem *item, int column = 0) const; // ### Qt 6: remove -#endif - QTreeWidgetItem *itemFromIndex(const QModelIndex &index) const; - -protected: #if QT_CONFIG(draganddrop) void dropEvent(QDropEvent *event) override; #endif diff --git a/src/widgets/itemviews/qtreewidget_p.h b/src/widgets/itemviews/qtreewidget_p.h index 81e7e86203..f4c754789f 100644 --- a/src/widgets/itemviews/qtreewidget_p.h +++ b/src/widgets/itemviews/qtreewidget_p.h @@ -99,9 +99,7 @@ public: QVariant data(const QModelIndex &index, int role = Qt::DisplayRole) const override; bool setData(const QModelIndex &index, const QVariant &value, int role) override; -#if QT_VERSION >= QT_VERSION_CHECK(6, 0, 0) bool clearItemData(const QModelIndex &index) override; -#endif QMap<int, QVariant> itemData(const QModelIndex &index) const override; QVariant headerData(int section, Qt::Orientation orientation, int role) const override; |