summaryrefslogtreecommitdiffstats
path: root/src/widgets/kernel/qaction_p.h
diff options
context:
space:
mode:
authorJake Petroules <jake.petroules@qt.io>2017-03-13 14:22:06 -0700
committerJake Petroules <jake.petroules@qt.io>2017-03-14 05:29:27 +0000
commit2162f01111d21d0ce66ceb8be290b0a13653e691 (patch)
tree72e6222e3f86523130f249266cf86386b48fdcc6 /src/widgets/kernel/qaction_p.h
parentc2c3452ba5b4c32d0c2d5df9193bf89986623ab5 (diff)
Remove some redundant code in QAction
Only 2 bits are needed to represent -1, 0, and 1 in a signed integer, and !(n != -1) implies n == -1 so the second condition was redundant. Change-Id: I200a17fe4e49ebc0eaa9a1988b4625267cef61a4 Reviewed-by: Gabriel de Dietrich <gabriel.dedietrich@qt.io>
Diffstat (limited to 'src/widgets/kernel/qaction_p.h')
-rw-r--r--src/widgets/kernel/qaction_p.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/widgets/kernel/qaction_p.h b/src/widgets/kernel/qaction_p.h
index 5f4c9a35a3..6813ca08f6 100644
--- a/src/widgets/kernel/qaction_p.h
+++ b/src/widgets/kernel/qaction_p.h
@@ -105,7 +105,7 @@ public:
uint separator : 1;
uint fontSet : 1;
- int iconVisibleInMenu : 3; // Only has values -1, 0, and 1
+ int iconVisibleInMenu : 2; // Only has values -1, 0, and 1
int shortcutVisibleInContextMenu : 2; // Only has values -1, 0, and 1
QAction::MenuRole menuRole;