path: root/src/widgets/kernel/qgesturemanager.cpp
diff options
authorAndy Shaw <>2018-10-17 14:54:43 +0200
committerAndy Shaw <>2019-03-19 10:41:26 +0000
commit1320b2f64412f0d86bd09c66c22df845e13a94a1 (patch)
tree3dc5a7b73ce6044379f4bec9337c91232744effd /src/widgets/kernel/qgesturemanager.cpp
parent01380dc2673d1aecc3e216fff84da76223e447d7 (diff)
Fix memory leak when unregistering a gesture recognizer
When a gesture was unrecognized, then it would add itself to the obsolete gestures hash. This was cleaned up only on application exit, but as the unregister call happens whenever a widget that had registered gestures was deleted then the hash could grow quite considerably. In order to ensure the original intention of the code here, we only call unregisterGestureRecognizer() when there is a QGestureManager in place to call it on. Otherwise it would create a memory leak in itself. Change-Id: I2342f3f737b28be4af7ed531d83f02197eb66c0e Reviewed-by: Richard Moe Gustavsen <>
Diffstat (limited to 'src/widgets/kernel/qgesturemanager.cpp')
1 files changed, 0 insertions, 5 deletions
diff --git a/src/widgets/kernel/qgesturemanager.cpp b/src/widgets/kernel/qgesturemanager.cpp
index c4188044cf..891858b035 100644
--- a/src/widgets/kernel/qgesturemanager.cpp
+++ b/src/widgets/kernel/qgesturemanager.cpp
@@ -143,11 +143,6 @@ Qt::GestureType QGestureManager::registerGestureRecognizer(QGestureRecognizer *r
void QGestureManager::unregisterGestureRecognizer(Qt::GestureType type)
QList<QGestureRecognizer *> list = m_recognizers.values(type);
- while (QGestureRecognizer *recognizer = m_recognizers.take(type)) {
- // ensuring an entry exists causes the recognizer to be deleted on destruction of the manager
- auto &gestures = m_obsoleteGestures[recognizer];
- Q_UNUSED(gestures);
- }
foreach (QGesture *g, m_gestureToRecognizer.keys()) {
QGestureRecognizer *recognizer = m_gestureToRecognizer.value(g);
if (list.contains(recognizer)) {