summaryrefslogtreecommitdiffstats
path: root/src/widgets/util
diff options
context:
space:
mode:
authorShawn Rutledge <shawn.rutledge@qt.io>2018-11-27 10:47:52 +0100
committerShawn Rutledge <shawn.rutledge@qt.io>2018-12-08 07:18:15 +0000
commitc4ee12589122923e680e8dd359c30f6dde370f54 (patch)
tree5bf4962b099fabec2a5ac02ee321147714e7af4c /src/widgets/util
parent501ff0a18cff37cf0d237cd2b04b35fff1bd0837 (diff)
Set QScroller's parent to its widget, for memory management
If the widget to which the scroller was assigned is deleted, the QScroller ought to be deleted too, to avoid filtering events and then following a dangling pointer while trying to react. Fixes: QTBUG-71232 Change-Id: I62680df8d84fb630df1bd8c482df099989457542 Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io> Reviewed-by: Robert Griebl <robert.griebl@pelagicore.com>
Diffstat (limited to 'src/widgets/util')
-rw-r--r--src/widgets/util/qscroller.cpp1
1 files changed, 1 insertions, 0 deletions
diff --git a/src/widgets/util/qscroller.cpp b/src/widgets/util/qscroller.cpp
index abb203b8cc..1e84237253 100644
--- a/src/widgets/util/qscroller.cpp
+++ b/src/widgets/util/qscroller.cpp
@@ -488,6 +488,7 @@ QScroller::QScroller(QObject *target)
: d_ptr(new QScrollerPrivate(this, target))
{
Q_ASSERT(target); // you can't create a scroller without a target in any normal way
+ setParent(target);
Q_D(QScroller);
d->init();
}