diff options
| author | Konstantin Ritt <ritt.ks@gmail.com> | 2015-01-23 13:05:12 +0400 |
|---|---|---|
| committer | Konstantin Ritt <ritt.ks@gmail.com> | 2015-02-13 16:29:16 +0000 |
| commit | 9b67d89c24666d405dd00e63bb56c924738aa002 (patch) | |
| tree | bf0c0197b68097e9aace8ac3708dcbf0e3fe0c7c /src/widgets/widgets | |
| parent | 22b5c39e8e0f4d8cb8a2b2d661e0451e01b75929 (diff) | |
Pass params of shareable type by const-ref rather than by value
...where passing them by value was not intentional.
Change-Id: Ifd5036d57b41fddeeacfbd3f5890881605b80647
Reviewed-by: Shawn Rutledge <shawn.rutledge@digia.com>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Diffstat (limited to 'src/widgets/widgets')
| -rw-r--r-- | src/widgets/widgets/qlineedit.h | 2 | ||||
| -rw-r--r-- | src/widgets/widgets/qlineedit_p.cpp | 2 | ||||
| -rw-r--r-- | src/widgets/widgets/qlineedit_p.h | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/src/widgets/widgets/qlineedit.h b/src/widgets/widgets/qlineedit.h index 3daecbcb56..e006f1c0d8 100644 --- a/src/widgets/widgets/qlineedit.h +++ b/src/widgets/widgets/qlineedit.h @@ -240,7 +240,7 @@ private: Q_PRIVATE_SLOT(d_func(), void _q_textEdited(const QString &)) Q_PRIVATE_SLOT(d_func(), void _q_cursorPositionChanged(int, int)) #ifndef QT_NO_COMPLETER - Q_PRIVATE_SLOT(d_func(), void _q_completionHighlighted(QString)) + Q_PRIVATE_SLOT(d_func(), void _q_completionHighlighted(const QString &)) #endif #ifdef QT_KEYPAD_NAVIGATION Q_PRIVATE_SLOT(d_func(), void _q_editFocusChange(bool)) diff --git a/src/widgets/widgets/qlineedit_p.cpp b/src/widgets/widgets/qlineedit_p.cpp index e913c81a36..b7d2ab4059 100644 --- a/src/widgets/widgets/qlineedit_p.cpp +++ b/src/widgets/widgets/qlineedit_p.cpp @@ -77,7 +77,7 @@ QRect QLineEditPrivate::cursorRect() const #ifndef QT_NO_COMPLETER -void QLineEditPrivate::_q_completionHighlighted(QString newText) +void QLineEditPrivate::_q_completionHighlighted(const QString &newText) { Q_Q(QLineEdit); if (control->completer()->completionMode() != QCompleter::InlineCompletion) { diff --git a/src/widgets/widgets/qlineedit_p.h b/src/widgets/widgets/qlineedit_p.h index 4870cc761d..1ede07e4cb 100644 --- a/src/widgets/widgets/qlineedit_p.h +++ b/src/widgets/widgets/qlineedit_p.h @@ -183,7 +183,7 @@ public: void _q_selectionChanged(); void _q_updateNeeded(const QRect &); #ifndef QT_NO_COMPLETER - void _q_completionHighlighted(QString); + void _q_completionHighlighted(const QString &); #endif QPoint mousePressPos; #ifndef QT_NO_DRAGANDDROP |