summaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorIvan Solovev <ivan.solovev@qt.io>2022-02-10 12:38:29 +0100
committerQt Cherry-pick Bot <cherrypick_bot@qt-project.org>2022-02-16 08:57:36 +0000
commit388803797bce68bd7a956793c286b32ced765048 (patch)
treed3b7936fd74a90d42802320e7d846c9ffbdce6f5 /src
parent29f9bce0681bfe0c89f095f1c09ff062c03489ad (diff)
Android A11Y: Announce value together with element name when focused
Before this patch when we focus a new element, only its description was announced. For elements like Slider that means that if it had no accessible name or description, its value would be announced (all is fine here). But if the slider is defined like that: Slider { Accessible.name: "int slider" value: 5 from: 0 to: 20 stepSize: 1 } only the name ("int slider") will be announced, but not the actual value. This patch fixes the logic of content description generation. If the element has value, then it is added to the description and announced as well. Task-number: QTBUG-93396 Change-Id: Ia8667149ebd867945c5f57d951fd6ade0f382598 Reviewed-by: Rami Potinkara <rami.potinkara@qt.io> Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io> (cherry picked from commit a374d59abc415eee1866322176b7762158f48abd) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
Diffstat (limited to 'src')
-rw-r--r--src/plugins/platforms/android/androidjniaccessibility.cpp10
1 files changed, 7 insertions, 3 deletions
diff --git a/src/plugins/platforms/android/androidjniaccessibility.cpp b/src/plugins/platforms/android/androidjniaccessibility.cpp
index 1f0c7bc2a0..807db78ecf 100644
--- a/src/plugins/platforms/android/androidjniaccessibility.cpp
+++ b/src/plugins/platforms/android/androidjniaccessibility.cpp
@@ -421,14 +421,18 @@ if (!clazz) { \
{
QString desc;
if (iface && iface->isValid()) {
+ bool hasValue = false;
desc = iface->text(QAccessible::Name);
if (desc.isEmpty())
desc = iface->text(QAccessible::Description);
if (desc.isEmpty()) {
desc = iface->text(QAccessible::Value);
- if (desc.isEmpty()) {
- desc = textFromValue(iface);
- }
+ hasValue = !desc.isEmpty();
+ }
+ if (!hasValue) {
+ if (!desc.isEmpty())
+ desc.append(QChar(QChar::Space));
+ desc.append(textFromValue(iface));
}
}
return desc;