diff options
| author | Zou Ya <zouya@uniontech.com> | 2021-03-03 10:57:32 +0800 |
|---|---|---|
| committer | Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> | 2021-03-30 15:10:12 +0000 |
| commit | 9ff12dcfe1943202924a4d3889a61c3aebd2109b (patch) | |
| tree | 96bd9dc8822714a32436c36751f4c2bce371563d /src | |
| parent | 1b349a6df1426ed63c2402e817e908c772746b21 (diff) | |
The condition 'if(oldChild)' is redundant
Either the condition 'if(oldChild)' is redundant or there is possible
null pointer dereference: oldChild.
Change-Id: I28971cfa33294679ddd325158669b422b3a1c2eb
Reviewed-by: Christian Ehrlicher <ch.ehrlicher@gmx.de>
Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
(cherry picked from commit b487a7929d0f16c82a95e37d13de4651d92214cc)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
Diffstat (limited to 'src')
| -rw-r--r-- | src/xml/dom/qdom.cpp | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/src/xml/dom/qdom.cpp b/src/xml/dom/qdom.cpp index b7c676dd09..658140f062 100644 --- a/src/xml/dom/qdom.cpp +++ b/src/xml/dom/qdom.cpp @@ -1261,8 +1261,7 @@ QDomNodePrivate* QDomNodePrivate::replaceChild(QDomNodePrivate* newChild, QDomNo newChild->last = nullptr; // We are no longer interested in the old node - if (oldChild) - oldChild->ref.deref(); + oldChild->ref.deref(); return oldChild; } @@ -1295,8 +1294,7 @@ QDomNodePrivate* QDomNodePrivate::replaceChild(QDomNodePrivate* newChild, QDomNo oldChild->prev = nullptr; // We are no longer interested in the old node - if (oldChild) - oldChild->ref.deref(); + oldChild->ref.deref(); return oldChild; } |