diff options
| author | Volker Hilsheimer <volker.hilsheimer@qt.io> | 2021-02-25 13:22:08 +0100 |
|---|---|---|
| committer | Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> | 2021-02-28 14:21:13 +0000 |
| commit | ad8b779cd7ce0295c529ccbf9e7e845a8da703cb (patch) | |
| tree | 3c0cdf83d873afb58ed694da80840d41868ab481 /src | |
| parent | c286ad46656d4ebafbebdc5f82d1e2737956db40 (diff) | |
Assert that we have a socketEngine before calling it
If we are connected or bound, then we must have an engine.
Otherwise in code we frequently test for the d->socketEngine pointer,
including in waitForConnected.
Fixes static anlyzer warning 3b37ce4102843c97ceef2b7bb68a409d.
Change-Id: Ib9818282ad2813db97859cbe1f184bcfb5ea4ab4
Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
(cherry picked from commit 2af45d0cee253a6bc4e6807076445439cc69c2ce)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
Diffstat (limited to 'src')
| -rw-r--r-- | src/network/socket/qabstractsocket.cpp | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/network/socket/qabstractsocket.cpp b/src/network/socket/qabstractsocket.cpp index f3885a22fe..31847c0142 100644 --- a/src/network/socket/qabstractsocket.cpp +++ b/src/network/socket/qabstractsocket.cpp @@ -2197,6 +2197,7 @@ bool QAbstractSocket::waitForReadyRead(int msecs) do { if (state() != ConnectedState && state() != BoundState) return false; + Q_ASSERT(d->socketEngine); bool readyToRead = false; bool readyToWrite = false; |