summaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorTor Arne Vestbø <tor.arne.vestbo@qt.io>2018-07-05 15:52:17 +0200
committerTor Arne Vestbø <tor.arne.vestbo@qt.io>2018-08-01 08:28:16 +0000
commit6284d2cd77971e2b10c6d61572b358cf9b3cf897 (patch)
tree0469b12af7df50ec4719120747c07f7bc2958c25 /src
parentbd7eb131782286d5b41fb1a5b9de0350b4968e3b (diff)
QWidget: Add note about fixPosIncludesFrame not supporting window states
Change-Id: Iee841e7e6552e24f2b62b0c2df5df3c432680eef Reviewed-by: Gatis Paeglis <gatis.paeglis@qt.io>
Diffstat (limited to 'src')
-rw-r--r--src/widgets/kernel/qwidget.cpp6
1 files changed, 6 insertions, 0 deletions
diff --git a/src/widgets/kernel/qwidget.cpp b/src/widgets/kernel/qwidget.cpp
index 5f1f6d880a..1e249dc191 100644
--- a/src/widgets/kernel/qwidget.cpp
+++ b/src/widgets/kernel/qwidget.cpp
@@ -7165,6 +7165,12 @@ void QWidget::move(const QPoint &p)
// move() was invoked with Qt::WA_WState_Created not set (frame geometry
// unknown), that is, crect has a position including the frame.
// If we can determine the frame strut, fix that and clear the flag.
+// FIXME: This does not play well with window states other than
+// Qt::WindowNoState, as we depend on calling setGeometry() on the
+// platform window after fixing up the position so that the new
+// geometry is reflected in the platform window, but when the frame
+// comes in after the window has been shown (e.g. maximized), we're
+// not in a position to do that kind of fixup.
void QWidgetPrivate::fixPosIncludesFrame()
{
Q_Q(QWidget);