macOS: Allow overriding NSKeyValueObservingOptions for QMacKeyValueObserver

Change-Id: I6dc0f7c542ccfb768c1cd8688168c415e2c8a087
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>

2 files changed, 9 insertions, 6 deletions

diff --git a/src/corelib/kernel/qcore_mac_objc.mm b/src/corelib/kernel/qcore_mac_objc.mm
index 9139b372a8..266faca0ed 100644
--- a/src/corelib/kernel/qcore_mac_objc.mm
+++ b/src/corelib/kernel/qcore_mac_objc.mm
@@ -514,10 +514,9 @@ Q_CONSTRUCTOR_FUNCTION(qt_apple_check_os_version);
 
 // -------------------------------------------------------------------------
 
-void QMacKeyValueObserver::addObserver()
+void QMacKeyValueObserver::addObserver(NSKeyValueObservingOptions options)
 {
-    [object addObserver:observer forKeyPath:keyPath
-        options:NSKeyValueObservingOptionNew context:callback.get()];
+    [object addObserver:observer forKeyPath:keyPath options:options context:callback.get()];
 }
 
 void QMacKeyValueObserver::removeObserver() {
diff --git a/src/corelib/kernel/qcore_mac_p.h b/src/corelib/kernel/qcore_mac_p.h
index 8f4c96bbd6..168e0418e4 100644
--- a/src/corelib/kernel/qcore_mac_p.h
+++ b/src/corelib/kernel/qcore_mac_p.h
@@ -350,8 +350,12 @@ public:
     QMacKeyValueObserver() {}
 
     // Note: QMacKeyValueObserver must not outlive the object observed!
-    QMacKeyValueObserver(id object, NSString *keyPath, Callback callback)
-        : object(object), keyPath(keyPath), callback(new Callback(callback)) { addObserver(); }
+    QMacKeyValueObserver(id object, NSString *keyPath, Callback callback,
+        NSKeyValueObservingOptions options = NSKeyValueObservingOptionNew)
+        : object(object), keyPath(keyPath), callback(new Callback(callback))
+    {
+        addObserver(options);
+    }
 
     QMacKeyValueObserver(const QMacKeyValueObserver &other)
          : QMacKeyValueObserver(other.object, other.keyPath, *other.callback.get()) {}
@@ -381,7 +385,7 @@ private:
         std::swap(first.callback, second.callback);
     }
 
-    void addObserver();
+    void addObserver(NSKeyValueObservingOptions options);
 
     id object = nil;
     NSString *keyPath = nullptr;