Resurrect data moves in QList

Use the data moves to readjust the free space in the QList,
which ultimately fixes the out-of-memory issues caused by
cases like:
forever {
  list.prepend(list.back());
  list.removeLast();
}

Task-number: QTBUG-91801
Task-number: QTBUG-91360
Task-number: QTBUG-93019
Pick-to: dev 6.0 6.1
Change-Id: Iacff69cbf36b8b5b176bb2663df635ec972c875c
Reviewed-by: Lars Knoll <lars.knoll@qt.io>

1 files changed, 1 insertions, 16 deletions

diff --git a/tests/auto/corelib/tools/qarraydata/simplevector.h b/tests/auto/corelib/tools/qarraydata/simplevector.h
index 747af3d422..1fc5e9b8e1 100644
--- a/tests/auto/corelib/tools/qarraydata/simplevector.h
+++ b/tests/auto/corelib/tools/qarraydata/simplevector.h
@@ -209,22 +209,7 @@ public:
         d->insert(0, first, last - first);
     }
 
-    void append(const_iterator first, const_iterator last)
-    {
-        if (first == last)
-            return;
-
-        auto requiredSize = qsizetype(last - first);
-        if (d->needsDetach() || d.freeSpaceAtEnd() < requiredSize) {
-            DataPointer oldData;
-            d.reallocateAndGrow(QArrayData::GrowsAtEnd, requiredSize, &oldData);
-
-            d->copyAppend(first, last);
-            return;
-        }
-
-        d->copyAppend(first, last);
-    }
+    void append(const_iterator first, const_iterator last) { d->growAppend(first, last); }
 
     void insert(int position, const_iterator first, const_iterator last)
     {