diff options
author | Jason McDonald <jason.mcdonald@nokia.com> | 2011-10-04 10:32:49 +1000 |
---|---|---|
committer | Qt by Nokia <qt-info@nokia.com> | 2011-10-04 06:01:38 +0200 |
commit | 9d2ff58f3642828e494e7e9b2df7dbb8e2cd408f (patch) | |
tree | b2d385cd55c0dbfb6d7e1644907e71474ad76d3b /tests/auto/network/socket/qtcpserver/tst_qtcpserver.cpp | |
parent | fe90725ced04351a11f54caff8636e4665fed396 (diff) |
Avoid using QSKIP in lieu of compile-time checks
QSKIP is intended to be used to skip test functions that are found at
run-time to be inapplicable or unsafe. If a test function can be
determined to be inapplicable at compile-time, the entire test function
should be omitted instead of replacing the body of the test function
with a QSKIP, which only serves to slow down test runs and to inflate
test run-rates with empty, inapplicable tests.
Task-number: QTQAINFRA-278
Change-Id: I21664d8d92b27c26c64789fc08d0ec7b8988456a
Reviewed-on: http://codereview.qt-project.org/5941
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
Diffstat (limited to 'tests/auto/network/socket/qtcpserver/tst_qtcpserver.cpp')
-rw-r--r-- | tests/auto/network/socket/qtcpserver/tst_qtcpserver.cpp | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/tests/auto/network/socket/qtcpserver/tst_qtcpserver.cpp b/tests/auto/network/socket/qtcpserver/tst_qtcpserver.cpp index c070be9e64..d982666931 100644 --- a/tests/auto/network/socket/qtcpserver/tst_qtcpserver.cpp +++ b/tests/auto/network/socket/qtcpserver/tst_qtcpserver.cpp @@ -105,7 +105,9 @@ private slots: void waitForConnectionTest(); void setSocketDescriptor(); void listenWhileListening(); +#ifndef QT_NO_PROCESS void addressReusable(); +#endif void setNewSocketDescriptorBlocking(); void invalidProxy_data(); void invalidProxy(); @@ -525,12 +527,9 @@ protected: } }; +#ifndef QT_NO_PROCESS void tst_QTcpServer::addressReusable() { -#if defined(QT_NO_PROCESS) - QSKIP("Qt was compiled with QT_NO_PROCESS", SkipAll); -#else - QFETCH_GLOBAL(bool, setProxy); if (setProxy) { QFETCH_GLOBAL(int, proxyType); @@ -567,8 +566,8 @@ void tst_QTcpServer::addressReusable() QTcpServer server; QVERIFY(server.listen(QHostAddress::LocalHost, 49199)); -#endif } +#endif void tst_QTcpServer::setNewSocketDescriptorBlocking() { |