summaryrefslogtreecommitdiffstats
path: root/tests/auto/widgets/widgets
diff options
context:
space:
mode:
authorLiang Qi <liang.qi@qt.io>2016-12-13 09:36:26 +0100
committerLiang Qi <liang.qi@qt.io>2016-12-13 09:39:20 +0100
commit6755ec891a1740110c48895afd53d39e8370704a (patch)
tree982606f3bc582262e4b315a63f55ccb141fff97b /tests/auto/widgets/widgets
parent449204f8c0d6679ae0e58dbb8a30b8a86fbdb4ec (diff)
parent00c9ec63a552d040e851b561c11428fabf1a2b08 (diff)
Merge remote-tracking branch 'origin/5.8' into dev
Conflicts: configure qmake/Makefile.unix.macos qmake/Makefile.unix.win32 qmake/generators/win32/msvc_vcproj.cpp src/3rdparty/pcre/qt_attribution.json src/corelib/io/qsettings.cpp src/corelib/kernel/qdeadlinetimer.cpp src/platformsupport/kmsconvenience/qkmsdevice.cpp src/platformsupport/kmsconvenience/qkmsdevice_p.h src/plugins/platforms/eglfs/deviceintegration/eglfs_kms/qeglfskmsgbmscreen.cpp src/plugins/platforms/eglfs/deviceintegration/eglfs_kms_egldevice/qeglfskmsegldeviceintegration.cpp src/plugins/platforms/eglfs/deviceintegration/eglfs_kms_egldevice/qeglfskmsegldevicescreen.cpp src/plugins/platforms/eglfs/deviceintegration/eglfs_kms_support/qeglfskmsdevice.cpp src/plugins/platforms/eglfs/deviceintegration/eglfs_kms_support/qeglfskmsscreen.h tests/manual/qstorageinfo/printvolumes.cpp tools/configure/configureapp.cpp Change-Id: Ibaabcc8e965c44926f9fb018466e8b132b8df49e
Diffstat (limited to 'tests/auto/widgets/widgets')
-rw-r--r--tests/auto/widgets/widgets/qcombobox/tst_qcombobox.cpp6
-rw-r--r--tests/auto/widgets/widgets/qdatetimeedit/tst_qdatetimeedit.cpp2
-rw-r--r--tests/auto/widgets/widgets/qdockwidget/tst_qdockwidget.cpp4
-rw-r--r--tests/auto/widgets/widgets/qmenu/tst_qmenu.cpp4
-rw-r--r--tests/auto/widgets/widgets/qmenubar/tst_qmenubar.cpp18
5 files changed, 26 insertions, 8 deletions
diff --git a/tests/auto/widgets/widgets/qcombobox/tst_qcombobox.cpp b/tests/auto/widgets/widgets/qcombobox/tst_qcombobox.cpp
index edaf033678..3afdc0a12a 100644
--- a/tests/auto/widgets/widgets/qcombobox/tst_qcombobox.cpp
+++ b/tests/auto/widgets/widgets/qcombobox/tst_qcombobox.cpp
@@ -305,17 +305,17 @@ void tst_QComboBox::getSetCheck()
obj1.setValidator(var9);
QCOMPARE(obj1.validator(), (const QValidator *)var9);
obj1.setValidator((QValidator *)0);
- QCOMPARE(obj1.validator(), (const QValidator *)0);
+ QCOMPARE(obj1.validator(), nullptr);
delete var9;
// QAbstractItemDelegate * QComboBox::itemDelegate()
// void QComboBox::setItemDelegate(QAbstractItemDelegate *)
MyAbstractItemDelegate *var10 = new MyAbstractItemDelegate;
obj1.setItemDelegate(var10);
- QCOMPARE(obj1.itemDelegate(), (QAbstractItemDelegate *)var10);
+ QCOMPARE(obj1.itemDelegate(), var10);
QTest::ignoreMessage(QtWarningMsg, "QComboBox::setItemDelegate: cannot set a 0 delegate");
obj1.setItemDelegate((QAbstractItemDelegate *)0);
- QCOMPARE(obj1.itemDelegate(), (QAbstractItemDelegate *)var10);
+ QCOMPARE(obj1.itemDelegate(), var10);
// delete var10; // No delete, since QComboBox takes ownership
// QAbstractItemModel * QComboBox::model()
diff --git a/tests/auto/widgets/widgets/qdatetimeedit/tst_qdatetimeedit.cpp b/tests/auto/widgets/widgets/qdatetimeedit/tst_qdatetimeedit.cpp
index 09ab20f7ca..9ab755c5f1 100644
--- a/tests/auto/widgets/widgets/qdatetimeedit/tst_qdatetimeedit.cpp
+++ b/tests/auto/widgets/widgets/qdatetimeedit/tst_qdatetimeedit.cpp
@@ -3710,7 +3710,7 @@ void tst_QDateTimeEdit::dateEditCorrectSectionSize()
QTest::keyClick(&edit, keyPair.first, keyPair.second);
QDateTimeEditPrivate* edit_d_ptr(static_cast<QDateTimeEditPrivate*>(qt_widget_private(&edit)));
- QCOMPARE(edit_d_ptr->text, expectedDisplayString);
+ QCOMPARE(edit_d_ptr->QDateTimeParser::displayText(), expectedDisplayString);
}
#endif
diff --git a/tests/auto/widgets/widgets/qdockwidget/tst_qdockwidget.cpp b/tests/auto/widgets/widgets/qdockwidget/tst_qdockwidget.cpp
index cb55bd32b0..1a1023208a 100644
--- a/tests/auto/widgets/widgets/qdockwidget/tst_qdockwidget.cpp
+++ b/tests/auto/widgets/widgets/qdockwidget/tst_qdockwidget.cpp
@@ -857,8 +857,8 @@ void tst_QDockWidget::task165177_deleteFocusWidget()
qApp->processEvents();
dw->setFloating(true);
delete ledit;
- QCOMPARE(mw.focusWidget(), (QWidget *)0);
- QCOMPARE(dw->focusWidget(), (QWidget *)0);
+ QCOMPARE(mw.focusWidget(), nullptr);
+ QCOMPARE(dw->focusWidget(), nullptr);
}
void tst_QDockWidget::task169808_setFloating()
diff --git a/tests/auto/widgets/widgets/qmenu/tst_qmenu.cpp b/tests/auto/widgets/widgets/qmenu/tst_qmenu.cpp
index cb7643d1ac..3218b8ac68 100644
--- a/tests/auto/widgets/widgets/qmenu/tst_qmenu.cpp
+++ b/tests/auto/widgets/widgets/qmenu/tst_qmenu.cpp
@@ -388,7 +388,7 @@ void tst_QMenu::keyboardNavigation()
#ifndef Q_OS_MAC
QEXPECT_FAIL("shortcut0", "QTBUG-22449: QMenu doesn't remove highlight if a menu item is activated by a shortcut", Abort);
#endif
- QCOMPARE(menus[expected_menu]->activeAction(), (QAction *)0);
+ QCOMPARE(menus[expected_menu]->activeAction(), nullptr);
} else {
QCOMPARE(menus[expected_menu]->activeAction(), builtins[expected_action]);
}
@@ -396,7 +396,7 @@ void tst_QMenu::keyboardNavigation()
if (expected_highlighted)
QCOMPARE(menus[expected_menu]->activeAction(), highlighted);
else
- QCOMPARE(highlighted, (QAction *)0);
+ QCOMPARE(highlighted, nullptr);
}
#ifdef Q_OS_MAC
diff --git a/tests/auto/widgets/widgets/qmenubar/tst_qmenubar.cpp b/tests/auto/widgets/widgets/qmenubar/tst_qmenubar.cpp
index 70d0e9ac9a..2d335c532a 100644
--- a/tests/auto/widgets/widgets/qmenubar/tst_qmenubar.cpp
+++ b/tests/auto/widgets/widgets/qmenubar/tst_qmenubar.cpp
@@ -134,6 +134,7 @@ private slots:
#ifdef Q_OS_MACOS
void taskQTBUG56275_reinsertMenuInParentlessQMenuBar();
#endif
+ void taskQTBUG55966_subMenuRemoved();
void platformMenu();
@@ -1582,5 +1583,22 @@ void tst_QMenuBar::taskQTBUG56275_reinsertMenuInParentlessQMenuBar()
}
#endif // Q_OS_MACOS
+void tst_QMenuBar::taskQTBUG55966_subMenuRemoved()
+{
+ QMainWindow window;
+ QMenuBar *menubar = window.menuBar();
+ QMenu *parentMenu = menubar->addMenu("Parent menu");
+
+ QAction *action = parentMenu->addAction("Action in parent menu");
+ QMenu *subMenu = new QMenu("Submenu");
+ action->setMenu(subMenu);
+ delete subMenu;
+
+ window.show();
+ QApplication::setActiveWindow(&window);
+ QVERIFY(QTest::qWaitForWindowActive(&window));
+ QTest::qWait(500);
+}
+
QTEST_MAIN(tst_QMenuBar)
#include "tst_qmenubar.moc"