summaryrefslogtreecommitdiffstats
path: root/tests/auto
diff options
context:
space:
mode:
authorDavid Faure <faure@kde.org>2012-05-02 22:36:40 +0200
committerQt by Nokia <qt-info@nokia.com>2012-05-02 22:49:26 +0200
commit972464262166752df0015fe1209a7ab307cc7105 (patch)
tree85534a986d8e3d689461c0066d0f2782c2a4897d /tests/auto
parent31a5fb1fa297f292e8fba2df947fc18c217445fa (diff)
Fix unit confusion in ccf3b9e48b2d773999a9a88e249f79380618cde6
I wrote nonsense in that commit. The older methods that take a timeout all take milliseconds, and the comments in the unit test really meant milliseconds, not seconds. 1s is not shorter than 100ms.... Change-Id: Ic18899bb0462d89575dc5a9a311478adc4dea1cb Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Diffstat (limited to 'tests/auto')
-rw-r--r--tests/auto/dbus/qdbusabstractinterface/tst_qdbusabstractinterface.cpp14
1 files changed, 10 insertions, 4 deletions
diff --git a/tests/auto/dbus/qdbusabstractinterface/tst_qdbusabstractinterface.cpp b/tests/auto/dbus/qdbusabstractinterface/tst_qdbusabstractinterface.cpp
index 48ea1e45af..fcc2a32920 100644
--- a/tests/auto/dbus/qdbusabstractinterface/tst_qdbusabstractinterface.cpp
+++ b/tests/auto/dbus/qdbusabstractinterface/tst_qdbusabstractinterface.cpp
@@ -495,7 +495,7 @@ void tst_QDBusAbstractInterface::callWithTimeout()
QDBusMessage msg = QDBusMessage::createMethodCall(server_serviceName,
server_objectPath, server_interfaceName, "sleepMethod");
- msg << 100;
+ msg << 100; // sleep 100 ms
{
// Call with no timeout -> works
@@ -505,7 +505,7 @@ void tst_QDBusAbstractInterface::callWithTimeout()
}
{
- // Call with 1 sec timeout -> fails
+ // Call with 1 msec timeout -> fails
QDBusMessage reply = con.call(msg, QDBus::Block, 1);
QCOMPARE(reply.type(), QDBusMessage::ErrorMessage);
}
@@ -520,11 +520,17 @@ void tst_QDBusAbstractInterface::callWithTimeout()
QCOMPARE(reply.arguments().at(0).toInt(), 42);
}
{
- // Call with 1 sec timeout -> fails
+ // Call with 1 msec timeout -> fails
iface.setTimeout(1);
QDBusMessage reply = iface.call("sleepMethod", 100);
QCOMPARE(reply.type(), QDBusMessage::ErrorMessage);
}
+ {
+ // Call with 300 msec timeout -> works
+ iface.setTimeout(300);
+ QDBusMessage reply = iface.call("sleepMethod", 100);
+ QCOMPARE(reply.arguments().at(0).toInt(), 42);
+ }
// Now using generated code
com::trolltech::QtDBus::Pinger p(server_serviceName, server_objectPath, QDBusConnection::sessionBus());
@@ -535,7 +541,7 @@ void tst_QDBusAbstractInterface::callWithTimeout()
QCOMPARE(int(reply), 42);
}
{
- // Call with 1 sec timeout -> fails
+ // Call with 1 msec timeout -> fails
p.setTimeout(1);
QDBusReply<int> reply = p.sleepMethod(100);
QVERIFY(!reply.isValid());