summaryrefslogtreecommitdiffstats
path: root/tests/auto
diff options
context:
space:
mode:
authorAllan Sandfeld Jensen <allan.jensen@qt.io>2021-04-07 11:31:10 +0200
committerAllan Sandfeld Jensen <allan.jensen@qt.io>2021-04-20 21:33:00 +0200
commitb1f956106cf0fc41eb12d76bb3625fae7687e5f3 (patch)
tree3566db904578b30ef9491b43bfbbd5a67e39c6f4 /tests/auto
parent28b75584c815e0932ba792ad1668f9bc6bae4772 (diff)
Fix tst_qicon for fractional dpr
Add rounding one place, and skip addFile for now since the assumption about rounding dpr up no longer applies. Pick-to: 6.1 Change-Id: I0a84dfabb218acf42cb3816ba50ef899c8762523 Reviewed-by: Morten Johan Sørvig <morten.sorvig@qt.io>
Diffstat (limited to 'tests/auto')
-rw-r--r--tests/auto/gui/image/qicon/tst_qicon.cpp7
1 files changed, 5 insertions, 2 deletions
diff --git a/tests/auto/gui/image/qicon/tst_qicon.cpp b/tests/auto/gui/image/qicon/tst_qicon.cpp
index 5130351c36..7bd7fe3feb 100644
--- a/tests/auto/gui/image/qicon/tst_qicon.cpp
+++ b/tests/auto/gui/image/qicon/tst_qicon.cpp
@@ -145,8 +145,8 @@ void tst_QIcon::actualSize()
auto expectedDeviceSize = [](QSize deviceIndependentExpectedSize, QSize maxSourceImageSize) -> QSize {
qreal dpr = qApp->devicePixelRatio();
- return QSize(qMin(int(deviceIndependentExpectedSize.width() * dpr), maxSourceImageSize.width()),
- qMin(int(deviceIndependentExpectedSize.height() * dpr), maxSourceImageSize.height()));
+ return QSize(qMin(qRound(deviceIndependentExpectedSize.width() * dpr), maxSourceImageSize.width()),
+ qMin(qRound(deviceIndependentExpectedSize.height() * dpr), maxSourceImageSize.height()));
};
QSize sourceSize = QImage(source).size();
@@ -411,6 +411,9 @@ void tst_QIcon::detach()
void tst_QIcon::addFile()
{
+ if (qApp->devicePixelRatio() != int(qApp->devicePixelRatio()))
+ QSKIP("Test is not ready for non integer devicePixelRatio", QTest::SkipAll);
+
QIcon icon;
icon.addFile(QLatin1String(":/styles/commonstyle/images/standardbutton-open-16.png"));
icon.addFile(QLatin1String(":/styles/commonstyle/images/standardbutton-open-32.png"));