summaryrefslogtreecommitdiffstats
path: root/tests/benchmarks/corelib/kernel
diff options
context:
space:
mode:
authorEdward Welbourne <edward.welbourne@qt.io>2021-08-26 18:25:55 +0200
committerEdward Welbourne <edward.welbourne@qt.io>2021-08-30 18:48:39 +0200
commitc2a6749af795386495b275684418d083410fa1e4 (patch)
tree6a6dea83137dcc186e1d4b3b83e58c43d46ce940 /tests/benchmarks/corelib/kernel
parent5c7c2f84bcc1d934315ed86757791b0810be9c1e (diff)
Clean up QLocaleData::validateChars() and fix its double-handling
Decrementing decDigits and checking for zero is less complicated than incrementing a counter to check against it if it's not negative. A plethora of unenlightening local variables could be replaced by keeping track of the last character and of a simple state variable that make checks easier to understand (and explain). Various conditions could be expressed more simply. Comment on the condition for omitting grouping characters from the transcript - it was easy to mistake the comma for a dot ! Comment on the lack of checking of grouping sizes. Change-Id: Iff8da2376507d2abbbaf5739baf6cbb23e55edaf Reviewed-by: Thiago Macieira <thiago.macieira@intel.com> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Diffstat (limited to 'tests/benchmarks/corelib/kernel')
0 files changed, 0 insertions, 0 deletions