path: root/tests
diff options
authorThiago Macieira <>2021-04-21 17:51:01 -0700
committerQt Cherry-pick Bot <>2021-04-24 03:28:24 +0000
commitc0d310d9969111713ec705db1c6c4833c92df468 (patch)
tree70c5664e84a2153e344a9747649c006ea302d877 /tests
parent25d9bf39d9d63710a04a4e8ee7fd89cc234f726b (diff)
QThreadPool: obey the docs that say we always use at least 1 thread
Even if the user (usually accidentally) sets a thread count of zero or negative. The reporter in the bug report did QThread::idealThreadCount() - 1 on a 1 CPU system... Drive-by add to the documentation and the missing #include. Fixes: QTBUG-93007 Change-Id: I6cdea00671e8479b9c50fffd167807d14e030154 Reviewed-by: Samuel Gaist <> Reviewed-by: Sona Kurazyan <> (cherry picked from commit 885eff053797d56f2e295558d0a71b030fbb1a69) Reviewed-by: Qt Cherry-pick Bot <>
Diffstat (limited to 'tests')
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/auto/corelib/thread/qthreadpool/tst_qthreadpool.cpp b/tests/auto/corelib/thread/qthreadpool/tst_qthreadpool.cpp
index e6db963c7b..362faf9e1d 100644
--- a/tests/auto/corelib/thread/qthreadpool/tst_qthreadpool.cpp
+++ b/tests/auto/corelib/thread/qthreadpool/tst_qthreadpool.cpp
@@ -483,7 +483,7 @@ void tst_QThreadPool::setMaxThreadCountStartsAndStopsThreads()
QThreadPool threadPool;
- threadPool.setMaxThreadCount(1);
+ threadPool.setMaxThreadCount(-1); // docs say we'll always start at least one
WaitingTask *task = new WaitingTask;