diff options
| author | Fabian Kosmale <fabian.kosmale@qt.io> | 2021-03-10 11:42:41 +0100 |
|---|---|---|
| committer | Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> | 2021-03-10 20:04:30 +0000 |
| commit | 6498e6f76dd0aff61f24147cb23caad7ed5fc89f (patch) | |
| tree | f152d541d99a40277cb34547a620fcc29746bee3 /tests | |
| parent | 0a7463715ae6acb50935b113768223ceddc50c93 (diff) | |
tst_bench_qguimetatype: only consider valid metatypes
Otherwise the benchmark crashes as the data tag for the row would be
empty.
Fixes: QTBUG-91708
Change-Id: I484ded5b8670571b80012e64d67846d3b8db5320
Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
(cherry picked from commit 90dc1f9204b8f44302b57392ba2fbfdc3653bdf2)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/benchmarks/gui/kernel/qguimetatype/tst_qguimetatype.cpp | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/tests/benchmarks/gui/kernel/qguimetatype/tst_qguimetatype.cpp b/tests/benchmarks/gui/kernel/qguimetatype/tst_qguimetatype.cpp index 7d6c1ef86d..6568307461 100644 --- a/tests/benchmarks/gui/kernel/qguimetatype/tst_qguimetatype.cpp +++ b/tests/benchmarks/gui/kernel/qguimetatype/tst_qguimetatype.cpp @@ -46,8 +46,11 @@ private: void tst_QGuiMetaType::constructableGuiTypes() { QTest::addColumn<int>("typeId"); - for (int i = QMetaType::FirstGuiType; i <= QMetaType::LastGuiType; ++i) - QTest::newRow(QMetaType::typeName(i)) << i; + for (int i = QMetaType::FirstGuiType; i <= QMetaType::LastGuiType; ++i) { + QMetaType metaType(i); + if (metaType.isValid()) + QTest::newRow(QMetaType::typeName(i)) << i; + } } |