diff options
author | hjk <hjk@qt.io> | 2021-03-22 08:32:45 +0100 |
---|---|---|
committer | Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> | 2021-03-23 08:14:49 +0000 |
commit | e94daf91e00260dec449d80e51cf676586c4cd96 (patch) | |
tree | de43df30eb11767d5494c9fb9404003233a8e594 /tests | |
parent | c5859822eb44a81562f0276b3c8af050ac180c78 (diff) |
Make it even more obvious on what to do when tst_toolsupport fails
Triggered by 6778b247.
Change-Id: Ic8e7136cd82eb8d3891450cfa8994f43b7cc09fc
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
(cherry picked from commit 8403fc7796aca7b6f45a88ecaef6485f731dc431)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
Diffstat (limited to 'tests')
-rw-r--r-- | tests/auto/other/toolsupport/tst_toolsupport.cpp | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/tests/auto/other/toolsupport/tst_toolsupport.cpp b/tests/auto/other/toolsupport/tst_toolsupport.cpp index 8860cd7840..d933793778 100644 --- a/tests/auto/other/toolsupport/tst_toolsupport.cpp +++ b/tests/auto/other/toolsupport/tst_toolsupport.cpp @@ -97,12 +97,14 @@ void tst_toolsupport::offsets_data() { QTestData &data = QTest::newRow("sizeof(QObjectData)") << sizeof(QObjectData); + // Please heed the comment at the top of this file when changing this line: data << 44 << 80; // vptr + 2 ptr + (2*ptr + int) + 2 int + ptr } { QTestData &data = QTest::newRow("sizeof(QObjectPrivate::ExtraData)") << sizeof(QObjectPrivate::ExtraData); + // Please heed the comment at the top of this file when changing this line: data << 60 << 120; // 4 * QList + 1 * QString } @@ -110,18 +112,21 @@ void tst_toolsupport::offsets_data() { QTestData &data = QTest::newRow("QObjectPrivate::extraData") << pmm_to_offsetof(&QObjectPrivate::extraData); + // Please heed the comment at the top of this file when changing this line: data << 44 << 80; // sizeof(QObjectData) } { QTestData &data = QTest::newRow("QFileInfoPrivate::fileEntry") << pmm_to_offsetof(&QFileInfoPrivate::fileEntry); + // Please heed the comment at the top of this file when changing this line: data << 4 << 8; } { QTestData &data = QTest::newRow("QFileSystemEntry::filePath") << pmm_to_offsetof(&QFileSystemEntry::m_filePath); + // Please heed the comment at the top of this file when changing this line: data << 0 << 0; } @@ -129,6 +134,7 @@ void tst_toolsupport::offsets_data() { QTestData &data = QTest::newRow("QFilePrivate::fileName") << pmm_to_offsetof(&QFilePrivate::fileName); + // Please heed the comment at the top of this file when changing one of these lines: #ifdef Q_PROCESSOR_X86 // x86 32-bit has weird alignment rules. Refer to QtPrivate::AlignOf in // qglobal.h for more details. @@ -140,6 +146,7 @@ void tst_toolsupport::offsets_data() #endif { + // Please heed the comment at the top of this file when changing one of these lines: QTest::newRow("QDateTimePrivate::m_msecs") << pmm_to_offsetof(&QDateTimePrivate::m_msecs) << 8 << 8; QTest::newRow("QDateTimePrivate::m_status") |