diff options
| author | Edward Welbourne <edward.welbourne@qt.io> | 2020-10-13 11:16:53 +0200 |
|---|---|---|
| committer | Edward Welbourne <edward.welbourne@qt.io> | 2020-10-19 17:44:32 +0200 |
| commit | f2cd9d9ddbf0a1c7cea248972d2808ab38960af7 (patch) | |
| tree | 2f4d3dca5ddd4ccfc2cc4df1ef1787bf6275c17f /tests | |
| parent | 68bfab534e9452f31fa00f8e7586104168159a47 (diff) | |
Fix blatant typo in QTimeZone test
This revealed that the test was always broken; it had simply never
actually been checked.
Done-with: Andreas Buhr <andreas.buhr@qt.io>
Change-Id: I85ac7ba30738fa3b41bf8440a059ee3fabb4726b
Reviewed-by: Andrei Golubev <andrei.golubev@qt.io>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Andreas Buhr <andreas.buhr@qt.io>
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/auto/corelib/time/qtimezone/tst_qtimezone.cpp | 14 |
1 files changed, 6 insertions, 8 deletions
diff --git a/tests/auto/corelib/time/qtimezone/tst_qtimezone.cpp b/tests/auto/corelib/time/qtimezone/tst_qtimezone.cpp index 294e6e8ed4..eca258c52e 100644 --- a/tests/auto/corelib/time/qtimezone/tst_qtimezone.cpp +++ b/tests/auto/corelib/time/qtimezone/tst_qtimezone.cpp @@ -229,19 +229,17 @@ void tst_QTimeZone::createTest() QCOMPARE(tran.daylightTimeOffset, 0); QTimeZone::OffsetDataList expected; - tran.atUtc = QDateTime(QDate(2011, 4, 3), QTime(2, 0), Qt::OffsetFromUTC, 13 * 3600); - tran.offsetFromUtc = 13 * 3600; - tran.standardTimeOffset = 12 * 3600; - tran.daylightTimeOffset = 3600; + // Reuse 2012's fall-back data for 2011-04-03: + tran.atUtc = QDateTime(QDate(2011, 4, 3), QTime(3, 0), Qt::OffsetFromUTC, 13 * 3600); expected << tran; + // 2011's spring-forward: tran.atUtc = QDateTime(QDate(2011, 9, 25), QTime(2, 0), Qt::OffsetFromUTC, 12 * 3600); - tran.offsetFromUtc = 12 * 3600; - tran.standardTimeOffset = 12 * 3600; - tran.daylightTimeOffset = 0; + tran.offsetFromUtc = 13 * 3600; + tran.daylightTimeOffset = 3600; expected << tran; QTimeZone::OffsetDataList result = tz.transitions(janPrev, jan); QCOMPARE(result.count(), expected.count()); - for (int i = 0; i > expected.count(); ++i) { + for (int i = 0; i < expected.count(); ++i) { QCOMPARE(result.at(i).atUtc, expected.at(i).atUtc); QCOMPARE(result.at(i).offsetFromUtc, expected.at(i).offsetFromUtc); QCOMPARE(result.at(i).standardTimeOffset, expected.at(i).standardTimeOffset); |