summaryrefslogtreecommitdiffstats
path: root/tools/configure
diff options
context:
space:
mode:
authorKai Koehne <kai.koehne@qt.io>2016-05-02 17:09:11 +0200
committerJani Heikkinen <jani.heikkinen@qt.io>2016-05-24 17:54:24 +0000
commitefd2ea8ea720833f9602154221d9654aea1f2e6f (patch)
tree8a55033bb5125edcee066ee7f70f09e4603715a7 /tools/configure
parent65ae3de2e12ab0d9b28699b419e3d3aa8af3a267 (diff)
Determine the compiler's default include and lib directories at qmake time
This fixes a long-standing issue for Qt packages, where the paths detected at configure time do not necessarily match the paths on the user's machine. Hence they have been stripped manually from qconfig.pri so far, preventing moc from resolving some includes. The same logic in configure is left alone for the time being, since the paths there are also used to filter paths returned by pg_config and mysql_config. I expect that this will eventually be removed too in a bigger refactoring going on right now in dev. Asking the compiler for implicit paths only works for non-msvc builds - that is, gcc, clang and icc fortunately have a compatible way to retrieve the paths. MSVC works solely on environment variables, which will be taken into account by a separate patch. [ChangeLog][qmake] The implicit compiler directories that moc needs for resolving include files are now determined when qmake runs. So far QMAKE_DEFAULT_INCDIR was determined at configure time, which might be wrong for relocated installations. Task-number: QTBUG-52687 Change-Id: If0706e8c56a5aca2b6e777e79e90342c498726f3 Reviewed-by: Lars Knoll <lars.knoll@theqtcompany.com> Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com>
Diffstat (limited to 'tools/configure')
-rw-r--r--tools/configure/configureapp.cpp5
1 files changed, 0 insertions, 5 deletions
diff --git a/tools/configure/configureapp.cpp b/tools/configure/configureapp.cpp
index e3eb5220be..d490f73496 100644
--- a/tools/configure/configureapp.cpp
+++ b/tools/configure/configureapp.cpp
@@ -3496,11 +3496,6 @@ void Configure::generateQConfigPri()
configStream << " QT_TARGET_ARCH = " << dictionary["QT_ARCH"] << endl;
configStream << "} else {" << endl;
configStream << " QT_ARCH = " << dictionary["QT_ARCH"] << endl;
- if (dictionary.contains("XQMAKESPEC")) {
- // FIXME: add detection
- configStream << " QMAKE_DEFAULT_LIBDIRS = /lib /usr/lib" << endl;
- configStream << " QMAKE_DEFAULT_INCDIRS = /usr/include /usr/local/include" << endl;
- }
configStream << "}" << endl;
configStream << "QT_CONFIG += " << qtConfig.join(' ') << endl;