summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
Diffstat
-rw-r--r--src/corelib/text/qbytearray.cpp246
-rw-r--r--src/corelib/text/qbytearray.h161
-rw-r--r--src/corelib/text/qstringbuilder.h2
-rw-r--r--src/corelib/tools/qtools_p.h4
-rw-r--r--src/gui/rhi/qrhimetal.mm4
-rw-r--r--src/opengl/qopengldebug.cpp4
-rw-r--r--src/plugins/generic/tuiotouch/qoscbundle.cpp4
-rw-r--r--src/plugins/generic/tuiotouch/qoscmessage.cpp4
-rw-r--r--src/plugins/imageformats/jpeg/qjpeghandler.cpp2
-rw-r--r--src/tools/moc/generator.cpp2
-rw-r--r--tests/auto/corelib/serialization/cborlargedatavalidation.cpp8
-rw-r--r--tests/auto/corelib/serialization/qcborvalue/tst_qcborvalue.cpp4
-rw-r--r--tests/auto/corelib/text/qbytearray/tst_qbytearray.cpp4
13 files changed, 222 insertions, 227 deletions
diff --git a/src/corelib/text/qbytearray.cpp b/src/corelib/text/qbytearray.cpp
index 041fb06554..afe2620c7f 100644
--- a/src/corelib/text/qbytearray.cpp
+++ b/src/corelib/text/qbytearray.cpp
@@ -127,7 +127,7 @@ char *qstrcpy(char *dst, const char *src)
if (!src)
return nullptr;
#ifdef Q_CC_MSVC
- const int len = int(strlen(src));
+ const size_t len = strlen(src);
// This is actually not secure!!! It will be fixed
// properly in a later release!
if (len >= 0 && strcpy_s(dst, len+1, src) == 0)
@@ -155,7 +155,7 @@ char *qstrcpy(char *dst, const char *src)
\sa qstrcpy()
*/
-char *qstrncpy(char *dst, const char *src, uint len)
+char *qstrncpy(char *dst, const char *src, size_t len)
{
if (!src || !dst)
return nullptr;
@@ -170,7 +170,7 @@ char *qstrncpy(char *dst, const char *src, uint len)
return dst;
}
-/*! \fn uint qstrlen(const char *str)
+/*! \fn size_t qstrlen(const char *str)
\relates QByteArray
A safe \c strlen() function.
@@ -181,7 +181,7 @@ char *qstrncpy(char *dst, const char *src, uint len)
\sa qstrnlen()
*/
-/*! \fn uint qstrnlen(const char *str, uint maxlen)
+/*! \fn size_t qstrnlen(const char *str, size_t maxlen)
\relates QByteArray
\since 4.2
@@ -214,7 +214,7 @@ int qstrcmp(const char *str1, const char *str2)
: (str1 ? 1 : (str2 ? -1 : 0));
}
-/*! \fn int qstrncmp(const char *str1, const char *str2, uint len);
+/*! \fn int qstrncmp(const char *str1, const char *str2, size_t len);
\relates QByteArray
@@ -284,7 +284,7 @@ int qstricmp(const char *str1, const char *str2)
// very quick.
quintptr u1 = quintptr(s1 + offset);
quintptr u2 = quintptr(s2 + offset);
- uint n = PageSize - ((u1 | u2) & PageMask);
+ size_t n = PageSize - ((u1 | u2) & PageMask);
qptrdiff maxoffset = offset + n;
for ( ; offset + 16 <= maxoffset; offset += sizeof(__m128i)) {
@@ -340,7 +340,7 @@ int qstricmp(const char *str1, const char *str2)
\sa qstrcmp(), qstrncmp(), qstricmp(), {Character Case}, QByteArray::compare()
*/
-int qstrnicmp(const char *str1, const char *str2, uint len)
+int qstrnicmp(const char *str1, const char *str2, size_t len)
{
const uchar *s1 = reinterpret_cast<const uchar *>(str1);
const uchar *s2 = reinterpret_cast<const uchar *>(str2);
@@ -479,7 +479,7 @@ static const quint16 crc_tbl[16] = {
\note This function is a 16-bit cache conserving (16 entry table)
implementation of the CRC-16-CCITT algorithm.
*/
-quint16 qChecksum(const char *data, uint len, Qt::ChecksumType standard)
+quint16 qChecksum(const char *data, qsizetype len, Qt::ChecksumType standard)
{
quint16 crc = 0x0000;
switch (standard) {
@@ -537,7 +537,7 @@ quint16 qChecksum(const char *data, uint len, Qt::ChecksumType standard)
*/
#ifndef QT_NO_COMPRESS
-QByteArray qCompress(const uchar* data, int nbytes, int compressionLevel)
+QByteArray qCompress(const uchar* data, qsizetype nbytes, int compressionLevel)
{
if (nbytes == 0) {
return QByteArray(4, '\0');
@@ -615,7 +615,7 @@ static QByteArray invalidCompressedData()
Uncompresses the first \a nbytes of \a data and returns a new byte
array with the uncompressed data.
*/
-QByteArray qUncompress(const uchar* data, int nbytes)
+QByteArray qUncompress(const uchar* data, qsizetype nbytes)
{
if (!data) {
qWarning("qUncompress: Data is null");
@@ -626,9 +626,9 @@ QByteArray qUncompress(const uchar* data, int nbytes)
qWarning("qUncompress: Input data is corrupted");
return QByteArray();
}
- ulong expectedSize = uint((data[0] << 24) | (data[1] << 16) |
- (data[2] << 8) | (data[3] ));
- ulong len = qMax(expectedSize, 1ul);
+ size_t expectedSize = size_t((data[0] << 24) | (data[1] << 16) |
+ (data[2] << 8) | (data[3] ));
+ size_t len = qMax(expectedSize, 1ul);
const ulong maxPossibleSize = MaxAllocSize - sizeof(QByteArray::Data);
if (Q_UNLIKELY(len >= maxPossibleSize)) {
// QByteArray does not support that huge size anyway.
@@ -641,7 +641,7 @@ QByteArray qUncompress(const uchar* data, int nbytes)
forever {
ulong alloc = len;
- int res = ::uncompress((uchar*)d.data(), &len,
+ int res = ::uncompress((uchar*)d.data(), reinterpret_cast<uLongf*>(&len),
data+4, nbytes-4);
switch (res) {
@@ -816,12 +816,6 @@ QByteArray qUncompress(const uchar* data, int nbytes)
\section1 Maximum size and out-of-memory conditions
- The current version of QByteArray is limited to just under 2 GB (2^31
- bytes) in size. The exact value is architecture-dependent, since it depends
- on the overhead required for managing the data block, but is no more than
- 32 bytes. Raw data blocks are also limited by the use of \c int type in the
- current version to 2 GB minus 1 byte.
-
In case memory allocation fails, QByteArray will throw a \c std::bad_alloc
exception. Out of memory conditions in the Qt containers are the only case
where Qt will throw exceptions.
@@ -1133,8 +1127,8 @@ QByteArray &QByteArray::operator=(const char *str)
} else if (!*str) {
d = DataPointer::fromRawData(&_empty, 0);
} else {
- const int len = int(strlen(str));
- const uint fullLen = uint(len) + 1;
+ const qsizetype len = qsizetype(strlen(str));
+ const size_t fullLen = size_t(len) + 1;
if (d->needsDetach() || fullLen > d->allocatedCapacity()
|| (len < size() && fullLen < (d->allocatedCapacity() >> 1)))
reallocData(fullLen, d->detachFlags());
@@ -1159,7 +1153,7 @@ QByteArray &QByteArray::operator=(const char *str)
fast and never fails.
*/
-/*! \fn int QByteArray::size() const
+/*! \fn qsizetype QByteArray::size() const
Returns the number of bytes in this byte array.
@@ -1187,7 +1181,7 @@ QByteArray &QByteArray::operator=(const char *str)
\sa size()
*/
-/*! \fn int QByteArray::capacity() const
+/*! \fn qsizetype QByteArray::capacity() const
Returns the maximum number of bytes that can be stored in the
byte array without forcing a reallocation.
@@ -1203,7 +1197,7 @@ QByteArray &QByteArray::operator=(const char *str)
\sa reserve(), squeeze()
*/
-/*! \fn void QByteArray::reserve(int size)
+/*! \fn void QByteArray::reserve(qsizetype size)
Attempts to allocate memory for at least \a size bytes. If you
know in advance how large the byte array will be, you can call
@@ -1335,7 +1329,7 @@ QByteArray &QByteArray::operator=(const char *str)
\internal
*/
-/*! \fn char QByteArray::at(int i) const
+/*! \fn char QByteArray::at(qsizetype i) const
Returns the byte at index position \a i in the byte array.
@@ -1345,7 +1339,7 @@ QByteArray &QByteArray::operator=(const char *str)
\sa operator[]()
*/
-/*! \fn char &QByteArray::operator[](int i)
+/*! \fn char &QByteArray::operator[](qsizetype i)
Returns the byte at index position \a i as a modifiable reference.
@@ -1358,7 +1352,7 @@ QByteArray &QByteArray::operator=(const char *str)
\sa at()
*/
-/*! \fn char QByteArray::operator[](int i) const
+/*! \fn char QByteArray::operator[](qsizetype i) const
\overload
@@ -1453,7 +1447,7 @@ QByteArray &QByteArray::operator=(const char *str)
\sa chop(), resize(), left()
*/
-void QByteArray::truncate(int pos)
+void QByteArray::truncate(qsizetype pos)
{
if (pos < size())
resize(pos);
@@ -1472,7 +1466,7 @@ void QByteArray::truncate(int pos)
\sa truncate(), resize(), left()
*/
-void QByteArray::chop(int n)
+void QByteArray::chop(qsizetype n)
{
if (n > 0)
resize(size() - n);
@@ -1519,7 +1513,7 @@ void QByteArray::chop(int n)
reference to this byte array.
*/
-/*! \fn int QByteArray::length() const
+/*! \fn qsizetype QByteArray::length() const
Same as size().
*/
@@ -1560,14 +1554,14 @@ void QByteArray::chop(int n)
\sa fromRawData()
*/
-QByteArray::QByteArray(const char *data, int size)
+QByteArray::QByteArray(const char *data, qsizetype size)
{
if (!data) {
d = DataPointer();
} else {
if (size < 0)
size = int(strlen(data));
- d = DataPointer(Data::allocate(uint(size) + 1u), size);
+ d = DataPointer(Data::allocate(size + 1u), size);
memcpy(d.data(), data, size);
d.data()[size] = '\0';
}
@@ -1579,12 +1573,12 @@ QByteArray::QByteArray(const char *data, int size)
\sa fill()
*/
-QByteArray::QByteArray(int size, char ch)
+QByteArray::QByteArray(qsizetype size, char ch)
{
if (size <= 0) {
d = DataPointer::fromRawData(&_empty, 0);
} else {
- d = DataPointer(Data::allocate(uint(size) + 1u), size);
+ d = DataPointer(Data::allocate(size + 1u), size);
memset(d.data(), ch, size);
d.data()[size] = '\0';
}
@@ -1596,9 +1590,9 @@ QByteArray::QByteArray(int size, char ch)
Constructs a byte array of size \a size with uninitialized contents.
*/
-QByteArray::QByteArray(int size, Qt::Initialization)
+QByteArray::QByteArray(qsizetype size, Qt::Initialization)
{
- d = DataPointer(Data::allocate(uint(size) + 1u), size);
+ d = DataPointer(Data::allocate(size + 1u), size);
d.data()[size] = '\0';
}
@@ -1614,13 +1608,13 @@ QByteArray::QByteArray(int size, Qt::Initialization)
\sa size(), truncate()
*/
-void QByteArray::resize(int size)
+void QByteArray::resize(qsizetype size)
{
if (size < 0)
size = 0;
if (d->needsDetach() || size > capacity())
- reallocData(uint(size) + 1u, d->detachFlags() | Data::GrowsForward);
+ reallocData(size_t(size) + 1u, d->detachFlags() | Data::GrowsForward);
d.size = size;
if (d->allocatedCapacity())
d.data()[size] = 0;
@@ -1636,7 +1630,7 @@ void QByteArray::resize(int size)
\sa resize()
*/
-QByteArray &QByteArray::fill(char ch, int size)
+QByteArray &QByteArray::fill(char ch, qsizetype size)
{
resize(size < 0 ? this->size() : size);
if (this->size())
@@ -1644,7 +1638,7 @@ QByteArray &QByteArray::fill(char ch, int size)
return *this;
}
-void QByteArray::reallocData(uint alloc, Data::ArrayOptions options)
+void QByteArray::reallocData(size_t alloc, Data::ArrayOptions options)
{
if (d->needsDetach()) {
DataPointer dd(Data::allocate(alloc, options), qMin(qsizetype(alloc) - 1, d.size));
@@ -1657,7 +1651,7 @@ void QByteArray::reallocData(uint alloc, Data::ArrayOptions options)
}
}
-void QByteArray::expand(int i)
+void QByteArray::expand(qsizetype i)
{
resize(qMax(i + 1, size()));
}
@@ -1734,11 +1728,11 @@ QByteArray &QByteArray::prepend(const char *str)
The bytes prepended may include '\\0' bytes.
*/
-QByteArray &QByteArray::prepend(const char *str, int len)
+QByteArray &QByteArray::prepend(const char *str, qsizetype len)
{
if (str) {
if (d->needsDetach() || size() + len > capacity())
- reallocData(uint(size() + len) + 1u, d->detachFlags() | Data::GrowsForward);
+ reallocData(size_t(size() + len) + 1u, d->detachFlags() | Data::GrowsForward);
memmove(d.data()+len, d.data(), d.size);
memcpy(d.data(), str, len);
d.size += len;
@@ -1747,7 +1741,7 @@ QByteArray &QByteArray::prepend(const char *str, int len)
return *this;
}
-/*! \fn QByteArray &QByteArray::prepend(int count, char ch)
+/*! \fn QByteArray &QByteArray::prepend(qsizetype count, char ch)
\overload
\since 5.7
@@ -1764,7 +1758,7 @@ QByteArray &QByteArray::prepend(const char *str, int len)
QByteArray &QByteArray::prepend(char ch)
{
if (d->needsDetach() || size() + 1 > capacity())
- reallocData(uint(size()) + 2u, d->detachFlags() | Data::GrowsForward);
+ reallocData(size_t(size()) + 2u, d->detachFlags() | Data::GrowsForward);
memmove(d.data()+1, d.data(), d.size);
d.data()[0] = ch;
++d.size;
@@ -1802,7 +1796,7 @@ QByteArray &QByteArray::append(const QByteArray &ba)
*this = ba;
} else if (ba.size() != 0) {
if (d->needsDetach() || size() + ba.size() > capacity())
- reallocData(uint(size() + ba.size()) + 1u, d->detachFlags() | Data::GrowsForward);
+ reallocData(size_t(size() + ba.size()) + 1u, d->detachFlags() | Data::GrowsForward);
memcpy(d.data() + d.size, ba.data(), ba.size());
d.size += ba.size();
d.data()[d.size] = '\0';
@@ -1819,9 +1813,9 @@ QByteArray &QByteArray::append(const QByteArray &ba)
QByteArray& QByteArray::append(const char *str)
{
if (str) {
- const int len = int(strlen(str));
+ const qsizetype len = qsizetype(strlen(str));
if (d->needsDetach() || size() + len > capacity())
- reallocData(uint(size() + len) + 1u, d->detachFlags() | Data::GrowsForward);
+ reallocData(size_t(size() + len) + 1u, d->detachFlags() | Data::GrowsForward);
memcpy(d.data() + d.size, str, len + 1); // include null terminator
d.size += len;
}
@@ -1843,13 +1837,13 @@ QByteArray& QByteArray::append(const char *str)
array. Ensure that \a len is \e not longer than \a str.
*/
-QByteArray &QByteArray::append(const char *str, int len)
+QByteArray &QByteArray::append(const char *str, qsizetype len)
{
if (len < 0)
len = qstrlen(str);
if (str && len) {
if (d->needsDetach() || size() + len > capacity())
- reallocData(uint(size() + len) + 1u, d->detachFlags() | Data::GrowsForward);
+ reallocData(size_t(size() + len) + 1u, d->detachFlags() | Data::GrowsForward);
memcpy(d.data() + d.size, str, len);
d.size += len;
d.data()[d.size] = '\0';
@@ -1857,7 +1851,7 @@ QByteArray &QByteArray::append(const char *str, int len)
return *this;
}
-/*! \fn QByteArray &QByteArray::append(int count, char ch)
+/*! \fn QByteArray &QByteArray::append(qsizetype count, char ch)
\overload
\since 5.7
@@ -1877,7 +1871,7 @@ QByteArray &QByteArray::append(const char *str, int len)
QByteArray& QByteArray::append(char ch)
{
if (d->needsDetach() || size() + 1 > capacity())
- reallocData(uint(size()) + 2u, d->detachFlags() | Data::GrowsForward);
+ reallocData(size_t(size()) + 2u, d->detachFlags() | Data::GrowsForward);
d.data()[d.size++] = ch;
d.data()[d.size] = '\0';
return *this;
@@ -1889,12 +1883,12 @@ QByteArray& QByteArray::append(char ch)
reference the modified byte array.
*/
static inline QByteArray &qbytearray_insert(QByteArray *ba,
- int pos, const char *arr, int len)
+ qsizetype pos, const char *arr, qsizetype len)
{
if (pos < 0 || len <= 0 || arr == nullptr)
return *ba;
- int oldsize = ba->size();
+ qsizetype oldsize = ba->size();
ba->resize(qMax(pos, oldsize) + len);
char *dst = ba->data();
if (pos > oldsize)
@@ -1915,7 +1909,7 @@ static inline QByteArray &qbytearray_insert(QByteArray *ba,
\sa append(), prepend(), replace(), remove()
*/
-QByteArray &QByteArray::insert(int i, const QByteArray &ba)
+QByteArray &QByteArray::insert(qsizetype i, const QByteArray &ba)
{
QByteArray copy(ba);
return qbytearray_insert(this, i, copy.constData(), copy.size());
@@ -1931,7 +1925,7 @@ QByteArray &QByteArray::insert(int i, const QByteArray &ba)
resize().
*/
-QByteArray &QByteArray::insert(int i, const char *str)
+QByteArray &QByteArray::insert(qsizetype i, const char *str)
{
return qbytearray_insert(this, i, str, qstrlen(str));
}
@@ -1947,7 +1941,7 @@ QByteArray &QByteArray::insert(int i, const char *str)
resize().
*/
-QByteArray &QByteArray::insert(int i, const char *str, int len)
+QByteArray &QByteArray::insert(qsizetype i, const char *str, qsizetype len)
{
return qbytearray_insert(this, i, str, len);
}
@@ -1959,12 +1953,12 @@ QByteArray &QByteArray::insert(int i, const char *str, int len)
greater than size(), the array is first extended using resize().
*/
-QByteArray &QByteArray::insert(int i, char ch)
+QByteArray &QByteArray::insert(qsizetype i, char ch)
{
return qbytearray_insert(this, i, &ch, 1);
}
-/*! \fn QByteArray &QByteArray::insert(int i, int count, char ch)
+/*! \fn QByteArray &QByteArray::insert(qsizetype i, qsizetype count, char ch)
\overload
\since 5.7
@@ -1975,12 +1969,12 @@ QByteArray &QByteArray::insert(int i, char ch)
If \a i is greater than size(), the array is first extended using resize().
*/
-QByteArray &QByteArray::insert(int i, int count, char ch)
+QByteArray &QByteArray::insert(qsizetype i, qsizetype count, char ch)
{
if (i < 0 || count <= 0)
return *this;
- int oldsize = size();
+ qsizetype oldsize = size();
resize(qMax(i, oldsize) + count);
char *dst = d.data();
if (i > oldsize)
@@ -2005,9 +1999,9 @@ QByteArray &QByteArray::insert(int i, int count, char ch)
\sa insert(), replace()
*/
-QByteArray &QByteArray::remove(int pos, int len)
+QByteArray &QByteArray::remove(qsizetype pos, qsizetype len)
{
- if (len <= 0 || uint(pos) >= uint(size()))
+ if (len <= 0 || size_t(pos) >= size_t(size()))
return *this;
detach();
if (len >= size() - pos) {
@@ -2029,7 +2023,7 @@ QByteArray &QByteArray::remove(int pos, int len)
\sa insert(), remove()
*/
-QByteArray &QByteArray::replace(int pos, int len, const QByteArray &after)
+QByteArray &QByteArray::replace(qsizetype pos, qsizetype len, const QByteArray &after)
{
if (len == after.size() && (pos + len <= size())) {
detach();
@@ -2043,7 +2037,7 @@ QByteArray &QByteArray::replace(int pos, int len, const QByteArray &after)
}
}
-/*! \fn QByteArray &QByteArray::replace(int pos, int len, const char *after)
+/*! \fn QByteArray &QByteArray::replace(qsizetype pos, qsizetype len, const char *after)
\overload
@@ -2052,12 +2046,12 @@ QByteArray &QByteArray::replace(int pos, int len, const QByteArray &after)
Notice: this can change the length of the byte array.
*/
-QByteArray &QByteArray::replace(int pos, int len, const char *after)
+QByteArray &QByteArray::replace(qsizetype pos, qsizetype len, const char *after)
{
return replace(pos,len,after,qstrlen(after));
}
-/*! \fn QByteArray &QByteArray::replace(int pos, int len, const char *after, int alen)
+/*! \fn QByteArray &QByteArray::replace(qsizetype pos, qsizetype len, const char *after, qsizetype alen)
\overload
@@ -2066,7 +2060,7 @@ QByteArray &QByteArray::replace(int pos, int len, const char *after)
\since 4.7
*/
-QByteArray &QByteArray::replace(int pos, int len, const char *after, int alen)
+QByteArray &QByteArray::replace(qsizetype pos, qsizetype len, const char *after, qsizetype alen)
{
if (len == alen && (pos + len <= size())) {
detach();
@@ -2079,7 +2073,7 @@ QByteArray &QByteArray::replace(int pos, int len, const char *after, int alen)
}
// ### optimize all other replace method, by offering
-// QByteArray::replace(const char *before, int blen, const char *after, int alen)
+// QByteArray::replace(const char *before, qsizetype blen, const char *after, qsizetype alen)
/*!
\overload
@@ -2110,7 +2104,7 @@ QByteArray &QByteArray::replace(const char *c, const QByteArray &after)
}
/*!
- \fn QByteArray &QByteArray::replace(const char *before, int bsize, const char *after, int asize)
+ \fn QByteArray &QByteArray::replace(const char *before, qsizetype bsize, const char *after, qsizetype asize)
\overload
Replaces every occurrence of the \a bsize bytes starting at \a before with
@@ -2119,7 +2113,7 @@ QByteArray &QByteArray::replace(const char *c, const QByteArray &after)
to be '\\0'-terminated.
*/
-QByteArray &QByteArray::replace(const char *before, int bsize, const char *after, int asize)
+QByteArray &QByteArray::replace(const char *before, qsizetype bsize, const char *after, qsizetype asize)
{
if (isNull() || (before == after && bsize == asize))
return *this;
@@ -2141,8 +2135,8 @@ QByteArray &QByteArray::replace(const char *before, int bsize, const char *after
}
QByteArrayMatcher matcher(before, bsize);
- int index = 0;
- int len = size();
+ qsizetype index = 0;
+ qsizetype len = size();
char *d = data(); // detaches
if (bsize == asize) {
@@ -2153,12 +2147,12 @@ QByteArray &QByteArray::replace(const char *before, int bsize, const char *after
}
}
} else if (asize < bsize) {
- uint to = 0;
- uint movestart = 0;
- uint num = 0;
+ size_t to = 0;
+ size_t movestart = 0;
+ size_t num = 0;
while ((index = matcher.indexIn(*this, index)) != -1) {
if (num) {
- int msize = index - movestart;
+ qsizetype msize = index - movestart;
if (msize > 0) {
memmove(d + to, d + movestart, msize);
to += msize;
@@ -2175,7 +2169,7 @@ QByteArray &QByteArray::replace(const char *before, int bsize, const char *after
num++;
}
if (num) {
- int msize = len - movestart;
+ qsizetype msize = len - movestart;
if (msize > 0)
memmove(d + to, d + movestart, msize);
resize(len - num*(bsize-asize));
@@ -2184,8 +2178,8 @@ QByteArray &QByteArray::replace(const char *before, int bsize, const char *after
// the most complex case. We don't want to lose performance by doing repeated
// copies and reallocs of the data.
while (index != -1) {
- uint indices[4096];
- uint pos = 0;
+ size_t indices[4096];
+ size_t pos = 0;
while(pos < 4095) {
index = matcher.indexIn(*this, index);
if (index == -1)
@@ -2200,12 +2194,12 @@ QByteArray &QByteArray::replace(const char *before, int bsize, const char *after
break;
// we have a table of replacement positions, use them for fast replacing
- int adjust = pos*(asize-bsize);
+ qsizetype adjust = pos*(asize-bsize);
// index has to be adjusted in case we get back into the loop above.
if (index != -1)
index += adjust;
- int newlen = len + adjust;
- int moveend = len;
+ qsizetype newlen = len + adjust;
+ qsizetype moveend = len;
if (newlen > len) {
resize(newlen);
len = newlen;
@@ -2214,9 +2208,9 @@ QByteArray &QByteArray::replace(const char *before, int bsize, const char *after
while(pos) {
pos--;
- int movestart = indices[pos] + bsize;
- int insertstart = indices[pos] + pos*(asize-bsize);
- int moveto = insertstart + asize;
+ qsizetype movestart = indices[pos] + bsize;
+ qsizetype insertstart = indices[pos] + pos*(asize-bsize);
+ qsizetype moveto = insertstart + asize;
memmove(d + moveto, d + movestart, (moveend - movestart));
if (asize)
memcpy(d + insertstart, a, asize);
@@ -2300,8 +2294,8 @@ QByteArray &QByteArray::replace(char before, char after)
QList<QByteArray> QByteArray::split(char sep) const
{
QList<QByteArray> list;
- int start = 0;
- int end;
+ qsizetype start = 0;
+ qsizetype end;
while ((end = indexOf(sep, start)) != -1) {
list.append(mid(start, end - start));
start = end + 1;
@@ -2321,7 +2315,7 @@ QList<QByteArray> QByteArray::split(char sep) const
\snippet code/src_corelib_text_qbytearray.cpp 49
*/
-QByteArray QByteArray::repeated(int times) const
+QByteArray QByteArray::repeated(qsizetype times) const
{
if (isEmpty())
return *this;
@@ -2332,7 +2326,7 @@ QByteArray QByteArray::repeated(int times) const
return QByteArray();
}
- const int resultSize = times * size();
+ const qsizetype resultSize = times * size();
QByteArray result;
result.reserve(resultSize);
@@ -2341,10 +2335,10 @@ QByteArray QByteArray::repeated(int times) const
memcpy(result.d.data(), data(), size());
- int sizeSoFar = size();
+ qsizetype sizeSoFar = size();
char *end = result.d.data() + sizeSoFar;
- const int halfResultSize = resultSize >> 1;
+ const qsizetype halfResultSize = resultSize >> 1;
while (sizeSoFar <= halfResultSize) {
memcpy(end, result.d.data(), sizeSoFar);
end += sizeSoFar;
@@ -2390,7 +2384,7 @@ qsizetype QtPrivate::findByteArray(QByteArrayView haystack, qsizetype from, QByt
return qFindByteArray(haystack.data(), haystack.size(), from, needle.data(), ol);
}
-/*! \fn int QByteArray::indexOf(QByteArrayView bv, int from) const
+/*! \fn qsizetype QByteArray::indexOf(QByteArrayView bv, qsizetype from) const
\since 6.0
Returns the index position of the start of the first occurrence of the
@@ -2416,7 +2410,7 @@ qsizetype QtPrivate::findByteArray(QByteArrayView haystack, qsizetype from, QByt
\sa lastIndexOf(), contains()
*/
-int QByteArray::indexOf(char ch, int from) const
+qsizetype QByteArray::indexOf(char ch, qsizetype from) const
{
return static_cast<int>(findCharHelper(*this, from, ch));
}
@@ -2483,7 +2477,7 @@ qsizetype QtPrivate::lastIndexOf(QByteArrayView haystack, qsizetype from, QByteA
return lastIndexOfHelper(haystack.data(), haystack.size(), needle.data(), ol, from);
}
-/*! \fn int QByteArray::lastIndexOf(QByteArrayView bv, int from) const
+/*! \fn qsizetype QByteArray::lastIndexOf(QByteArrayView bv, qsizetype from) const
\since 6.0
Returns the index position of the start of the last occurrence of the sequence
@@ -2511,7 +2505,7 @@ qsizetype QtPrivate::lastIndexOf(QByteArrayView haystack, qsizetype from, QByteA
\sa indexOf(), contains()
*/
-int QByteArray::lastIndexOf(char ch, int from) const
+qsizetype QByteArray::lastIndexOf(char ch, qsizetype from) const
{
return static_cast<int>(lastIndexOfCharHelper(*this, from, ch));
}
@@ -2544,7 +2538,7 @@ qsizetype QtPrivate::count(QByteArrayView haystack, QByteArrayView needle) noexc
return num;
}
-/*! \fn int QByteArray::count(const QByteArrayView &bv) const
+/*! \fn qsizetype QByteArray::count(QByteArrayView &bv) const
\since 6.0
Returns the number of (potentially overlapping) occurrences of the
@@ -2561,12 +2555,12 @@ qsizetype QtPrivate::count(QByteArrayView haystack, QByteArrayView needle) noexc
\sa contains(), indexOf()
*/
-int QByteArray::count(char ch) const
+qsizetype QByteArray::count(char ch) const
{
return static_cast<int>(countCharHelper(*this, ch));
}
-/*! \fn int QByteArray::count() const
+/*! \fn qsizetype QByteArray::count() const
\overload
@@ -2666,7 +2660,7 @@ bool QByteArray::isUpper() const
const char *d = data();
- for (int i = 0, max = size(); i < max; ++i) {
+ for (qsizetype i = 0, max = size(); i < max; ++i) {
if (!isUpperCaseAscii(d[i]))
return false;
}
@@ -2696,7 +2690,7 @@ bool QByteArray::isLower() const
const char *d = data();
- for (int i = 0, max = size(); i < max; ++i) {
+ for (qsizetype i = 0, max = size(); i < max; ++i) {
if (!isLowerCaseAscii(d[i]))
return false;
}
@@ -2721,7 +2715,7 @@ bool QByteArray::isLower() const
\sa first(), last(), startsWith(), chopped(), chop(), truncate()
*/
-QByteArray QByteArray::left(int len) const
+QByteArray QByteArray::left(qsizetype len) const
{
if (len >= size())
return *this;
@@ -2745,7 +2739,7 @@ QByteArray QByteArray::left(int len) const
\sa endsWith(), last(), first(), sliced(), chopped(), chop(), truncate()
*/
-QByteArray QByteArray::right(int len) const
+QByteArray QByteArray::right(qsizetype len) const
{
if (len >= size())
return *this;
@@ -2770,7 +2764,7 @@ QByteArray QByteArray::right(int len) const
\sa first(), last(), sliced(), chopped(), chop(), truncate()
*/
-QByteArray QByteArray::mid(int pos, int len) const
+QByteArray QByteArray::mid(qsizetype pos, qsizetype len) const
{
qsizetype p = pos;
qsizetype l = len;
@@ -2840,7 +2834,7 @@ QByteArray QByteArray::mid(int pos, int len) const
*/
/*!
- \fn QByteArray::chopped(int len) const
+ \fn QByteArray::chopped(qsizetype len) const
\since 5.10
Returns a byte array that contains the leftmost size() - \a len bytes of
@@ -2977,7 +2971,7 @@ QDataStream &operator>>(QDataStream &in, QByteArray &ba)
quint32 allocated = 0;
do {
- int blockSize = qMin(Step, len - allocated);
+ qsizetype blockSize = qMin(Step, len - allocated);
ba.resize(allocated + blockSize);
if (in.readRawData(ba.data() + allocated, blockSize) != blockSize) {
ba.clear();
@@ -3397,11 +3391,11 @@ QByteArray QByteArray::trimmed_helper(QByteArray &a)
\sa rightJustified()
*/
-QByteArray QByteArray::leftJustified(int width, char fill, bool truncate) const
+QByteArray QByteArray::leftJustified(qsizetype width, char fill, bool truncate) const
{
QByteArray result;
- int len = size();
- int padlen = width - len;
+ qsizetype len = size();
+ qsizetype padlen = width - len;
if (padlen > 0) {
result.resize(len+padlen);
if (len)
@@ -3434,11 +3428,11 @@ QByteArray QByteArray::leftJustified(int width, char fill, bool truncate) const
\sa leftJustified()
*/
-QByteArray QByteArray::rightJustified(int width, char fill, bool truncate) const
+QByteArray QByteArray::rightJustified(qsizetype width, char fill, bool truncate) const
{
QByteArray result;
- int len = size();
- int padlen = width - len;
+ qsizetype len = size();
+ qsizetype padlen = width - len;
if (padlen > 0) {
result.resize(len+padlen);
if (len)
@@ -3803,11 +3797,11 @@ QByteArray QByteArray::toBase64(Base64Options options) const
"ghijklmn" "opqrstuv" "wxyz0123" "456789-_";
const char *const alphabet = options & Base64UrlEncoding ? alphabet_base64url : alphabet_base64;
const char padchar = '=';
- int padlen = 0;
+ qsizetype padlen = 0;
QByteArray tmp((size() + 2) / 3 * 4, Qt::Uninitialized);
- int i = 0;
+ qsizetype i = 0;
char *out = tmp.data();
while (i < size()) {
// encode 3 bytes at a time
@@ -4154,7 +4148,7 @@ QByteArray QByteArray::number(double n, char f, int prec)
}
/*!
- \fn QByteArray QByteArray::fromRawData(const char *data, int size) constexpr
+ \fn QByteArray QByteArray::fromRawData(const char *data, qsizetype size) constexpr
Constructs a QByteArray that uses the first \a size bytes of the
\a data array. The bytes are \e not copied. The QByteArray will
@@ -4203,7 +4197,7 @@ QByteArray QByteArray::number(double n, char f, int prec)
\sa fromRawData(), data(), constData()
*/
-QByteArray &QByteArray::setRawData(const char *data, uint size)
+QByteArray &QByteArray::setRawData(const char *data, qsizetype size)
{
if (!data || !size) {
clear();
@@ -4396,7 +4390,7 @@ QByteArray QByteArray::fromHex(const QByteArray &hexEncoded)
uchar *result = (uchar *)res.data() + res.size();
bool odd_digit = true;
- for (int i = hexEncoded.size() - 1; i >= 0; --i) {
+ for (qsizetype i = hexEncoded.size() - 1; i >= 0; --i) {
uchar ch = uchar(hexEncoded.at(i));
int tmp = QtMiscUtils::fromHex(ch);
if (tmp == -1)
@@ -4431,11 +4425,11 @@ QByteArray QByteArray::toHex(char separator) const
if (isEmpty())
return QByteArray();
- const int length = separator ? (size() * 3 - 1) : (size() * 2);
+ const qsizetype length = separator ? (size() * 3 - 1) : (size() * 2);
QByteArray hex(length, Qt::Uninitialized);
char *hexData = hex.data();
const uchar *data = (const uchar *)this->data();
- for (int i = 0, o = 0; i < size(); ++i) {
+ for (qsizetype i = 0, o = 0; i < size(); ++i) {
hexData[o++] = QtMiscUtils::toHexLower(data[i] >> 4);
hexData[o++] = QtMiscUtils::toHexLower(data[i] & 0xf);
@@ -4453,9 +4447,9 @@ static void q_fromPercentEncoding(QByteArray *ba, char percent)
char *data = ba->data();
const char *inputPtr = data;
- int i = 0;
- int len = ba->count();
- int outlen = 0;
+ qsizetype i = 0;
+ qsizetype len = ba->count();
+ qsizetype outlen = 0;
int a, b;
char c;
while (i < len) {
@@ -4557,12 +4551,12 @@ static void q_toPercentEncoding(QByteArray *ba, const char *dontEncode, const ch
return;
QByteArray input = *ba;
- int len = input.count();
+ qsizetype len = input.count();
const char *inputData = input.constData();
char *output = nullptr;
- int length = 0;
+ qsizetype length = 0;
- for (int i = 0; i < len; ++i) {
+ for (qsizetype i = 0; i < len; ++i) {
unsigned char c = *inputData++;
if (((c >= 0x61 && c <= 0x7A) // ALPHA
|| (c >= 0x41 && c <= 0x5A) // ALPHA
diff --git a/src/corelib/text/qbytearray.h b/src/corelib/text/qbytearray.h
index a625b1846f..5b9e20c516 100644
--- a/src/corelib/text/qbytearray.h
+++ b/src/corelib/text/qbytearray.h
@@ -79,12 +79,12 @@ QT_BEGIN_NAMESPACE
Q_CORE_EXPORT char *qstrdup(const char *);
-inline uint qstrlen(const char *str)
-{ return str ? uint(strlen(str)) : 0; }
+inline size_t qstrlen(const char *str)
+{ return str ? strlen(str) : 0; }
-inline uint qstrnlen(const char *str, uint maxlen)
+inline size_t qstrnlen(const char *str, size_t maxlen)
{
- uint length = 0;
+ size_t length = 0;
if (str) {
while (length < maxlen && *str++)
length++;
@@ -93,19 +93,19 @@ inline uint qstrnlen(const char *str, uint maxlen)
}
Q_CORE_EXPORT char *qstrcpy(char *dst, const char *src);
-Q_CORE_EXPORT char *qstrncpy(char *dst, const char *src, uint len);
+Q_CORE_EXPORT char *qstrncpy(char *dst, const char *src, size_t len);
Q_CORE_EXPORT int qstrcmp(const char *str1, const char *str2);
static inline int qstrcmp(const char *str1, const QByteArray &str2)
{ return -QtPrivate::compareMemory(str2, str1); }
-inline int qstrncmp(const char *str1, const char *str2, uint len)
+inline int qstrncmp(const char *str1, const char *str2, size_t len)
{
return (str1 && str2) ? strncmp(str1, str2, len)
: (str1 ? 1 : (str2 ? -1 : 0));
}
Q_CORE_EXPORT int qstricmp(const char *, const char *);
-Q_CORE_EXPORT int qstrnicmp(const char *, const char *, uint len);
+Q_CORE_EXPORT int qstrnicmp(const char *, const char *, size_t len);
Q_CORE_EXPORT int qstrnicmp(const char *, qsizetype, const char *, qsizetype = -1);
// implemented in qvsnprintf.cpp
@@ -113,7 +113,7 @@ Q_CORE_EXPORT int qvsnprintf(char *str, size_t n, const char *fmt, va_list ap);
Q_CORE_EXPORT int qsnprintf(char *str, size_t n, const char *fmt, ...);
// qChecksum: Internet checksum
-Q_CORE_EXPORT quint16 qChecksum(const char *s, uint len,
+Q_CORE_EXPORT quint16 qChecksum(const char *s, qsizetype len,
Qt::ChecksumType standard = Qt::ChecksumIso3309);
class QString;
@@ -156,9 +156,9 @@ public:
};
inline constexpr QByteArray() noexcept;
- QByteArray(const char *, int size = -1);
- QByteArray(int size, char c);
- QByteArray(int size, Qt::Initialization);
+ QByteArray(const char *, qsizetype size = -1);
+ QByteArray(qsizetype size, char c);
+ QByteArray(qsizetype size, Qt::Initialization);
inline QByteArray(const QByteArray &) noexcept;
inline ~QByteArray();
@@ -172,12 +172,12 @@ public:
{ qSwap(d, other.d); }
inline bool isEmpty() const;
- void resize(int size);
+ void resize(qsizetype size);
- QByteArray &fill(char c, int size = -1);
+ QByteArray &fill(char c, qsizetype size = -1);
- inline int capacity() const;
- inline void reserve(int size);
+ inline qsizetype capacity() const;
+ inline void reserve(qsizetype size);
inline void squeeze();
#ifndef QT_NO_CAST_FROM_BYTEARRAY
@@ -193,43 +193,43 @@ public:
{ return data() == other.data() && size() == other.size(); }
void clear();
- inline char at(int i) const;
- inline char operator[](int i) const;
- Q_REQUIRED_RESULT inline char &operator[](int i);
+ inline char at(qsizetype i) const;
+ inline char operator[](qsizetype i) const;
+ Q_REQUIRED_RESULT inline char &operator[](qsizetype i);
Q_REQUIRED_RESULT char front() const { return at(0); }
Q_REQUIRED_RESULT inline char &front();
Q_REQUIRED_RESULT char back() const { return at(size() - 1); }
Q_REQUIRED_RESULT inline char &back();
- int indexOf(char c, int from = 0) const;
- int indexOf(QByteArrayView bv, int from = 0) const
- { return int(QtPrivate::findByteArray(qToByteArrayViewIgnoringNull(*this), from, bv)); }
+ qsizetype indexOf(char c, qsizetype from = 0) const;
+ qsizetype indexOf(QByteArrayView bv, qsizetype from = 0) const
+ { return QtPrivate::findByteArray(qToByteArrayViewIgnoringNull(*this), from, bv); }
- int lastIndexOf(char c, int from = -1) const;
- int lastIndexOf(QByteArrayView bv, int from = -1) const
- { return int(QtPrivate::lastIndexOf(qToByteArrayViewIgnoringNull(*this), from, bv)); }
+ qsizetype lastIndexOf(char c, qsizetype from = -1) const;
+ qsizetype lastIndexOf(QByteArrayView bv, qsizetype from = -1) const
+ { return QtPrivate::lastIndexOf(qToByteArrayViewIgnoringNull(*this), from, bv); }
inline bool contains(char c) const;
inline bool contains(QByteArrayView bv) const;
- int count(char c) const;
- int count(const QByteArrayView &bv) const
- { return int(QtPrivate::count(qToByteArrayViewIgnoringNull(*this), bv)); }
+ qsizetype count(char c) const;
+ qsizetype count(const QByteArrayView &bv) const
+ { return QtPrivate::count(qToByteArrayViewIgnoringNull(*this), bv); }
inline int compare(const QByteArrayView &a, Qt::CaseSensitivity cs = Qt::CaseSensitive) const noexcept;
- Q_REQUIRED_RESULT QByteArray left(int len) const;
- Q_REQUIRED_RESULT QByteArray right(int len) const;
- Q_REQUIRED_RESULT QByteArray mid(int index, int len = -1) const;
+ Q_REQUIRED_RESULT QByteArray left(qsizetype len) const;
+ Q_REQUIRED_RESULT QByteArray right(qsizetype len) const;
+ Q_REQUIRED_RESULT QByteArray mid(qsizetype index, qsizetype len = -1) const;
Q_REQUIRED_RESULT QByteArray first(qsizetype n) const
- { Q_ASSERT(n >= 0); Q_ASSERT(n <= size()); return QByteArray(data(), int(n)); }
+ { Q_ASSERT(n >= 0); Q_ASSERT(n <= size()); return QByteArray(data(), n); }
Q_REQUIRED_RESULT QByteArray last(qsizetype n) const
- { Q_ASSERT(n >= 0); Q_ASSERT(n <= size()); return QByteArray(data() + size() - n, int(n)); }
+ { Q_ASSERT(n >= 0); Q_ASSERT(n <= size()); return QByteArray(data() + size() - n, n); }
Q_REQUIRED_RESULT QByteArray sliced(qsizetype pos) const
- { Q_ASSERT(pos >= 0); Q_ASSERT(pos <= size()); return QByteArray(data() + pos, size() - int(pos)); }
+ { Q_ASSERT(pos >= 0); Q_ASSERT(pos <= size()); return QByteArray(data() + pos, size() - pos); }
Q_REQUIRED_RESULT QByteArray sliced(qsizetype pos, qsizetype n) const
- { Q_ASSERT(pos >= 0); Q_ASSERT(n >= 0); Q_ASSERT(size_t(pos) + size_t(n) <= size_t(size())); return QByteArray(data() + pos, int(n)); }
- Q_REQUIRED_RESULT QByteArray chopped(int len) const
+ { Q_ASSERT(pos >= 0); Q_ASSERT(n >= 0); Q_ASSERT(size_t(pos) + size_t(n) <= size_t(size())); return QByteArray(data() + pos, n); }
+ Q_REQUIRED_RESULT QByteArray chopped(qsizetype len) const
{ Q_ASSERT(len >= 0); Q_ASSERT(len <= size()); return first(size() - len); }
bool startsWith(QByteArrayView bv) const
@@ -243,8 +243,8 @@ public:
bool isUpper() const;
bool isLower() const;
- void truncate(int pos);
- void chop(int n);
+ void truncate(qsizetype pos);
+ void chop(qsizetype n);
#if !defined(Q_CLANG_QDOC)
Q_REQUIRED_RESULT QByteArray toLower() const &
@@ -270,32 +270,32 @@ public:
Q_REQUIRED_RESULT QByteArray simplified() const;
#endif
- Q_REQUIRED_RESULT QByteArray leftJustified(int width, char fill = ' ', bool truncate = false) const;
- Q_REQUIRED_RESULT QByteArray rightJustified(int width, char fill = ' ', bool truncate = false) const;
+ Q_REQUIRED_RESULT QByteArray leftJustified(qsizetype width, char fill = ' ', bool truncate = false) const;
+ Q_REQUIRED_RESULT QByteArray rightJustified(qsizetype width, char fill = ' ', bool truncate = false) const;
QByteArray &prepend(char c);
- inline QByteArray &prepend(int count, char c);
+ inline QByteArray &prepend(qsizetype count, char c);
QByteArray &prepend(const char *s);
- QByteArray &prepend(const char *s, int len);
+ QByteArray &prepend(const char *s, qsizetype len);
QByteArray &prepend(const QByteArray &a);
QByteArray &append(char c);
- inline QByteArray &append(int count, char c);
+ inline QByteArray &append(qsizetype count, char c);
QByteArray &append(const char *s);
- QByteArray &append(const char *s, int len);
+ QByteArray &append(const char *s, qsizetype len);
QByteArray &append(const QByteArray &a);
- QByteArray &insert(int i, char c);
- QByteArray &insert(int i, int count, char c);
- QByteArray &insert(int i, const char *s);
- QByteArray &insert(int i, const char *s, int len);
- QByteArray &insert(int i, const QByteArray &a);
- QByteArray &remove(int index, int len);
- QByteArray &replace(int index, int len, const char *s);
- QByteArray &replace(int index, int len, const char *s, int alen);
- QByteArray &replace(int index, int len, const QByteArray &s);
+ QByteArray &insert(qsizetype i, char c);
+ QByteArray &insert(qsizetype i, qsizetype count, char c);
+ QByteArray &insert(qsizetype i, const char *s);
+ QByteArray &insert(qsizetype i, const char *s, qsizetype len);
+ QByteArray &insert(qsizetype i, const QByteArray &a);
+ QByteArray &remove(qsizetype index, qsizetype len);
+ QByteArray &replace(qsizetype index, qsizetype len, const char *s);
+ QByteArray &replace(qsizetype index, qsizetype len, const char *s, qsizetype alen);
+ QByteArray &replace(qsizetype index, qsizetype len, const QByteArray &s);
inline QByteArray &replace(char before, const char *after);
QByteArray &replace(char before, const QByteArray &after);
inline QByteArray &replace(const char *before, const char *after);
- QByteArray &replace(const char *before, int bsize, const char *after, int asize);
+ QByteArray &replace(const char *before, qsizetype bsize, const char *after, qsizetype asize);
QByteArray &replace(const QByteArray &before, const QByteArray &after);
inline QByteArray &replace(const QByteArray &before, const char *after);
QByteArray &replace(const char *before, const QByteArray &after);
@@ -306,7 +306,7 @@ public:
QList<QByteArray> split(char sep) const;
- Q_REQUIRED_RESULT QByteArray repeated(int times) const;
+ Q_REQUIRED_RESULT QByteArray repeated(qsizetype times) const;
#if !defined(QT_NO_CAST_FROM_ASCII) && !defined(QT_RESTRICTED_CAST_FROM_ASCII)
inline QT_ASCII_CAST_WARN bool operator==(const QString &s2) const;
@@ -343,7 +343,7 @@ public:
QByteArray &setNum(qulonglong, int base = 10);
inline QByteArray &setNum(float, char f = 'g', int prec = 6);
QByteArray &setNum(double, char f = 'g', int prec = 6);
- QByteArray &setRawData(const char *a, uint n); // ### Qt 6: use an int
+ QByteArray &setRawData(const char *a, qsizetype n);
Q_REQUIRED_RESULT static QByteArray number(int, int base = 10);
Q_REQUIRED_RESULT static QByteArray number(uint, int base = 10);
@@ -352,7 +352,7 @@ public:
Q_REQUIRED_RESULT static QByteArray number(qlonglong, int base = 10);
Q_REQUIRED_RESULT static QByteArray number(qulonglong, int base = 10);
Q_REQUIRED_RESULT static QByteArray number(double, char f = 'g', int prec = 6);
- Q_REQUIRED_RESULT static QByteArray fromRawData(const char *data, int size)
+ Q_REQUIRED_RESULT static QByteArray fromRawData(const char *data, qsizetype size)
{
return QByteArray(DataPointer(nullptr, const_cast<char *>(data), size));
}
@@ -397,7 +397,7 @@ public:
const_reverse_iterator crend() const { return const_reverse_iterator(begin()); }
// stl compatibility
- typedef int size_type;
+ typedef qsizetype size_type;
typedef qptrdiff difference_type;
typedef const char & const_reference;
typedef char & reference;
@@ -415,9 +415,9 @@ public:
static inline QByteArray fromStdString(const std::string &s);
inline std::string toStdString() const;
- inline int size() const { return int(d->size); }
- inline int count() const { return size(); }
- inline int length() const { return size(); }
+ inline qsizetype size() const { return d->size; }
+ inline qsizetype count() const { return size(); }
+ inline qsizetype length() const { return size(); }
bool isNull() const;
inline DataPointer &data_ptr() { return d; }
@@ -427,8 +427,8 @@ public:
}
private:
- void reallocData(uint alloc, Data::ArrayOptions options);
- void expand(int i);
+ void reallocData(size_t alloc, Data::ArrayOptions options);
+ void expand(qsizetype i);
QByteArray nulTerminated() const;
static QByteArray toLower_helper(const QByteArray &a);
@@ -441,7 +441,7 @@ private:
static QByteArray simplified_helper(QByteArray &a);
friend class QString;
- friend Q_CORE_EXPORT QByteArray qUncompress(const uchar *data, int nbytes);
+ friend Q_CORE_EXPORT QByteArray qUncompress(const uchar *data, qsizetype nbytes);
};
Q_DECLARE_OPERATORS_FOR_FLAGS(QByteArray::Base64Options)
@@ -449,10 +449,10 @@ Q_DECLARE_OPERATORS_FOR_FLAGS(QByteArray::Base64Options)
inline constexpr QByteArray::QByteArray() noexcept {}
inline QByteArray::~QByteArray() {}
-inline char QByteArray::at(int i) const
-{ Q_ASSERT(uint(i) < uint(size())); return d.data()[i]; }
-inline char QByteArray::operator[](int i) const
-{ Q_ASSERT(uint(i) < uint(size())); return d.data()[i]; }
+inline char QByteArray::at(qsizetype i) const
+{ Q_ASSERT(size_t(i) < size_t(size())); return d.data()[i]; }
+inline char QByteArray::operator[](qsizetype i) const
+{ Q_ASSERT(size_t(i) < size_t(size())); return d.data()[i]; }
inline bool QByteArray::isEmpty() const
{ return size() == 0; }
@@ -479,19 +479,19 @@ inline const char *QByteArray::data() const
inline const char *QByteArray::constData() const
{ return data(); }
inline void QByteArray::detach()
-{ if (d->needsDetach()) reallocData(uint(size()) + 1u, d->detachFlags()); }
+{ if (d->needsDetach()) reallocData(size_t(size()) + 1u, d->detachFlags()); }
inline bool QByteArray::isDetached() const
{ return !d->isShared(); }
inline QByteArray::QByteArray(const QByteArray &a) noexcept : d(a.d)
{}
-inline int QByteArray::capacity() const
-{ const auto realCapacity = d->constAllocatedCapacity(); return realCapacity ? int(realCapacity) - 1 : 0; }
+inline qsizetype QByteArray::capacity() const
+{ const auto realCapacity = d->constAllocatedCapacity(); return realCapacity ? realCapacity - 1 : 0; }
-inline void QByteArray::reserve(int asize)
+inline void QByteArray::reserve(qsizetype asize)
{
if (d->needsDetach() || asize > capacity()) {
- reallocData(qMax(uint(size()), uint(asize)) + 1u, d->detachFlags() | Data::CapacityReserved);
+ reallocData(qMax(size_t(size()), size_t(asize)) + 1u, d->detachFlags() | Data::CapacityReserved);
} else {
d->setFlag(Data::CapacityReserved);
}
@@ -502,13 +502,13 @@ inline void QByteArray::squeeze()
if ((d->flags() & Data::CapacityReserved) == 0)
return;
if (d->needsDetach() || size() < capacity()) {
- reallocData(uint(size()) + 1u, d->detachFlags() & ~Data::CapacityReserved);
+ reallocData(size_t(size()) + 1u, d->detachFlags() & ~Data::CapacityReserved);
} else {
d->clearFlag(Data::CapacityReserved);
}
}
-inline char &QByteArray::operator[](int i)
+inline char &QByteArray::operator[](qsizetype i)
{ Q_ASSERT(i >= 0 && i < size()); return data()[i]; }
inline char &QByteArray::front() { return operator[](0); }
inline char &QByteArray::back() { return operator[](size() - 1); }
@@ -528,9 +528,9 @@ inline QByteArray::const_iterator QByteArray::cend() const
{ return data() + size(); }
inline QByteArray::const_iterator QByteArray::constEnd() const
{ return data() + size(); }
-inline QByteArray &QByteArray::append(int n, char ch)
+inline QByteArray &QByteArray::append(qsizetype n, char ch)
{ return insert(size(), n, ch); }
-inline QByteArray &QByteArray::prepend(int n, char ch)
+inline QByteArray &QByteArray::prepend(qsizetype n, char ch)
{ return insert(0, n, ch); }
inline QByteArray &QByteArray::operator+=(char c)
{ return append(c); }
@@ -632,7 +632,7 @@ inline std::string QByteArray::toStdString() const
{ return std::string(constData(), length()); }
inline QByteArray QByteArray::fromStdString(const std::string &s)
-{ return QByteArray(s.data(), int(s.size())); }
+{ return QByteArray(s.data(), qsizetype(s.size())); }
#if !defined(QT_NO_DATASTREAM) || (defined(QT_BOOTSTRAPPED) && !defined(QT_BUILD_QMAKE))
Q_CORE_EXPORT QDataStream &operator<<(QDataStream &, const QByteArray &);
@@ -640,8 +640,8 @@ Q_CORE_EXPORT QDataStream &operator>>(QDataStream &, QByteArray &);
#endif
#ifndef QT_NO_COMPRESS
-Q_CORE_EXPORT QByteArray qCompress(const uchar* data, int nbytes, int compressionLevel = -1);
-Q_CORE_EXPORT QByteArray qUncompress(const uchar* data, int nbytes);
+Q_CORE_EXPORT QByteArray qCompress(const uchar* data, qsizetype nbytes, int compressionLevel = -1);
+Q_CORE_EXPORT QByteArray qUncompress(const uchar* data, qsizetype nbytes);
inline QByteArray qCompress(const QByteArray& data, int compressionLevel = -1)
{ return qCompress(reinterpret_cast<const uchar *>(data.constData()), data.size(), compressionLevel); }
inline QByteArray qUncompress(const QByteArray& data)
@@ -699,8 +699,7 @@ Q_CORE_EXPORT Q_DECL_PURE_FUNCTION size_t qHash(const QByteArray::FromBase64Resu
//
QByteArray QByteArrayView::toByteArray() const
{
- Q_ASSERT(size() == int(size()));
- return QByteArray(data(), int(size()));
+ return QByteArray(data(), size());
}
QT_END_NAMESPACE
diff --git a/src/corelib/text/qstringbuilder.h b/src/corelib/text/qstringbuilder.h
index 31d1526e1e..940eb9f4f7 100644
--- a/src/corelib/text/qstringbuilder.h
+++ b/src/corelib/text/qstringbuilder.h
@@ -310,7 +310,7 @@ template <> struct QConcatenable<const char *> : private QAbstractConcatenable
typedef const char *type;
typedef QByteArray ConvertTo;
enum { ExactSize = false };
- static int size(const char *a) { return qstrlen(a); }
+ static qsizetype size(const char *a) { return qstrlen(a); }
#ifndef QT_NO_CAST_FROM_ASCII
static inline void QT_ASCII_CAST_WARN appendTo(const char *a, QChar *&out)
{ QAbstractConcatenable::convertFromAscii(a, -1, out); }
diff --git a/src/corelib/tools/qtools_p.h b/src/corelib/tools/qtools_p.h
index a86a55646d..5b6be12820 100644
--- a/src/corelib/tools/qtools_p.h
+++ b/src/corelib/tools/qtools_p.h
@@ -87,9 +87,7 @@ constexpr inline int fromOct(uint c) noexcept
}
// We typically need an extra bit for qNextPowerOfTwo when determining the next allocation size.
-enum {
- MaxAllocSize = (std::numeric_limits<int>::max)()
-};
+constexpr qsizetype MaxAllocSize = (std::numeric_limits<qsizetype>::max)();
struct CalculateGrowingBlockSizeResult {
qsizetype size;
diff --git a/src/gui/rhi/qrhimetal.mm b/src/gui/rhi/qrhimetal.mm
index d9575e949b..7d2b1982f0 100644
--- a/src/gui/rhi/qrhimetal.mm
+++ b/src/gui/rhi/qrhimetal.mm
@@ -1636,7 +1636,7 @@ void QRhiMetal::enqueueSubresUpload(QMetalTexture *texD, void *mp, void *blitEnc
destinationOrigin: MTLOriginMake(NSUInteger(dx), NSUInteger(dy), 0)
options: MTLBlitOptionNone];
- *curOfs += aligned(rawData.size(), QRhiMetalData::TEXBUF_ALIGN);
+ *curOfs += aligned<qsizetype>(rawData.size(), QRhiMetalData::TEXBUF_ALIGN);
} else if (!rawData.isEmpty()) {
const QSize subresSize = q->sizeForMipLevel(level, texD->m_pixelSize);
const int subresw = subresSize.width();
@@ -1665,7 +1665,7 @@ void QRhiMetal::enqueueSubresUpload(QMetalTexture *texD, void *mp, void *blitEnc
destinationOrigin: MTLOriginMake(NSUInteger(dp.x()), NSUInteger(dp.y()), 0)
options: MTLBlitOptionNone];
- *curOfs += aligned(rawData.size(), QRhiMetalData::TEXBUF_ALIGN);
+ *curOfs += aligned<qsizetype>(rawData.size(), QRhiMetalData::TEXBUF_ALIGN);
} else {
qWarning("Invalid texture upload for %p layer=%d mip=%d", texD, layer, level);
}
diff --git a/src/opengl/qopengldebug.cpp b/src/opengl/qopengldebug.cpp
index ef3b955f90..3df1f2f29a 100644
--- a/src/opengl/qopengldebug.cpp
+++ b/src/opengl/qopengldebug.cpp
@@ -1540,7 +1540,7 @@ void QOpenGLDebugLogger::logMessage(const QOpenGLDebugMessage &debugMessage)
if (rawMessage.length() > d->maxMessageLength) {
qWarning("QOpenGLDebugLogger::logMessage(): message too long, truncating it\n"
- " (%d bytes long, but the GL accepts up to %d bytes)", rawMessage.length(), d->maxMessageLength);
+ " (%d bytes long, but the GL accepts up to %d bytes)", int(rawMessage.length()), d->maxMessageLength);
rawMessage.resize(d->maxMessageLength - 1);
rawMessage.append('\0');
}
@@ -1592,7 +1592,7 @@ void QOpenGLDebugLogger::pushGroup(const QString &name, GLuint id, QOpenGLDebugM
rawName.append('\0');
if (rawName.length() > d->maxMessageLength) {
qWarning("QOpenGLDebugLogger::pushGroup(): group name too long, truncating it\n"
- " (%d bytes long, but the GL accepts up to %d bytes)", rawName.length(), d->maxMessageLength);
+ " (%d bytes long, but the GL accepts up to %d bytes)", int(rawName.length()), d->maxMessageLength);
rawName.resize(d->maxMessageLength - 1);
rawName.append('\0');
}
diff --git a/src/plugins/generic/tuiotouch/qoscbundle.cpp b/src/plugins/generic/tuiotouch/qoscbundle.cpp
index e9166922a1..355747db6a 100644
--- a/src/plugins/generic/tuiotouch/qoscbundle.cpp
+++ b/src/plugins/generic/tuiotouch/qoscbundle.cpp
@@ -80,7 +80,7 @@ QOscBundle::QOscBundle(const QByteArray &data)
// "followed by an OSC Time
// Tag, followed by zero or more OSC Bundle Elements. The OSC-timetag is a
// 64-bit fixed point time tag whose semantics are described below."
- if (parsedBytes > (quint32)data.size() || data.size() - parsedBytes < sizeof(quint64))
+ if (parsedBytes > (quint32)data.size() || data.size() - parsedBytes < qsizetype(sizeof(quint64)))
return;
// "Time tags are represented by a 64 bit fixed point number. The first 32
@@ -113,7 +113,7 @@ QOscBundle::QOscBundle(const QByteArray &data)
//
// in practice, a bundle can contain multiple bundles or messages,
// though, and each is prefixed by a size.
- if (data.size() - parsedBytes < sizeof(quint32))
+ if (data.size() - parsedBytes < qsizetype(sizeof(quint32)))
return;
quint32 size = qFromBigEndian<quint32>((const uchar*)data.constData() + parsedBytes);
diff --git a/src/plugins/generic/tuiotouch/qoscmessage.cpp b/src/plugins/generic/tuiotouch/qoscmessage.cpp
index dba0decf51..ef2f8a6ae9 100644
--- a/src/plugins/generic/tuiotouch/qoscmessage.cpp
+++ b/src/plugins/generic/tuiotouch/qoscmessage.cpp
@@ -92,7 +92,7 @@ QOscMessage::QOscMessage(const QByteArray &data)
return;
arguments.append(aString);
} else if (typeTag == 'i') { // int32
- if (parsedBytes > (quint32)data.size() || data.size() - parsedBytes < sizeof(quint32))
+ if (parsedBytes > (quint32)data.size() || data.size() - parsedBytes < qsizetype(sizeof(quint32)))
return;
quint32 anInt = qFromBigEndian<quint32>(data.constData() + parsedBytes);
@@ -101,7 +101,7 @@ QOscMessage::QOscMessage(const QByteArray &data)
// TODO: is int32 in OSC signed, or unsigned?
arguments.append((int)anInt);
} else if (typeTag == 'f') { // float32
- if (parsedBytes > (quint32)data.size() || data.size() - parsedBytes < sizeof(quint32))
+ if (parsedBytes > (quint32)data.size() || data.size() - parsedBytes < qsizetype(sizeof(quint32)))
return;
static_assert(sizeof(float) == sizeof(quint32));
diff --git a/src/plugins/imageformats/jpeg/qjpeghandler.cpp b/src/plugins/imageformats/jpeg/qjpeghandler.cpp
index 7574d1ca00..72d932445e 100644
--- a/src/plugins/imageformats/jpeg/qjpeghandler.cpp
+++ b/src/plugins/imageformats/jpeg/qjpeghandler.cpp
@@ -516,7 +516,7 @@ static inline void write_icc_profile(const QImage &image, j_compress_ptr cinfo)
const int markers = (iccProfile.size() + (maxIccMarkerSize - 1)) / maxIccMarkerSize;
Q_ASSERT(markers < 256);
for (int marker = 1; marker <= markers; ++marker) {
- const int len = std::min(iccProfile.size() - index, maxIccMarkerSize);
+ const int len = qMin(iccProfile.size() - index, maxIccMarkerSize);
const QByteArray block = iccSignature
+ QByteArray(1, char(marker)) + QByteArray(1, char(markers))
+ iccProfile.mid(index, len);
diff --git a/src/tools/moc/generator.cpp b/src/tools/moc/generator.cpp
index cc43ca4490..c36e01a79a 100644
--- a/src/tools/moc/generator.cpp
+++ b/src/tools/moc/generator.cpp
@@ -279,7 +279,7 @@ void Generator::generateCode()
int idx = 0;
for (int i = 0; i < strings.size(); ++i) {
const QByteArray &str = strings.at(i);
- fprintf(out, "QT_MOC_LITERAL(%d, %d)", idx, str.length());
+ fprintf(out, "QT_MOC_LITERAL(%d, %d)", idx, int(str.length()));
if (i != strings.size() - 1)
fputc(',', out);
const QByteArray comment = str.length() > 32 ? str.left(29) + "..." : str;
diff --git a/tests/auto/corelib/serialization/cborlargedatavalidation.cpp b/tests/auto/corelib/serialization/cborlargedatavalidation.cpp
index f3b6893957..b1de0e1a54 100644
--- a/tests/auto/corelib/serialization/cborlargedatavalidation.cpp
+++ b/tests/auto/corelib/serialization/cborlargedatavalidation.cpp
@@ -128,8 +128,12 @@ void addValidationHugeDevice(qsizetype byteArrayInvalid, qsizetype stringInvalid
// do the exact limits
QTest::newRow("bytearray-just-too-big")
<< device(QCborStreamReader::ByteArray, byteArrayInvalid) << CborErrorDataTooLarge;
- QTest::newRow("string-just-too-big")
- << device(QCborStreamReader::String, stringInvalid) << CborErrorDataTooLarge;
+
+ // TODO: Fix this to work for 64-bit. The test tries to allocate too much data and fails.
+ if (sizeof(size_t) == 4) {
+ QTest::newRow("string-just-too-big")
+ << device(QCborStreamReader::String, stringInvalid) << CborErrorDataTooLarge;
+ }
auto addSize = [=](const char *sizename, qint64 size) {
if (byteArrayInvalid < size)
diff --git a/tests/auto/corelib/serialization/qcborvalue/tst_qcborvalue.cpp b/tests/auto/corelib/serialization/qcborvalue/tst_qcborvalue.cpp
index 1fc4064955..13bf66022d 100644
--- a/tests/auto/corelib/serialization/qcborvalue/tst_qcborvalue.cpp
+++ b/tests/auto/corelib/serialization/qcborvalue/tst_qcborvalue.cpp
@@ -2250,9 +2250,9 @@ void tst_QCborValue::toDiagnosticNotation_data()
if (t == QCborValue::Double)
return QTest::addRow("%sDouble:%g", prefix, v.toDouble());
if (t == QCborValue::ByteArray)
- return QTest::addRow("%sByteArray:%d", prefix, v.toByteArray().size());
+ return QTest::addRow("%sByteArray:%zd", prefix, size_t(v.toByteArray().size()));
if (t == QCborValue::String)
- return QTest::addRow("%sString:%d", prefix, v.toString().size());
+ return QTest::addRow("%sString:%zd", prefix, size_t(v.toString().size()));
QByteArray typeString = me.valueToKey(t);
Q_ASSERT(!typeString.isEmpty());
diff --git a/tests/auto/corelib/text/qbytearray/tst_qbytearray.cpp b/tests/auto/corelib/text/qbytearray/tst_qbytearray.cpp
index 308b60d83b..6ac24d280d 100644
--- a/tests/auto/corelib/text/qbytearray/tst_qbytearray.cpp
+++ b/tests/auto/corelib/text/qbytearray/tst_qbytearray.cpp
@@ -1023,9 +1023,9 @@ void tst_QByteArray::replace()
void tst_QByteArray::replaceWithSpecifiedLength()
{
const char after[] = "zxc\0vbnmqwert";
- int lenAfter = 6;
+ qsizetype lenAfter = 6;
QByteArray ba("abcdefghjk");
- ba.replace(0,2,after,lenAfter);
+ ba.replace(qsizetype(0), 2, after, lenAfter);
const char _expected[] = "zxc\0vbcdefghjk";
QByteArray expected(_expected,sizeof(_expected)-1);
generated by cgit v1.2.3 (git 2.25.1) at 2024-04-19 12:34:32 +0000