diff options
Diffstat (limited to 'src/corelib')
-rw-r--r-- | src/corelib/doc/snippets/qsignalmapper/buttonwidget.cpp | 2 | ||||
-rw-r--r-- | src/corelib/doc/snippets/qsignalmapper/buttonwidget.h | 2 | ||||
-rw-r--r-- | src/corelib/doc/snippets/sharedemployee/employee.h | 4 | ||||
-rw-r--r-- | src/corelib/io/qfilesystemwatcher_fsevents.mm | 12 | ||||
-rw-r--r-- | src/corelib/io/qfilesystemwatcher_fsevents_p.h | 8 | ||||
-rw-r--r-- | src/corelib/io/qsettings_winrt.cpp | 4 | ||||
-rw-r--r-- | src/corelib/itemmodels/qabstractitemmodel.cpp | 2 | ||||
-rw-r--r-- | src/corelib/itemmodels/qabstractitemmodel_p.h | 2 | ||||
-rw-r--r-- | src/corelib/kernel/qsharedmemory_p.h | 2 | ||||
-rw-r--r-- | src/corelib/tools/qtimezoneprivate_tz.cpp | 2 |
10 files changed, 20 insertions, 20 deletions
diff --git a/src/corelib/doc/snippets/qsignalmapper/buttonwidget.cpp b/src/corelib/doc/snippets/qsignalmapper/buttonwidget.cpp index 230be1f524..067853a5f6 100644 --- a/src/corelib/doc/snippets/qsignalmapper/buttonwidget.cpp +++ b/src/corelib/doc/snippets/qsignalmapper/buttonwidget.cpp @@ -43,7 +43,7 @@ #include "buttonwidget.h" //! [0] -ButtonWidget::ButtonWidget(QStringList texts, QWidget *parent) +ButtonWidget::ButtonWidget(const QStringList &texts, QWidget *parent) : QWidget(parent) { signalMapper = new QSignalMapper(this); diff --git a/src/corelib/doc/snippets/qsignalmapper/buttonwidget.h b/src/corelib/doc/snippets/qsignalmapper/buttonwidget.h index a6939603e8..b1803cf203 100644 --- a/src/corelib/doc/snippets/qsignalmapper/buttonwidget.h +++ b/src/corelib/doc/snippets/qsignalmapper/buttonwidget.h @@ -53,7 +53,7 @@ class ButtonWidget : public QWidget Q_OBJECT public: - ButtonWidget(QStringList texts, QWidget *parent = 0); + ButtonWidget(const QStringList &texts, QWidget *parent = 0); signals: void clicked(const QString &text); diff --git a/src/corelib/doc/snippets/sharedemployee/employee.h b/src/corelib/doc/snippets/sharedemployee/employee.h index 9b673dceeb..83f630d299 100644 --- a/src/corelib/doc/snippets/sharedemployee/employee.h +++ b/src/corelib/doc/snippets/sharedemployee/employee.h @@ -63,7 +63,7 @@ class Employee //! [1] Employee() { d = new EmployeeData; } //! [1] //! [2] - Employee(int id, QString name) { + Employee(int id, const QString &name) { d = new EmployeeData; setId(id); setName(name); @@ -77,7 +77,7 @@ class Employee //! [3] void setId(int id) { d->id = id; } //! [3] //! [4] - void setName(QString name) { d->name = name; } + void setName(const QString &name) { d->name = name; } //! [4] //! [5] diff --git a/src/corelib/io/qfilesystemwatcher_fsevents.mm b/src/corelib/io/qfilesystemwatcher_fsevents.mm index 1dc45a7e41..1076b8f5b4 100644 --- a/src/corelib/io/qfilesystemwatcher_fsevents.mm +++ b/src/corelib/io/qfilesystemwatcher_fsevents.mm @@ -283,13 +283,13 @@ void QFseventsFileSystemWatcherEngine::processEvent(ConstFSEventStreamRef stream #endif } -void QFseventsFileSystemWatcherEngine::doEmitFileChanged(const QString path, bool removed) +void QFseventsFileSystemWatcherEngine::doEmitFileChanged(const QString &path, bool removed) { DEBUG() << "emitting fileChanged for" << path << "with removed =" << removed; emit fileChanged(path, removed); } -void QFseventsFileSystemWatcherEngine::doEmitDirectoryChanged(const QString path, bool removed) +void QFseventsFileSystemWatcherEngine::doEmitDirectoryChanged(const QString &path, bool removed) { DEBUG() << "emitting directoryChanged for" << path << "with removed =" << removed; emit directoryChanged(path, removed); @@ -316,10 +316,10 @@ QFseventsFileSystemWatcherEngine::QFseventsFileSystemWatcherEngine(QObject *pare // We cannot use signal-to-signal queued connections, because the // QSignalSpy cannot spot signals fired from other/alien threads. - connect(this, SIGNAL(emitDirectoryChanged(const QString, bool)), - this, SLOT(doEmitDirectoryChanged(const QString, bool)), Qt::QueuedConnection); - connect(this, SIGNAL(emitFileChanged(const QString, bool)), - this, SLOT(doEmitFileChanged(const QString, bool)), Qt::QueuedConnection); + connect(this, SIGNAL(emitDirectoryChanged(QString,bool)), + this, SLOT(doEmitDirectoryChanged(QString,bool)), Qt::QueuedConnection); + connect(this, SIGNAL(emitFileChanged(QString,bool)), + this, SLOT(doEmitFileChanged(QString,bool)), Qt::QueuedConnection); connect(this, SIGNAL(scheduleStreamRestart()), this, SLOT(restartStream()), Qt::QueuedConnection); diff --git a/src/corelib/io/qfilesystemwatcher_fsevents_p.h b/src/corelib/io/qfilesystemwatcher_fsevents_p.h index bd75a0aa32..b4640afc4e 100644 --- a/src/corelib/io/qfilesystemwatcher_fsevents_p.h +++ b/src/corelib/io/qfilesystemwatcher_fsevents_p.h @@ -74,13 +74,13 @@ public: void processEvent(ConstFSEventStreamRef streamRef, size_t numEvents, char **eventPaths, const FSEventStreamEventFlags eventFlags[], const FSEventStreamEventId eventIds[]); Q_SIGNALS: - void emitFileChanged(const QString path, bool removed); - void emitDirectoryChanged(const QString path, bool removed); + void emitFileChanged(const QString &path, bool removed); + void emitDirectoryChanged(const QString &path, bool removed); void scheduleStreamRestart(); private slots: - void doEmitFileChanged(const QString path, bool removed); - void doEmitDirectoryChanged(const QString path, bool removed); + void doEmitFileChanged(const QString &path, bool removed); + void doEmitDirectoryChanged(const QString &path, bool removed); void restartStream(); private: diff --git a/src/corelib/io/qsettings_winrt.cpp b/src/corelib/io/qsettings_winrt.cpp index 8f9d6d3692..bf8b157d00 100644 --- a/src/corelib/io/qsettings_winrt.cpp +++ b/src/corelib/io/qsettings_winrt.cpp @@ -281,7 +281,7 @@ class QWinRTSettingsPrivate : public QSettingsPrivate public: QWinRTSettingsPrivate(QSettings::Scope scope, const QString &organization, const QString &application); - QWinRTSettingsPrivate(QString rKey); + QWinRTSettingsPrivate(const QString &rKey); ~QWinRTSettingsPrivate(); void remove(const QString &uKey); @@ -315,7 +315,7 @@ QWinRTSettingsPrivate::QWinRTSettingsPrivate(QSettings::Scope scope, const QStri init(scope); } -QWinRTSettingsPrivate::QWinRTSettingsPrivate(QString rPath) +QWinRTSettingsPrivate::QWinRTSettingsPrivate(const QString &rPath) : QSettingsPrivate(QSettings::NativeFormat, QSettings::UserScope, rPath, QString()) , writeContainer(0) { diff --git a/src/corelib/itemmodels/qabstractitemmodel.cpp b/src/corelib/itemmodels/qabstractitemmodel.cpp index 213394e4b7..60ac75133c 100644 --- a/src/corelib/itemmodels/qabstractitemmodel.cpp +++ b/src/corelib/itemmodels/qabstractitemmodel.cpp @@ -677,7 +677,7 @@ void QAbstractItemModelPrivate::itemsAboutToBeMoved(const QModelIndex &srcParent column value depending on the value of \a orientation. The indexes may also be moved to a different parent if \a parent differs from the existing parent for the index. */ -void QAbstractItemModelPrivate::movePersistentIndexes(QVector<QPersistentModelIndexData *> indexes, int change, const QModelIndex &parent, Qt::Orientation orientation) +void QAbstractItemModelPrivate::movePersistentIndexes(const QVector<QPersistentModelIndexData *> &indexes, int change, const QModelIndex &parent, Qt::Orientation orientation) { QVector<QPersistentModelIndexData *>::const_iterator it; const QVector<QPersistentModelIndexData *>::const_iterator begin = indexes.constBegin(); diff --git a/src/corelib/itemmodels/qabstractitemmodel_p.h b/src/corelib/itemmodels/qabstractitemmodel_p.h index 1ff758f7ce..075e6a9018 100644 --- a/src/corelib/itemmodels/qabstractitemmodel_p.h +++ b/src/corelib/itemmodels/qabstractitemmodel_p.h @@ -72,7 +72,7 @@ class Q_CORE_EXPORT QAbstractItemModelPrivate : public QObjectPrivate public: QAbstractItemModelPrivate() : QObjectPrivate(), supportedDragActions(-1), roleNames(defaultRoleNames()) {} void removePersistentIndexData(QPersistentModelIndexData *data); - void movePersistentIndexes(QVector<QPersistentModelIndexData *> indexes, int change, const QModelIndex &parent, Qt::Orientation orientation); + void movePersistentIndexes(const QVector<QPersistentModelIndexData *> &indexes, int change, const QModelIndex &parent, Qt::Orientation orientation); void rowsAboutToBeInserted(const QModelIndex &parent, int first, int last); void rowsInserted(const QModelIndex &parent, int first, int last); void rowsAboutToBeRemoved(const QModelIndex &parent, int first, int last); diff --git a/src/corelib/kernel/qsharedmemory_p.h b/src/corelib/kernel/qsharedmemory_p.h index 8c5cf52b9f..0308dde57f 100644 --- a/src/corelib/kernel/qsharedmemory_p.h +++ b/src/corelib/kernel/qsharedmemory_p.h @@ -136,7 +136,7 @@ public: void setErrorString(const QString &function); #ifndef QT_NO_SYSTEMSEMAPHORE - bool tryLocker(QSharedMemoryLocker *locker, const QString function) { + bool tryLocker(QSharedMemoryLocker *locker, const QString &function) { if (!locker->lock()) { errorString = QSharedMemory::tr("%1: unable to lock").arg(function); error = QSharedMemory::LockError; diff --git a/src/corelib/tools/qtimezoneprivate_tz.cpp b/src/corelib/tools/qtimezoneprivate_tz.cpp index 74499bf52f..0d8ae3b47f 100644 --- a/src/corelib/tools/qtimezoneprivate_tz.cpp +++ b/src/corelib/tools/qtimezoneprivate_tz.cpp @@ -343,7 +343,7 @@ static QDate calculateDowDate(int year, int month, int dayOfWeek, int week) return date; } -static QDate calculatePosixDate(const QByteArray dateRule, int year) +static QDate calculatePosixDate(const QByteArray &dateRule, int year) { // Can start with M, J, or a digit if (dateRule.at(0) == 'M') { |