1 files changed, 61 insertions, 9 deletions

diff --git a/src/tools/uic/python/pythonwriteimports.cpp b/src/tools/uic/python/pythonwriteimports.cpp
index 303615f77b..95e039e6f0 100644
--- a/src/tools/uic/python/pythonwriteimports.cpp
+++ b/src/tools/uic/python/pythonwriteimports.cpp
@@ -29,6 +29,7 @@
 #include "pythonwriteimports.h"
 
 #include <customwidgetsinfo.h>
+#include <option.h>
 #include <uic.h>
 
 #include <ui4.h>
@@ -38,14 +39,28 @@
 QT_BEGIN_NAMESPACE
 
 static const char *standardImports =
-R"I(from PySide2.QtCore import (QCoreApplication, QMetaObject, QObject, QPoint,
-    QRect, QSize, QUrl, Qt)
-from PySide2.QtGui import (QBrush, QColor, QConicalGradient, QFont,
-    QFontDatabase, QIcon, QLinearGradient, QPalette, QPainter, QPixmap,
-    QRadialGradient)
+R"I(from PySide2.QtCore import (QCoreApplication, QDate, QDateTime, QMetaObject,
+    QObject, QPoint, QRect, QSize, QTime, QUrl, Qt)
+from PySide2.QtGui import (QBrush, QColor, QConicalGradient, QCursor, QFont,
+    QFontDatabase, QIcon, QKeySequence, QLinearGradient, QPalette, QPainter,
+    QPixmap, QRadialGradient)
 from PySide2.QtWidgets import *
 )I";
 
+// Change the name of a qrc file "dir/foo.qrc" file to the Python
+// module name "foo_rc" according to project conventions.
+static QString pythonResource(QString resource)
+{
+    const int lastSlash = resource.lastIndexOf(QLatin1Char('/'));
+    if (lastSlash != -1)
+        resource.remove(0, lastSlash + 1);
+    if (resource.endsWith(QLatin1String(".qrc"))) {
+        resource.chop(4);
+        resource.append(QLatin1String("_rc"));
+    }
+    return resource;
+}
+
 namespace Python {
 
 WriteImports::WriteImports(Uic *uic) : m_uic(uic)
@@ -60,6 +75,23 @@ void WriteImports::acceptUI(DomUI *node)
         TreeWalker::acceptCustomWidgets(customWidgets);
         output << '\n';
     }
+
+    if (auto resources = node->elementResources()) {
+        const auto includes = resources->elementInclude();
+        for (auto include : includes) {
+            if (include->hasAttributeLocation())
+                writeImport(pythonResource(include->attributeLocation()));
+        }
+        output << '\n';
+    }
+}
+
+void WriteImports::writeImport(const QString &module)
+{
+
+    if (m_uic->option().fromImports)
+        m_uic->output() << "from  . ";
+    m_uic->output() << "import " << module << '\n';
 }
 
 QString WriteImports::qtModuleOf(const DomCustomWidget *node) const
@@ -82,11 +114,31 @@ void WriteImports::acceptCustomWidget(DomCustomWidget *node)
     const auto &className = node->elementClass();
     if (className.contains(QLatin1String("::")))
         return; // Exclude namespaced names (just to make tests pass).
-    const QString &qtModule = qtModuleOf(node);
+    const QString &importModule = qtModuleOf(node);
     auto &output = m_uic->output();
-    if (!qtModule.isEmpty())
-        output << "from PySide2." << qtModule << ' ';
-    output << "import " << className << '\n';
+    // For starting importing PySide2 modules
+    if (!importModule.isEmpty()) {
+        output << "from ";
+        if (importModule.startsWith(QLatin1String("Qt")))
+            output << "PySide2.";
+        output << importModule;
+        if (!className.isEmpty())
+            output << " import " << className << "\n\n";
+    } else {
+        // When the elementHeader is not set, we know it's the continuation
+        // of a PySide2 import or a normal import of another module.
+        if (!node->elementHeader() || node->elementHeader()->text().isEmpty()) {
+            output << "import " << className << '\n';
+        } else { // When we do have elementHeader, we know it's a relative import.
+            QString modulePath = node->elementHeader()->text();
+            // Replace the '/' by '.'
+            modulePath.replace(QLatin1Char('/'), QLatin1Char('.'));
+            // '.h' is added by default on headers for <customwidget>
+            if (modulePath.endsWith(QLatin1String(".h")))
+                modulePath.chop(2);
+            output << "from " << modulePath << " import " << className << '\n';
+        }
+    }
 }
 
 } // namespace Python