2 files changed, 130 insertions, 23 deletions

diff --git a/tests/auto/corelib/io/qprocess/testDetached/main.cpp b/tests/auto/corelib/io/qprocess/testDetached/main.cpp
index 702cabe873..c10e32d584 100644
--- a/tests/auto/corelib/io/qprocess/testDetached/main.cpp
+++ b/tests/auto/corelib/io/qprocess/testDetached/main.cpp
@@ -40,32 +40,89 @@
 #include <windows.h>
 #endif
 
+static void writeStuff(QFile &f)
+{
+    f.write(QDir::currentPath().toUtf8());
+    f.putChar('\n');
+#if defined(Q_OS_UNIX)
+    f.write(QByteArray::number(quint64(getpid())));
+#elif defined(Q_OS_WIN)
+    f.write(QByteArray::number(quint64(GetCurrentProcessId())));
+#endif
+    f.putChar('\n');
+    f.write(qgetenv("tst_QProcess"));
+    f.putChar('\n');
+}
+
+struct Args
+{
+    int exitCode = 0;
+    QByteArray errorMessage;
+    QString fileName;
+    FILE *channel = nullptr;
+    QByteArray channelName;
+};
+
+static Args parseArguments(const QStringList &args)
+{
+    Args result;
+    if (args.count() < 2) {
+        result.exitCode = 128;
+        result.errorMessage = "Usage: testDetached [--out-channel={stdout|stderr}] filename.txt\n";
+        return result;
+    }
+    for (const QString &arg : args) {
+        if (arg.startsWith("--")) {
+            if (!arg.startsWith("--out-channel=")) {
+                result.exitCode = 2;
+                result.errorMessage = "Unknown argument " + arg.toLocal8Bit();
+                return result;
+            }
+            result.channelName = arg.mid(14).toLocal8Bit();
+            if (result.channelName == "stdout") {
+                result.channel = stdout;
+            } else if (result.channelName == "stderr") {
+                result.channel = stderr;
+            } else {
+                result.exitCode = 3;
+                result.errorMessage = "Unknown channel " + result.channelName;
+                return result;
+            }
+        } else {
+            result.fileName = arg;
+        }
+    }
+    return result;
+}
+
 int main(int argc, char **argv)
 {
     QCoreApplication app(argc, argv);
 
-    QStringList args = app.arguments();
-    if (args.count() != 2) {
-        fprintf(stderr, "Usage: testDetached filename.txt\n");
-        return 128;
+    const Args args = parseArguments(app.arguments());
+    if (args.exitCode) {
+        fprintf(stderr, "testDetached: %s\n", args.errorMessage.constData());
+        return args.exitCode;
     }
 
-    QFile f(args.at(1));
+    if (args.channel) {
+        QFile channel;
+        if (!channel.open(args.channel, QIODevice::WriteOnly | QIODevice::Text)) {
+            fprintf(stderr, "Cannot open channel %s for writing: %s\n",
+                    qPrintable(args.channelName), qPrintable(channel.errorString()));
+            return 4;
+        }
+        writeStuff(channel);
+    }
+
+    QFile f(args.fileName);
     if (!f.open(QIODevice::WriteOnly | QIODevice::Truncate | QIODevice::Text)) {
         fprintf(stderr, "Cannot open %s for writing: %s\n",
                 qPrintable(f.fileName()), qPrintable(f.errorString()));
         return 1;
     }
 
-    f.write(QDir::currentPath().toUtf8());
-    f.putChar('\n');
-#if defined(Q_OS_UNIX)
-    f.write(QByteArray::number(quint64(getpid())));
-#elif defined(Q_OS_WIN)
-    f.write(QByteArray::number(quint64(GetCurrentProcessId())));
-#endif
-    f.putChar('\n');
-
+    writeStuff(f);
     f.close();
 
     return 0;
diff --git a/tests/auto/corelib/io/qprocess/tst_qprocess.cpp b/tests/auto/corelib/io/qprocess/tst_qprocess.cpp
index f4d6d5cb40..de6eb28503 100644
--- a/tests/auto/corelib/io/qprocess/tst_qprocess.cpp
+++ b/tests/auto/corelib/io/qprocess/tst_qprocess.cpp
@@ -127,7 +127,8 @@ private slots:
     void systemEnvironment();
     void lockupsInStartDetached();
     void waitForReadyReadForNonexistantProcess();
-    void detachedWorkingDirectoryAndPid();
+    void detachedProcessParameters_data();
+    void detachedProcessParameters();
     void startFinishStartFinish();
     void invalidProgramString_data();
     void invalidProgramString();
@@ -2072,21 +2073,54 @@ void tst_QProcess::fileWriterProcess()
     } while (stopWatch.elapsed() < 3000);
 }
 
-void tst_QProcess::detachedWorkingDirectoryAndPid()
+void tst_QProcess::detachedProcessParameters_data()
 {
+    QTest::addColumn<QString>("outChannel");
+    QTest::newRow("none") << QString();
+    QTest::newRow("stdout") << QString("stdout");
+    QTest::newRow("stderr") << QString("stderr");
+}
+
+void tst_QProcess::detachedProcessParameters()
+{
+    QFETCH(QString, outChannel);
     qint64 pid;
 
     QFile infoFile(m_temporaryDir.path() + QLatin1String("/detachedinfo.txt"));
     if (infoFile.exists())
         QVERIFY(infoFile.remove());
+    QFile channelFile(m_temporaryDir.path() + QLatin1String("detachedinfo2.txt"));
+    if (channelFile.exists())
+        QVERIFY(channelFile.remove());
 
     QString workingDir = QDir::currentPath() + "/testDetached";
 
     QVERIFY(QFile::exists(workingDir));
 
-    QStringList args;
-    args << infoFile.fileName();
-    QVERIFY(QProcess::startDetached(QDir::currentPath() + QLatin1String("/testDetached/testDetached"), args, workingDir, &pid));
+    QVERIFY(qgetenv("tst_QProcess").isEmpty());
+    QByteArray envVarValue("foobarbaz");
+    QProcessEnvironment environment = QProcessEnvironment::systemEnvironment();
+    environment.insert(QStringLiteral("tst_QProcess"), QString::fromUtf8(envVarValue));
+
+    QProcess process;
+    process.setProgram(QDir::currentPath() + QLatin1String("/testDetached/testDetached"));
+#ifdef Q_OS_WIN
+    int modifierCalls = 0;
+    process.setCreateProcessArgumentsModifier(
+        [&modifierCalls] (QProcess::CreateProcessArguments *) { modifierCalls++; });
+#endif
+    QStringList args(infoFile.fileName());
+    if (!outChannel.isEmpty()) {
+        args << QStringLiteral("--out-channel=") + outChannel;
+        if (outChannel == "stdout")
+            process.setStandardOutputFile(channelFile.fileName());
+        else if (outChannel == "stderr")
+            process.setStandardErrorFile(channelFile.fileName());
+    }
+    process.setArguments(args);
+    process.setWorkingDirectory(workingDir);
+    process.setProcessEnvironment(environment);
+    QVERIFY(process.startDetached(&pid));
 
     QFileInfo fi(infoFile);
     fi.setCaching(false);
@@ -2097,19 +2131,35 @@ void tst_QProcess::detachedWorkingDirectoryAndPid()
     }
 
     QVERIFY(infoFile.open(QIODevice::ReadOnly | QIODevice::Text));
-    QString actualWorkingDir = QString::fromUtf8(infoFile.readLine());
-    actualWorkingDir.chop(1); // strip off newline
-    QByteArray processIdString = infoFile.readLine();
-    processIdString.chop(1);
+    QString actualWorkingDir = QString::fromUtf8(infoFile.readLine()).trimmed();
+    QByteArray processIdString = infoFile.readLine().trimmed();
+    QByteArray actualEnvVarValue = infoFile.readLine().trimmed();
+    QByteArray infoFileContent;
+    if (!outChannel.isEmpty()) {
+        infoFile.seek(0);
+        infoFileContent = infoFile.readAll();
+    }
     infoFile.close();
     infoFile.remove();
 
+    if (!outChannel.isEmpty()) {
+        QVERIFY(channelFile.open(QIODevice::ReadOnly | QIODevice::Text));
+        QByteArray channelContent = channelFile.readAll();
+        channelFile.close();
+        channelFile.remove();
+        QCOMPARE(channelContent, infoFileContent);
+    }
+
     bool ok = false;
     qint64 actualPid = processIdString.toLongLong(&ok);
     QVERIFY(ok);
 
     QCOMPARE(actualWorkingDir, workingDir);
     QCOMPARE(actualPid, pid);
+    QCOMPARE(actualEnvVarValue, envVarValue);
+#ifdef Q_OS_WIN
+    QCOMPARE(modifierCalls, 1);
+#endif
 }
 
 void tst_QProcess::switchReadChannels()