summaryrefslogtreecommitdiffstats
path: root/bin
Commit message (Collapse)AuthorAgeFilesLines
...
* move creation of module version header to qt_module_headersOswald Buddenhagen2012-06-191-44/+0
| | | | | Change-Id: I650b495ec1789eb03b31d796f9f475ba01aab2d3 Reviewed-by: Joerg Bornemann <joerg.bornemann@nokia.com>
* create module version headers in build dir, not source dirOswald Buddenhagen2012-06-191-1/+2
| | | | | Change-Id: I07bf4dbeba2d35284ecf55542f9cd457b2e49b80 Reviewed-by: Joerg Bornemann <joerg.bornemann@nokia.com>
* make %inject_headers a per-module config valueOswald Buddenhagen2012-06-191-2/+2
| | | | | | | | it's module-specific. on the way, fix it to actually support multiple files. Change-Id: I796b0e98e38a54754022e0e2fa48cecb54d06ff4 Reviewed-by: Joerg Bornemann <joerg.bornemann@nokia.com>
* automatically add the module version headers to %classnamesOswald Buddenhagen2012-06-191-0/+2
| | | | | Change-Id: I7706a0d54e704320e9e1e480b387e46417739ccf Reviewed-by: Joerg Bornemann <joerg.bornemann@nokia.com>
* make sure that forwards for injected headers are not garbage-collectedOswald Buddenhagen2012-06-191-1/+16
| | | | | | | | | qmake-generated version headers don't exist yet at the time syncqt runs, so the forwarding headers would be deleted - just to be re-created a moment later, thus changing the timestamp for no good reason. Change-Id: I1b4c2f05f57c2315adf4b8dd726ea413ede1be5b Reviewed-by: Joerg Bornemann <joerg.bornemann@nokia.com>
* fix status output for generated headersOswald Buddenhagen2012-06-191-3/+9
| | | | | Change-Id: I92c250037eb1b1838998cddbaea6ca065153e86e Reviewed-by: Joerg Bornemann <joerg.bornemann@nokia.com>
* generate fwd-pris in qt_module_config, not in syncqtOswald Buddenhagen2012-06-191-1/+1
| | | | | | | | the forwarding pri is loaded even if it was still created by syncqt, so a top-level qmake -r will still catch it even in the future. Change-Id: I2e4b556cd06eb88be9ee378662a2e6e1bff67ad7 Reviewed-by: Joerg Bornemann <joerg.bornemann@nokia.com>
* write forwarding pris to $outpath/mkspecs/modulesOswald Buddenhagen2012-06-191-4/+1
| | | | | | | | | | this makes qmake find them automatically now. consequently, also do not write QMAKE_EXTRA_MODULE_FORWARDS to .qmake.cache. still write the cache file, though, as otherwise a top-level cache would mess up the module root detection. Change-Id: I998b94fcc73ca3f8bf1af09a394ff8d40cf1fb76 Reviewed-by: Joerg Bornemann <joerg.bornemann@nokia.com>
* move $QTDIR handling out of syncqtOswald Buddenhagen2012-06-191-6/+1
| | | | | | | | | instead, always pass -qtdir (which, btw, is a slight misnomer - it should be -qtdatadir) with the correct path. this centralizes the relevant logic in default_pre.prf. Change-Id: Icc788d3f3e5f7b68b444e63e181efdea3b4ef160 Reviewed-by: Marius Storm-Olsen <marius.storm-olsen@nokia.com>
* rewrite fixPaths()Oswald Buddenhagen2012-06-191-41/+12
| | | | | | | | | now the phonon paths are actually normalized. just relying on File::Spec for the path relativization, so the code is much shorter. Change-Id: I69d6bac73e366ed0f754e1282a375871ce5559c4 Reviewed-by: Marius Storm-Olsen <marius.storm-olsen@nokia.com>
* remove dead variableOswald Buddenhagen2012-06-191-1/+0
| | | | | Change-Id: Ic37c2a0da6346f044df10c7d8b5ee1a95efcc29c Reviewed-by: Marius Storm-Olsen <marius.storm-olsen@nokia.com>
* don't use abs_path on input argumentsOswald Buddenhagen2012-06-191-7/+5
| | | | | | | | | for one, the input paths are already absolute. second, if a path does not exists, abs_path will fail, which makes the fallback code which tries to create them rather pointless. Change-Id: Ie56ff09313e48e82e8bc8e8f06eca384644de464 Reviewed-by: Marius Storm-Olsen <marius.storm-olsen@nokia.com>
* make syncqt work with MSys Perl and MSVCJoerg Bornemann2012-06-011-14/+34
| | | | | | | | | | | | | | | | | | | | | | The common root dir detection was broken, because of an inconsistent root drive path style: <srcbase> = /c/dev/qt/5.0/qtbase <outbase> = C:/dev/qt/5.0/qtbase Now we don't need ActivePerl anymore. The Perl that comes with msysgit is enough. After every Perl function call that returns a file path we need to normalize it to bring it into a form that can be used by - Perl functions that take a path as parameter, - C++ sources as include file path, - qmake's .pro files as include file path. Task-number: QTBUG-25912 Change-Id: If1cf56cc7246a9d6535cd3867222f225d1617712 Reviewed-by: Thiago Macieira <thiago.macieira@intel.com> Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
* Fix qpa legacy headers installationGirish Ramakrishnan2012-05-091-7/+7
| | | | | | | | | | | | | | | | syncqt is run twice when using the top level configure (as in the CI system). The pri_install_files and pri_install_pfiles variables are not populated if the file already exists when generating the compatibility headers. Therefore, headers.pri ends up with different content in each syncqt run. In the first run, the compatibility headers are part of SYNCQT.HEADER_FILES. In the second run, they are not part of it since the header files already exist. Change-Id: I4908fb934a639a3c9f6af1796d56a40fd4df2d50 Reviewed-by: Thiago Macieira <thiago.macieira@intel.com> Reviewed-by: Sergio Ahumada <sergio.ahumada@nokia.com>
* Fix qpa files installationGirish Ramakrishnan2012-05-081-0/+6
| | | | | | | qpa header files were not installed under qpa/. Change-Id: I243c3a7e83a342f7485791a1a29b65c9a8f25d6b Reviewed-by: Marius Storm-Olsen <marius.storm-olsen@nokia.com>
* Expose QPA API under qpa/*Girish Ramakrishnan2012-05-071-2/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The main reasons for doing this are: 1. _qpa.h end up in the master QtGui include file. QtGui is meant for userland applications. qpa code is neither binary nor source compatible. Inadvertant use of QPA api makes the user code binary-incompatible. 2. syncqt creates forwarding headers for non-private header files. This gives people the impression that this is public API. As discussed on the mailing list, even though QPA api is internal and subject to change, it needs to treated differently from private headers since they will be used by in-qtbase and out-of-qtbase plugins. This commit does the following: 1. The _qpa in QPA header files is dropped. 2. syncqt now treats any file with qplatform prefix as a special file and moves it to qpa/ directory. The recommended way of using QPA API in plugins is: #include <qpa/qplatformfoo.h>. This allows the user include QPA API from multiple modules (for example, qplatformfoo might be in QtPrintSupport) 3. The user needs to explicitly add QT += <module>-private to get access to the qpa api. 4. Creates compat headers for the olden style qplatformfoo_qpa.h and QPlatformFoo includes. This commit does not change the cpp filenames. This requires a more careful merging of existing non qpa cpp files and existing cpp files on a case by case basis. This can be done at anytime. The following files are not renamed as part of this changed but will be fixed as part of a future change: src/gui/kernel/qgenericpluginfactory_qpa.h src/gui/kernel/qgenericplugin_qpa.h src/gui/kernel/qwindowsysteminterface_qpa.h files were renamed using for x in `find . -name "qplatform*_qpa.h"`; do git mv $x "${x/_qpa.h/.h}"; done for x in `find . -name "qplatform*_qpa_p.h"`; do git mv $x "${x/_qpa_p.h/_p.h}"; done includes were renamed using script for file in `find . -name "*.h" -or -name "*.cpp" -or -name "*.mm"`; do sed -i -e 's,.*#.*include.*<\(Qt.*/\)\?\(QPlatform.*\)>,#include <qpa/\L\2.h>,g' \ -e 's,.*#.*include.*"\(Qt.*/\)\?\(QPlatform.*\)",#include <qpa/\L\2.h>,g' \ -e 's,.*#.*include.* "\(qplatform.*\)_qpa.h",#include <qpa/\L\1.h>,g' \ -e 's,.*#.*include.*"\(qplatform.*\)_qpa_p.h",#include <qpa/\L\1_p.h>,g' \ -e 's,.*#.*include.*<\(Qt.*/\|Qt.*/private/\|private/\)\?\(qplatform.*\)_qpa\(.*\)>,#include <qpa/\2\3>,g' \ -e 's,.*#.*include.*"\(Qt.*/\|Qt.*/private/\|private/\)\?\(qplatform.*\)_qpa\(.*\)",#include <qpa/\2\3>,g' \ $file done Change-Id: I04a350314a45746e3911f54b3b21ad03315afb67 Reviewed-by: Morten Johan Sørvig <morten.sorvig@nokia.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com> Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com> Reviewed-by: Sean Harmer <sean.harmer@kdab.com> Reviewed-by: Lars Knoll <lars.knoll@nokia.com> Reviewed-by: Gunnar Sletta <gunnar.sletta@nokia.com>
* Ignore moduledir/doc in syncqtLars Knoll2012-04-171-0/+3
| | | | | | | | | | | | When modularizing our documentation, module level documentation is supposed to go into a doc subfolder in the modules sources. Since this folder also contains header files (snippets), we need to ignore it in syncqt. Change-Id: If8159816b042a1a6c810eaa0b6dbd99bf58d8ffa Reviewed-by: Casper van Donderen <casper.vandonderen@nokia.com> Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
* Fixed syncqt to ignore all lines that define Qt namespaceDenis Dzyubenko2012-04-111-1/+1
| | | | | | | | | | | That includes non-standard macroses for QtAddOns, e.g. for QtJsonDb addon the macro looks like QT_BEGIN_NAMESPACE_JSONDB - by default syncqt doesn't recognize the macro and concantenates it with the next line in the header file, which breaks forward include generation if that next line is the class definition. Change-Id: Ia269f8a091113e4951d6a2615ef392b21bd5e3a3 Reviewed-by: Marius Storm-Olsen <marius.storm-olsen@nokia.com>
* Fix qtmodule-configtests to honor error codesGirish Ramakrishnan2012-03-081-10/+12
| | | | | | | The test is marked as fail if qmake or make fails. Change-Id: I565c68af4a9271d7aa36fb592ac399aa728ba4d8 Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
* Report failure to open deprecated header fileMatthew Vogt2012-02-231-2/+2
| | | | | | | | | If a deprecated header file is not writable, report the error message. The existing error message statement is not processed due to an operator precedence issue. Change-Id: Ifb2d4e234c64e560d05c021c621966bce19ce215 Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
* Ensure the directory exists to receive a deprecated header.Matthew Vogt2012-02-201-0/+3
| | | | | | | | | When creating a deprecated header, create the directory it will be located in, if it does not yet exist. Change-Id: Id0ac7327e7dfe5b3e34b431c7bc3844b72251a3d Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com> Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
* make locateSyncProfile() a "tad" less convolutedOswald Buddenhagen2012-02-101-13/+5
| | | | | | Change-Id: I261b6c6b42bed576edb8a1d8420da19d34bd87a1 Reviewed-by: Marius Storm-Olsen <marius.storm-olsen@nokia.com> Reviewed-by: Joerg Bornemann <joerg.bornemann@nokia.com>
* Move QtConcurrent into its own moduleLars Knoll2012-02-051-0/+1
| | | | | | | Task-number: QTBUG-20892 Change-Id: I614500aafb6428915509983608bbb0ade4e4f016 Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
* Revert "Put the generated <module>version.h into build tree"Bradley T. Hughes2012-02-011-22/+5
| | | | | | | | | After discussion with Liang, I'm reverting it as he requested. This change put every header into the SYNCQT.HEADER_FILES twice for in-source builds, and the qtMODULEversion.h header did not include a path component. This reverts commit 2fbc45b58bba860abf67fb28aa1319c9f4ededaf Change-Id: Ie84cef19193ce5e49072f1f67a41140d9d2673b8 Reviewed-by: Liang Qi <liang.qi@nokia.com>
* Remove Symbian specific code from qtbase.Xizhi Zhu2012-01-319-1219/+0
| | | | | Change-Id: I27d37d914b71e1e43c94e2a975ffec49e1ecd456 Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
* Remove "All rights reserved" line from license headers.Jason McDonald2012-01-3010-10/+10
| | | | | | | | | | As in the past, to avoid rewriting various autotests that contain line-number information, an extra blank line has been inserted at the end of the license text to ensure that this commit does not change the total number of lines in the license header. Change-Id: I311e001373776812699d6efc045b5f742890c689 Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
* Put the generated <module>version.h into build treeLiang Qi2012-01-281-5/+22
| | | | | | | | | It was put in source tree before. Task-number: QTBUG-20439 Change-Id: Ib52d9c2e83ae375aad259ddc74138bbc728b3ed0 Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@nokia.com> Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
* Added $publicclassregexp variable to sync.profileDenis Dzyubenko2012-01-271-3/+8
| | | | | | | | | | | | $publicclassregexp specifies the prefix for Qt classes in a qt5 module. For example in QtJsonDb all classes have "JsonDb" prefix and forward include headers were not generated properly - e.g. "jsondb-client.h" was generated in the include folder, but "JsonDbClient" (which matches class name) was not. Change-Id: I6b57a799d926254e2ab3fd00fa6e38f95b8eb96c Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@nokia.com> Reviewed-by: Marius Storm-Olsen <marius.storm-olsen@nokia.com> Reviewed-by: Prasanth Ullattil <prasanth.ullattil@nokia.com>
* remove bogus commentOswald Buddenhagen2012-01-271-4/+0
| | | | | | | Change-Id: Ibd2d974ac46f80953f628e8d7c93e742e4c8eb23 Reviewed-by: Robin Burchell <robin+qt@viroteck.net> Reviewed-by: Jonas Gastal <jgastal@profusion.mobi> Reviewed-by: Marius Storm-Olsen <marius.storm-olsen@nokia.com>
* delete handling of dead -base-dir argumentOswald Buddenhagen2012-01-271-4/+0
| | | | | Change-Id: I4f69ea213f996f99d2ad8b00efbaf85882e59e27 Reviewed-by: Marius Storm-Olsen <marius.storm-olsen@nokia.com>
* fix grammar in error messageOswald Buddenhagen2012-01-261-1/+1
| | | | | | Change-Id: I3fe4e0fa6da1467a4572e7f1dec1be7294632e34 Reviewed-by: Jonas Gastal <jgastal@profusion.mobi> Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
* use warnings instead of -wOswald Buddenhagen2012-01-261-1/+2
| | | | | | | | that way invocation via perl (c.f. syncqt.bat) does not need options. Change-Id: I5d8e0d1f0ffe1b7cf280fe97d4f70968a3dbbb22 Reviewed-by: Giuseppe D'Angelo <dangelog@gmail.com> Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
* Remove use of QT_MODULE from libraryGunnar Sletta2012-01-251-8/+0
| | | | | | | | | | These defines were there to aid in the commercial licensing scheme we used long ago, and are no longer needed. Keep a QT_MODULE(x) define so other modules continue compiling. Change-Id: I8fd76cd5270df8f14aee746b6cf32ebf7c23fec7 Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
* Fixed qtmodule-configtests on Windows.Friedemann Kleint2012-01-231-32/+72
| | | | | | | | | | | | | | open() to "|-" and "-|" are unsupported on Windows (see `perldoc perlport'), so don't do that. Let the tests write a 'config.log' file which contains the output of the test commands. Brings back the part fixing the pipe logic from commit f865dc1ae44c88f6965acd09bafb01829c35447b which was reverted. Change-Id: I5060a0885702d925001b98f2d4e84743d6ff226e Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
* Update contact information in license headers.Jason McDonald2012-01-2310-10/+10
| | | | | | | Replace Nokia contact email address with Qt Project website. Change-Id: I431bbbf76d7c27d8b502f87947675c116994c415 Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
* Revert "Fixed qtmodule-configtests on Windows"Kalle Lehtonen2012-01-131-53/+35
| | | | | | | This reverts commit bb4caf3c4937418ca0e33d60cf0b25d6cfc3ea95 Change-Id: I25a9e45c9fa0953bdfe1bc112bf45341802c020d Reviewed-by: Jyri Tahtela <jyri.tahtela@nokia.com>
* Fixed qtmodule-configtests on WindowsFriedemann Kleint2012-01-121-35/+53
| | | | | | | | | | | | open to "|-" and "-|" are unsupported on Windows (see `perldoc perlport'), so don't do that. Rather than parsing the output of make to decide if a config test is skipped, use a looser definition: it is skipped if qmake and make both succeed, but no binary is created. Change-Id: Idab7266888e9c934aa7b5c1c6ac5930439681107 Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
* Update copyright year in license headers.Jason McDonald2012-01-0510-10/+10
| | | | | Change-Id: I02f2c620296fcd91d4967d58767ea33fc4e1e7dc Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
* fixqt4headers: Add QtCore to folders (for moved item models).Friedemann Kleint2011-12-201-0/+1
| | | | | Change-Id: I71f805c618a888e654207fb29f68769f9d90db9b Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
* fixqt4headers: Support renaming from QtDeclarative to QtQuickKent Hansen2011-12-071-0/+8
| | | | | | | | | | | | | QtDeclarative was recently split into two modules, with the QtQuick(2)-specific API moved to QtQuick. While strictly speaking the old API wasn't "Qt 4", it's more convenient to modify this script than to create a separate one. For example, "QtDeclarative/qquickitem.h" will now be changed to "QtQuick/qquickitem.h". Change-Id: I50b32d60cfd21e3c49ee4222fbd6116f80eac25b Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
* syncqt: fixed QT_MODULE_BASE when build path != install pathRohan McGovern2011-12-061-1/+1
| | | | | | | | | | | | | | | QT_MODULE_BASE is exclusively used to refer to the top-level source directory of a module. However, in non-developer-build mode (used only when the build path is not equal to the install path), syncqt would incorrectly set the value of QT_MODULE_BASE to the build directory. This caused all $$QT.<module>.sources variables to point to the wrong place. Make it always point to the source directory. Change-Id: I401cf000f9e3a4ab97d68db40330bb98aec25a9a Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@nokia.com> Reviewed-by: Marius Storm-Olsen <marius.storm-olsen@nokia.com>
* syncqt: Create deprecated headers that work with MSVCKent Hansen2011-12-021-1/+5
| | | | | | | | | MSVC doesn't understand the #warning directive; use #pragma message instead. Change-Id: I42fe43269f5a84559a983932737c9eeb6b74b1ff Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com> Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
* Add deprecated headers support to syncqtKent Hansen2011-11-291-1/+59
| | | | | | | | | | | | | | | | | | | | | | | | | | | When renaming classes, or when moving classes from one module to another, it's useful to have a simple way of supporting the old API/location for some time. To this end, syncqt shall now recognize a "deprecatedheaders" section in sync.profile. It looks like this: %deprecatedheaders = ( "QtDeclarative" => { "qquickcanvas.h" => "QtQuick2/qquickcanvas.h", "qquickitem.h" => "QtQuick2/qquickitem.h", "QQuickCanvas" => "QtQuick2/QQuickCanvas", "QQuickItem" => "QtQuick2/QQuickItem", } ); In the above example, syncqt would generate a header called qquickcanvas.h for the QtDeclarative module; when included, this header will issue a warning and include <QtQuick2/qquickcanvas.h>. And so on, for the other entries. Deprecated headers are installed along with the module's normal headers. Change-Id: Ie2518b42275c2b2ff44216f07d376ccf5be6dc45 Reviewed-by: Marius Storm-Olsen <marius.storm-olsen@nokia.com>
* syncqt: Don't generate deprecated forwarding headers anymoreTor Arne Vestbø2011-11-241-28/+0
| | | | | | | | | The forwarding headers in 'include/Qt' were deprectated in Qt 4. This is Qt 5, so time to remove them. Change-Id: I4bf3797475b91f58af1761ed4165b552613299b3 Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@nokia.com> Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
* fixqt4headers.pl: Add --strip-module option.Friedemann Kleint2011-11-221-97/+62
| | | | | | | | | | | | - Add --strip-module option to strip the module name for portable code - Use GetOpt::Long - Streamline, remove need for rewinding the file - Streamline output, just report affected classes and introduce --verbose for normal operation. Change-Id: I8643a5f53d4ed8ce2ae44721164cbdba1aad8b46 Reviewed-by: Harald Fernengel <harald.fernengel@nokia.com>
* Fix config tests for modules on Mac OS XTor Arne Vestbø2011-11-141-1/+1
| | | | | | | | | We look for a regular binary, but Mac OS X produces application bundles by default. Instead of looking for an app bundle as well, we unify things a bit by disabling app bundles instead. Change-Id: I5eb173d98e893e616f23b91f13282cf95ef4f56a Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
* Add a new handler to syncqt for explicitly dealing with special case headersKevin Simons2011-11-141-3/+17
| | | | | | Change-Id: I83b26fc88aee0052502c0a4d385ea97f8c933c66 Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@nokia.com> Reviewed-by: Marius Storm-Olsen <marius.storm-olsen@nokia.com>
* Replace fixqt4headers shell scriptHarald Fernengel2011-11-112-23/+195
| | | | | | | | | Use a perl script with a slightly better scalability. No more quadratic behavior, takes about 10 seconds (instead of 5 hours) on my machine to fix all QtCreator headers Change-Id: Ic7d00c28aec390a1da27a969ece5d8102674e919 Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
* Fix regular expression when replacing headersHarald Fernengel2011-11-031-1/+1
| | | | | | | | Use non-greedy capturing where it makes sense, also keep the user's whitespace indentation in his include statements Change-Id: Iff2b5dabf443529292e943ae69427bd15e702bf9 Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
* Teach syncqt to handle multiple %moduleheaders directoriesTor Arne Vestbø2011-10-201-135/+142
| | | | | | | | Each directory is separated by a ';'. The syntax was chosen over the regular perl [] syntax as ';' was used already in other places. Change-Id: I7a07a1facb7c08d7a9de6ec45ad57f6057cb0150 Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@nokia.com>