summaryrefslogtreecommitdiffstats
path: root/tests
Commit message (Collapse)AuthorAgeFilesLines
* Clean-up a macro for CocoaMorten Sorvig2011-10-1011-2024/+40
| | | | | | | | | Remove the usage of Q_MAC_USE_COCOA and Carbon code paths. Change-Id: Ib569ad8c6d9ffe258f454b3c3b06e95294a10112 Reviewed-on: http://codereview.qt-project.org/5100 Reviewed-by: Morten Johan Sørvig <morten.sorvig@nokia.com> Sanity-Review: Morten Johan Sørvig <morten.sorvig@nokia.com>
* Added Orientation API to QScreen and QWindow.Samuel Rødal2011-10-072-0/+175
| | | | | | | | | | | | QScreen now has a primary and current orientation, and a QWindow can set its orientation as well. The current screen orientation is just a hint to the application. Change-Id: I4635982cfac2d16634d4edd5c6ab78e9d0ac55a4 Reviewed-on: http://codereview.qt-project.org/5988 Reviewed-by: Paul Olav Tvete <paul.tvete@nokia.com> Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
* Improve QMenu test coverage for Mac and WinCE.Jason McDonald2011-10-071-1/+1
| | | | | | | | | | Add a couple of previously excluded lines of code that should work for all platforms. Change-Id: I5f0b5365060a91cb708a3143b28f7de703fc419e Reviewed-on: http://codereview.qt-project.org/6196 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
* Remove redundant qWarning's.Jason McDonald2011-10-072-6/+2
| | | | | | | | | | The removed warnings just repeat information that is already in the QSKIP's that immediately follow the warnings. Change-Id: Id13158487e8075aab8a8f48955303edde3f4af63 Reviewed-on: http://codereview.qt-project.org/6194 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
* Remove redundant define.Jason McDonald2011-10-071-5/+0
| | | | | | | | | | Q_CHECK_PAINTEVENTS was guaranteed to be defined prior to the code that was conditional on it being undefined. Change-Id: I8b48a2c6bff997de7d0e3f640203308718dd865b Reviewed-on: http://codereview.qt-project.org/6193 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
* Comment out test that is always skipped.Jason McDonald2011-10-071-6/+6
| | | | | | | Change-Id: I0af7a5c6708d09ce9b63b7c177d31e0631da43cd Reviewed-on: http://codereview.qt-project.org/6192 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
* Remove dead code and empty test functions.Jason McDonald2011-10-074-29/+0
| | | | | | | Change-Id: Iaf8ac514d814c9321f8dcd09b2bf3331f87154e6 Reviewed-on: http://codereview.qt-project.org/6191 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
* Fail test in preference to calling qFatal.Jason McDonald2011-10-071-4/+2
| | | | | | | | | Calling qFatal may result in test output not being well-formed. Change-Id: Ia16bade4d3311485c6ba4dd23d5624d18b192b71 Reviewed-on: http://codereview.qt-project.org/6190 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
* No need to return after QSKIP.Jason McDonald2011-10-077-44/+16
| | | | | | | | | QSKIP already causes the test function that calls it to return, so the returns removed by this commit were unreachable. Change-Id: I1fa2f3a3271927d8a600b02d8b31bd81db9146b1 Reviewed-on: http://codereview.qt-project.org/6188 Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
* Avoid using QSKIP in lieu of compile-time checksJason McDonald2011-10-0717-182/+191
| | | | | | | | | | | | | | | | QSKIP is intended to be used to skip test functions that are found at run-time to be inapplicable or unsafe. If a test function can be determined to be inapplicable at compile-time, the entire test function should be omitted instead of replacing the body of the test function with a QSKIP, which only serves to slow down test runs and to inflate test run-rates with empty, inapplicable tests. Task-number: QTQAINFRA-278 Change-Id: I95feba3edbfa092c0ef4d85bb8c6877bd6be698e Reviewed-on: http://codereview.qt-project.org/6128 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
* Remove obsolete test functions.Jason McDonald2011-10-071-205/+0
| | | | | | | | | | Commit 2cbeb6c08cb7c79d6126f75c2cbc470679d671e1 made these test functions obsolete. Change-Id: I89a379d7228584a83e9d7674060081f4201f561c Reviewed-on: http://codereview.qt-project.org/6113 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
* Eliminate needless QSKIPs in qaccessibility test.Jason McDonald2011-10-071-174/+139
| | | | | | | | | | | | On Unix the table1 interface was replaced by the table2 interface, while table1 is still used on other platforms. This commit changes the test so that only the applicable test functions are built and run, where previously both sets of tests were built and one set would always skip. Change-Id: I5a785fb88fcbf4e5896e1fdb80c7c0a659597e34 Reviewed-on: http://codereview.qt-project.org/6097 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
* Fix QFont::defaultFamily() in the new QPA world.Pierre Rossi2011-10-071-0/+36
| | | | | | | | | | This is so that the results of LayoutTests in WebKit are more in line with what things were like in Qt 4.8. Change-Id: I25962e03bd8e0316cb303c0d94c25ac4e73ea9a8 Reviewed-on: http://codereview.qt-project.org/6162 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Jiang Jiang <jiang.jiang@nokia.com>
* fix QChar::isSpace() to handle codepoint U+0085Konstantin Ritt2011-10-061-1/+11
| | | | | | | | | | | according to the Unicode specs, code point U+0085 should be treated like a white space character (an exceptional Cc one) Change-Id: Ib17ae0c4d3cdafe667cafa38b645138ef24c238c Merge-request: 32 Reviewed-by: Jiang Jiang <jiang.jiang@nokia.com> Reviewed-on: http://codereview.qt-project.org/6158 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
* Merge fixes for QDir::operator==Shane Kearns2011-10-061-1/+21
| | | | | | | | | | | | | | | | | | There were two fixes in 4.8 which each fixed a part of the problem. Comparing canonical paths is more correct, but is only possible where both directories exist. If neither directory exists, then compare absolute paths instead. Changed a regression test, because /tmp is a symbolic link on MacOS. I.E. "/tmp/.." is canonically "/private" and not "/" as expected. Task-Number: QTBUG-20495 Reviewed-By: joao (cherry-picked from ad35d25e78c8252a72108a4ba931934047c4707e) Change-Id: Ia4986e8337f0e512e1a3398a5a4dd36e62680b9c Reviewed-on: http://codereview.qt-project.org/5813 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Shane Kearns <shane.kearns@accenture.com>
* Create auto test for http HEAD requestShane Kearns2011-10-063-0/+65
| | | | | | | | | | | | This is in order to have a regression test for QT-5304. However the test is also checking basic functionality of head requests too. Task-Number: QT-5304 Change-Id: I0d98bd1f1125ffd49d9f3c859a51b2aaee95379a Reviewed-By: Martin Petersson Reviewed-on: http://codereview.qt-project.org/6033 Reviewed-by: Martin Petersson <Martin.Petersson@nokia.com>
* Fix QDir::operator==(const QDir &) constJoão Abecasis2011-10-061-0/+6
| | | | | | | | | | | | | | | | | | | We can't rely on absolute paths when comparing directories for equality as these don't take into account symbolic links and may also bypass ../ and ./ simplification. Instead, canonical paths must be computed and can then be compared according to the case sensitivity rules for the platform or file engine, as is done in QFileInfo. Task-number: QTBUG-20495 Reviewed-by: Prasanth Ullattil (cherry-picked from dcee6e1371d899eb79717b8e3f3eec08b765db82) Change-Id: Ib5f2a6ee11311c55782ea5dd0e9c3b45f9231686 Reviewed-on: http://codereview.qt-project.org/5812 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: João Abecasis <joao.abecasis@nokia.com>
* Fix unreachable QSKIP in QMenu autotestJason McDonald2011-10-061-5/+2
| | | | | | | | | The QSKIP is only reachable on Mac, so only compile it for Mac. Change-Id: I268e87829e01755051f81cdaf856d936b04b3d49 Reviewed-on: http://codereview.qt-project.org/6091 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
* Improve formatting of QMenu autotestJason McDonald2011-10-061-95/+55
| | | | | | | | | Remove literal tabs and empty functions. Bring layout closer to Qt coding guidelines. Change-Id: I4f1b214c69ee9bfe46c3275eb224e38df15e8744 Reviewed-on: http://codereview.qt-project.org/6090 Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
* Tidy qsqldatabase autotestJason McDonald2011-10-061-39/+18
| | | | | | | | | Remove unused macro and remove redundant returns after calls to QSKIP. Change-Id: Ie333801cbec6c3123931f2fedbcd8902cab69a2e Reviewed-on: http://codereview.qt-project.org/6021 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
* Remove code to selectively run test functions.Jason McDonald2011-10-061-42/+3
| | | | | | | | | | | | | QTestLib already makes a superior version of this functionality available to all tests, without the need to recompile. Each qtestlib test program can be passed, via the command line, a list of test functions and test data tags to be executed instead of executing all test functions. Change-Id: I1b54fc70a0c58a17209817afabfb953b5748dac4 Reviewed-on: http://codereview.qt-project.org/6015 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
* Avoid QSKIP in lieu of compile-time checks.Jason McDonald2011-10-061-59/+49
| | | | | | | | | | Change compiler autotest to omit inapplicable functions at compile-time in preference to skipping at run-time. Change-Id: I8a221cadbb7b59d926754862332c0665673b8a56 Reviewed-on: http://codereview.qt-project.org/6011 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
* Avoid QSKIP in lieu of compile-time check.Jason McDonald2011-10-061-75/+52
| | | | | | | | | Omit focusColors test function at compile-time in preference to skipping at run-time. Also removed commented out code. Change-Id: Ib8955656f5a43b30df95b4c9865e52902dbd6b1e Reviewed-on: http://codereview.qt-project.org/6010 Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
* Tidy QActionGroup autotest.Jason McDonald2011-10-061-57/+1
| | | | | | | | | | | | Remove empty constructor/destructor. Remove dropDownDeleted test function which has been entirely skipped since before Qt 4.0, is obviously incomplete (it attempts to use a QComboBox that does not exist) and provides no statement of intention that might allow the incompleteness to be addressed. Change-Id: I4975b6d5a5dde1e58dab1dd393be92eddeb4c9f8 Reviewed-on: http://codereview.qt-project.org/6009 Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
* Don't build qwindowsurface autotest on Mac OS.Jason McDonald2011-10-062-2/+6
| | | | | | | | | | | The test was a no-op on Mac OS. It's better to avoid building or running it on Mac OS, rather than spending time compiling and running a test that does nothing on that platform. Change-Id: I4aa579036788e404f8a6a8f1a80acd32338fb3cd Reviewed-on: http://codereview.qt-project.org/5958 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
* Accessible: remove calls with virtual int children in test.Frederik Gladhorn2011-10-061-114/+114
| | | | | | | Change-Id: I08ba2fab8ed17b75b971c86cb085af4d3828ec8a Reviewed-on: http://codereview.qt-project.org/6025 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Jan-Arve Sæther <jan-arve.saether@nokia.com>
* Clean up accessible spin box test.Frederik Gladhorn2011-10-061-6/+17
| | | | | | | Change-Id: Ic56f5a99ee57a23d43a81d66af82324ecba8964c Reviewed-on: http://codereview.qt-project.org/5994 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Jan-Arve Sæther <jan-arve.saether@nokia.com>
* Remove empty test function.Frederik Gladhorn2011-10-061-6/+0
| | | | | | | Change-Id: I02b688a25ab77a2df2da8beb57eb94a7432e537d Reviewed-on: http://codereview.qt-project.org/5995 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Jan-Arve Sæther <jan-arve.saether@nokia.com>
* Use child/parent function in QAccessibleWidget and test.Frederik Gladhorn2011-10-061-97/+50
| | | | | | | | | This also uncovered a missing implementation of child for dock widgets. Change-Id: Iac4c5a51d4626769af11b277a9a345e1e31dc490 Reviewed-on: http://codereview.qt-project.org/5987 Reviewed-by: Jan-Arve Sæther <jan-arve.saether@nokia.com>
* Remove obsolete QMatrix test function.Jason McDonald2011-10-061-21/+0
| | | | | | | | | | The operator tested by this function (QMatrix * QRect) has not existed since Qt 2.x. Change-Id: Id09154de2bdda70c0fe342fe78b82709953e2b56 Reviewed-on: http://codereview.qt-project.org/5965 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
* Don't build qitemview autotest on IRIX.Jason McDonald2011-10-062-34/+5
| | | | | | | | | | | | | | The test was being skipped one test function at a time on IRIX. It's better to avoid building or running it, rather than spending time running a test that does nothing on that platform. This commit also turns a silent skip on other platforms into an explicit QSKIP to make it more obvious that there's an unfixed TODO there. Change-Id: I7cae4f0f2eaebf5977a781b2ce15d1e71ef13b36 Reviewed-on: http://codereview.qt-project.org/5957 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
* Removed disabled test data in QDir autotest.Jason McDonald2011-10-061-19/+0
| | | | | | | | | | | | The unprintablenames test was designed to prevent an old failure in QDir from returning, but the test can't be run reliably on some file-systems and certainly isn't going to achieve its goal when it's commented out. Change-Id: Ib4cb965d59c291ab2436130b87e865ac21b9b483 Reviewed-on: http://codereview.qt-project.org/5956 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
* Remove last remnants of Maemo 5 from autotestsJason McDonald2011-10-064-40/+12
| | | | | | | Change-Id: I69bc9a3fc5ec4f7f9b927919ca7627a8a1e61700 Reviewed-on: http://codereview.qt-project.org/5951 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
* Remove last remnants of symbian in autotests.Jason McDonald2011-10-0614-285/+15
| | | | | | | Change-Id: I91489614653cfe4bcf16b723976e33531402a464 Reviewed-on: http://codereview.qt-project.org/5948 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
* Add missing Q_OBJECT macro to GoToStateTransitionKent Hansen2011-10-051-0/+19
| | | | | | | | | | | The missing macro caused qFindChild() to return any QAbstractTransition. Task-number: QTBUG-21813 Change-Id: I80507aa86c8c32d7fa59a1b5ae551043f5f90315 Reviewed-on: http://codereview.qt-project.org/6044 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@nokia.com>
* Added QWindow::isActive() and focus in / out events.Samuel Rødal2011-10-052-30/+90
| | | | | | | | | | | Renamed QGuiApplication::activeWindow() to QGuiApplication::focusWindow(), implemented QWindow::isActive() as a style hint, and added focus in / out events. Change-Id: I71866e76c5a817def3e17bcc20a4fc32081a0e7a Reviewed-on: http://codereview.qt-project.org/5811 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Gunnar Sletta <gunnar.sletta@nokia.com>
* Avoid using QSKIP in lieu of compile-time checksJason McDonald2011-10-0526-332/+294
| | | | | | | | | | | | | | | | QSKIP is intended to be used to skip test functions that are found at run-time to be inapplicable or unsafe. If a test function can be determined to be inapplicable at compile-time, the entire test function should be omitted instead of replacing the body of the test function with a QSKIP, which only serves to slow down test runs and to inflate test run-rates with empty, inapplicable tests. Task-number: QTQAINFRA-278 Change-Id: I582732e3dd657df834f9a98fd52d7ee368f2f29b Reviewed-on: http://codereview.qt-project.org/5946 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
* Remove Symbian-only test function.Jason McDonald2011-10-051-27/+0
| | | | | | | Change-Id: I817c234a6104a072f131c17e9492c68d79ca5f8d Reviewed-on: http://codereview.qt-project.org/5943 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
* Avoid using QSKIP in lieu of compile-time checksJason McDonald2011-10-0529-418/+441
| | | | | | | | | | | | | | | | QSKIP is intended to be used to skip test functions that are found at run-time to be inapplicable or unsafe. If a test function can be determined to be inapplicable at compile-time, the entire test function should be omitted instead of replacing the body of the test function with a QSKIP, which only serves to slow down test runs and to inflate test run-rates with empty, inapplicable tests. Task-number: QTQAINFRA-278 Change-Id: Ib2025339422749cf216e87ac414a3056250bf8f9 Reviewed-on: http://codereview.qt-project.org/5942 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
* Don't crash by modifying read-only shared_nullBradley T. Hughes2011-10-044-0/+56
| | | | | | | | | | | | | | | | | | | Functions that modify the d-pointer must detach or otherwise take measures to not modify the const, read-only shared_null. The setSharable(bool) function takes care to detach when setting sharable to false, but should avoid setting the sharable data member unless d is not the shared null. Similarly, QMap<Key, T>::setInsertInOrder() needs to detach if it is shared with the shared_null (the logic has been updated to be the same as setSharable()). Change-Id: Ida5cb9818b86695f1b9f0264418b955c56424898 Reviewed-on: http://codereview.qt-project.org/5929 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Bradley T. Hughes <bradley.hughes@nokia.com> Reviewed-by: Jan-Arve Sæther <jan-arve.saether@nokia.com>
* Avoid using QSKIP in lieu of compile-time checksJason McDonald2011-10-048-70/+70
| | | | | | | | | | | | | | | | QSKIP is intended to be used to skip test functions that are found at run-time to be inapplicable or unsafe. If a test function can be determined to be inapplicable at compile-time, the entire test function should be omitted instead of replacing the body of the test function with a QSKIP, which only serves to slow down test runs and to inflate test run-rates with empty, inapplicable tests. Task-number: QTQAINFRA-278 Change-Id: I21664d8d92b27c26c64789fc08d0ec7b8988456a Reviewed-on: http://codereview.qt-project.org/5941 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
* Added bug ref in insignificant_test commentJo Asplin2011-10-031-1/+1
| | | | | | | | | Task-number: QTBUG-21814 Change-Id: I56907f2a1fb5555d338b6f1f695b741e1590e5d2 Reviewed-on: http://codereview.qt-project.org/5936 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Jo Asplin <jo.asplin@nokia.com>
* Fix bug in QGraphicsItem::isVisibleTo().Andreas Aardal Hanssen2011-10-031-0/+108
| | | | | | | | | | | | | Task-number: QTBUG-21612 Reviewed-by: James Perrett Reviewed-by: Magne Pettersen Zachrisen Change-Id: I570c673a817c3c01593fcd7fa46d545f34e2c38d Merge-request: 1396 Reviewed-by: Jan-Arve Saether <jan-arve.saether@nokia.com> Reviewed-on: http://codereview.qt-project.org/5927 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Jan-Arve Sæther <jan-arve.saether@nokia.com>
* Simplify QAccessibleAbstractScrollArea and Calendar.Frederik Gladhorn2011-10-031-36/+27
| | | | | | | Change-Id: Iea1df37fd9fd486295458ec7627f5b6908053cdf Reviewed-on: http://codereview.qt-project.org/5727 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Jan-Arve Sæther <jan-arve.saether@nokia.com>
* Prevent QPixmapCache potentially growing indefinitely.Samuel Rødal2011-10-032-1/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | QPixmapCache has until now refused to throw out shared pixmaps, i.e. ones that still have shallow copies lying around. This leads to problems when someone inserts two shallow copies using different keys, causing the cache itself containing multiple shallow copies and thus forever refusing to throw out those entries. It's rather easy for this to accidentally happen in a user application since QPixmap::load() or QPixmap(const QString &fileName, ...) automatically cache the pixmap in the QPixmapCache, thus if the user then calls QPixmapCache::insert() on the same pixmap or a shallow copy it is locked in the QPixmapCache forever. The only reason for not throwing out a pixmap that's shared would be to prevent re-loading a pixmap from file when a user has a direct reference to it in his application, but in that case the user is unlikely to re-load the pixmap from file in any case. Therefore it seems the best fix is to get rid of this limitation. Task-number: QTBUG-21359 Reviewed-by: John Brooks Reviewed-by: Olivier Goffart (cherry picked from commit 7ab0bed3a56d46c386e65abc381264c57137cb43) Change-Id: I46dce19227e19a25e0287cf7372177430da15a66 Reviewed-on: http://codereview.qt-project.org/4563 Reviewed-by: Paul Olav Tvete <paul.tvete@nokia.com>
* Rename description to localizedDescription in Action interface.Frederik Gladhorn2011-10-031-1/+1
| | | | | | | Change-Id: I9e15dabd47bb7dc27cb3748f6763789d8ccc7b42 Reviewed-on: http://codereview.qt-project.org/5622 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Jan-Arve Sæther <jan-arve.saether@nokia.com>
* Make all uses of QBasicAtomicInt and Pointer use load() and store()Thiago Macieira2011-10-037-54/+54
| | | | | | | | | | | | | | Most of these changes are search-and-replace of d->ref ==, d->ref != and d->ref =. The QBasicAtomicPointer in QObjectPrivate::Connection didn't need to be basic, so I made it QAtomicPointer. Change-Id: Ie3271abd1728af599f9ab17c6f4868e475f17bb6 Reviewed-on: http://codereview.qt-project.org/5030 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Bradley T. Hughes <bradley.hughes@nokia.com> Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
* Tests: Fix compilation on Windows.Friedemann Kleint2011-10-0313-43/+36
| | | | | | | | | Replace Q_WS_... by Q_OS_... in corelib tests. Change-Id: I14c41dca1ec490b3c49ba2c24e60def14c6de9da Reviewed-on: http://codereview.qt-project.org/5778 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
* test: Re-enabled `tst_moc' test that is now passing on LinuxSergio Ahumada2011-10-031-2/+0
| | | | | | | | | | This test was fixed by 1cc70b92c8c838a013b45af6814ea6532245067a Change-Id: If6fa3724f7c31e952ebff1dd27fea1a1e4635a85 Reviewed-on: http://codereview.qt-project.org/5783 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Lars Knoll <lars.knoll@nokia.com> Reviewed-by: Jo Asplin <jo.asplin@nokia.com>
* test: Re-enabled `tst_qtranslator' test that is now passing on LinuxSergio Ahumada2011-10-031-2/+0
| | | | | | | | | | This test was fixed by db3418c10b7831db0e6c567ccf49c34698cad1ab Task-number: QTBUG-21125 Change-Id: I1bc549353f16c0df2b6c33533298b302fcc4d4ed Reviewed-on: http://codereview.qt-project.org/5877 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-05-05 00:46:20 +0000